From: Matthew Wilcox <willy@infradead.org>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: BUG_ON(!mapping_empty(&inode->i_data))
Date: Thu, 1 Apr 2021 18:06:15 +0100 [thread overview]
Message-ID: <20210401170615.GH351017@casper.infradead.org> (raw)
In-Reply-To: <alpine.LSU.2.11.2103311413560.1201@eggly.anvils>
On Wed, Mar 31, 2021 at 02:58:12PM -0700, Hugh Dickins wrote:
> I suspect there's a bug in the XArray handling in collapse_file(),
> which sometimes leaves empty nodes behind.
Urp, yes, that can easily happen.
/* This will be less messy when we use multi-index entries */
do {
xas_lock_irq(&xas);
xas_create_range(&xas);
if (!xas_error(&xas))
break;
if (!xas_nomem(&xas, GFP_KERNEL)) {
result = SCAN_FAIL;
goto out;
}
xas_create_range() can absolutely create nodes with zero entries.
So if we create m/n nodes and then it runs out of memory (or cgroup
denies it), we can leave nodes in the tree with zero entries.
There are three options for fixing it ...
- Switch to using multi-index entries. We need to do this anyway, but
I don't yet have a handle on the bugs that you found last time I
pushed this into linux-next. At -rc5 seems like a late stage to be
trying this solution.
- Add an xas_prune_range() that gets called on failure. Should be
straightforward to write, but will be obsolete as soon as we do the
above and it's a pain for the callers.
- Change how xas_create_range() works to merely preallocate the xa_nodes
and not insert them into the tree until we're trying to insert data into
them. I favour this option, and this scenario is amenable to writing
a test that will simulate failure halfway through.
I'm going to start on option 3 now.
next prev parent reply other threads:[~2021-04-01 17:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 1:30 BUG_ON(!mapping_empty(&inode->i_data)) Hugh Dickins
2021-03-31 2:49 ` BUG_ON(!mapping_empty(&inode->i_data)) Matthew Wilcox
2021-03-31 21:58 ` BUG_ON(!mapping_empty(&inode->i_data)) Hugh Dickins
2021-04-01 17:06 ` Matthew Wilcox [this message]
2021-04-02 3:13 ` BUG_ON(!mapping_empty(&inode->i_data)) Matthew Wilcox
2021-04-02 13:27 ` BUG_ON(!mapping_empty(&inode->i_data)) Matthew Wilcox
2021-04-02 17:04 ` BUG_ON(!mapping_empty(&inode->i_data)) Matthew Wilcox
2021-04-02 20:24 ` BUG_ON(!mapping_empty(&inode->i_data)) Hugh Dickins
2021-04-02 21:16 ` BUG_ON(!mapping_empty(&inode->i_data)) Hugh Dickins
2021-04-30 4:16 ` BUG_ON(!mapping_empty(&inode->i_data)) Andrew Morton
2021-04-30 5:41 ` BUG_ON(!mapping_empty(&inode->i_data)) Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401170615.GH351017@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).