From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11330C433ED for ; Tue, 6 Apr 2021 13:39:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA967613C3 for ; Tue, 6 Apr 2021 13:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA967613C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 60D496B007E; Tue, 6 Apr 2021 09:39:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AAFB6B0080; Tue, 6 Apr 2021 09:39:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49B796B0081; Tue, 6 Apr 2021 09:39:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 2EFF46B007E for ; Tue, 6 Apr 2021 09:39:55 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D9AFE2494 for ; Tue, 6 Apr 2021 13:39:54 +0000 (UTC) X-FDA: 78002050308.37.6DC56EE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id C46D740002C4 for ; Tue, 6 Apr 2021 13:39:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+7/Yy8FyGH5pK5mRz0l5jSVYfRzX9mnUy8rv/og0Li0=; b=vxnrURPk4ZMdXwdWGpKk5XuPbF l3xFtxxPz2vTtazTcxXpf7AYJ3llp958/TUesie5bfi48mmp5RTgwD9YF8SnpubF/ONM3aKM/1ZBX qcSK5qr8yTxPzxySQI8lCgz55JDu821gmVEyzENzFhvrOurypJclIu5grnwFOVl4ASaikuotYYWqA ZDV+3WBApfl6evy6wR4r9GWnfwPDFUHeUfY5geb4L0ZQn/PynH2UFbyBO8sMxrcSS52q6tGHBo9RN kjkK+2nR5Ez036FznOaZhNCiZASDlc+s14u9r5twSgtAjJL6nM4ZCc0jXmegS8LdMPYqbSt+ljNMw fyX8iwMQ==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTlvD-00CsBg-F2; Tue, 06 Apr 2021 13:39:14 +0000 Date: Tue, 6 Apr 2021 14:39:11 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 10/27] mm/filemap: Add folio_index, folio_file_page and folio_contains Message-ID: <20210406133911.GI3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-11-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-11-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C46D740002C4 X-Stat-Signature: ndnmmsctzzsw9yj7ebnsmr57xiuunwf3 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf10; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617716391-920975 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Except for the implementation details using the unions field (I'm not going to mention these going forward), this looks good: Reviewed-by: Christoph Hellwig