From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DA0C433ED for ; Tue, 6 Apr 2021 13:52:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E012161241 for ; Tue, 6 Apr 2021 13:52:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E012161241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5A0156B0070; Tue, 6 Apr 2021 09:52:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 529626B007E; Tue, 6 Apr 2021 09:52:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A3836B0081; Tue, 6 Apr 2021 09:52:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id 1CB996B0070 for ; Tue, 6 Apr 2021 09:52:02 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CD7EC82499A8 for ; Tue, 6 Apr 2021 13:52:01 +0000 (UTC) X-FDA: 78002080842.27.B0A9B63 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 4F9732000244 for ; Tue, 6 Apr 2021 13:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=C0e14bdzzRZjl9cTeHAyigRgLdXDB1e3NIgfQJX8fhY=; b=rjVNJKMy9pMQw8UHJfmIxMhuOl QvwaBh/30Oc3OFFG92XSQUXTVrAdZiwHrvvLc/gCxBai8Ck+nkHMEtHRoepXhcm5t98NmAt1bESpE AY/90c5YsyLnmIqfxLABOMgV1U20+rAxT8SCJScJNnusrertCC6mIOjvLyhuVMAU/97j1W8BGD+uR /MsCbnoU7umXrVlfAcHf0n92RRSerPUhL84XgCnRLRUieWtbHSu6wN+95+WcIeN0TNo716CE0Mh9A vKDY4nOUDBNKL7/vkCD257zokFaRGDhN2z8LueXKAZtCqGaqNJ25jgEahB8upRa+ZDN1wvPlmbvJx q5CTYa5Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTm6z-00CtEQ-Ds; Tue, 06 Apr 2021 13:51:30 +0000 Date: Tue, 6 Apr 2021 14:51:21 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 16/27] mm/filemap: Add unlock_folio Message-ID: <20210406135121.GO3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-17-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 4F9732000244 X-Stat-Signature: tc1oa6e37y44r6ake57fzangg3a87ffh Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617717121-335709 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:17PM +0100, Matthew Wilcox (Oracle) wrote: > Convert unlock_page() to call unlock_folio(). By using a folio we > avoid a call to compound_head(). This shortens the function from 39 > bytes to 25 and removes 4 instructions on x86-64. Because we still > have unlock_page(), it's a net increase of 24 bytes of text for the > kernel as a whole, but any path that uses unlock_folio() will execute > 4 fewer instructions. Looks good, Reviewed-by: Christoph Hellwig