From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FCFC433ED for ; Tue, 6 Apr 2021 13:58:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D8CE6128B for ; Tue, 6 Apr 2021 13:58:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D8CE6128B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ACAEE6B0080; Tue, 6 Apr 2021 09:58:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA06B6B0081; Tue, 6 Apr 2021 09:58:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 98F736B0082; Tue, 6 Apr 2021 09:58:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id 813E86B0080 for ; Tue, 6 Apr 2021 09:58:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4433E180ACF76 for ; Tue, 6 Apr 2021 13:58:20 +0000 (UTC) X-FDA: 78002096760.26.0FA3B61 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id C8C18200024C for ; Tue, 6 Apr 2021 13:58:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xdVYuW+gbiOxbxB3U0bNC9sVbHKkGQf7dwoQZGExKhc=; b=f2t37RoJlqsBWWtrooL30jycBF W1dHpBPK3mMoOjz9PBOz8+c9HTnI82yJ7QjqteYXeTAwQEQ0JhAZ6dS1Ua3S2AyJdHMUJ/nxgKD/+ CDYPRWODGkkshW+jSh+0NClqFx8WKgf4v0qqcBvXHJS6NNf5onKza36rE6h9QCUkjdA16gTAv+76O RxGyvZDivjlqwnstHpTZ5vypMVd/uLER8ZHYSWsLb0c8g7I+WqVHzHdt19/5vnmoRsv7IfOfSwFGA JY4B9wh/nKTu6NXHnDGy9SuIkVlhwpcnNgFGu5J2d4WChMG+++srgp1oLBR1quy55/BxwLjHCsKGo i3+q7wcg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmCr-00CtiQ-JT; Tue, 06 Apr 2021 13:57:32 +0000 Date: Tue, 6 Apr 2021 14:57:25 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 20/27] mm/filemap: Add __lock_folio_or_retry Message-ID: <20210406135725.GS3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-21-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-21-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C8C18200024C X-Stat-Signature: x46yksbcdxyba3chwbz93oxk7qbgx8ng Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf18; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617717499-915247 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:21PM +0100, Matthew Wilcox (Oracle) wrote: > Convert __lock_page_or_retry() to __lock_folio_or_retry(). This actually > saves 4 bytes in the only caller of lock_page_or_retry() (due to better > register allocation) and saves the 20 byte cost of calling page_folio() > in __lock_folio_or_retry() for a total saving of 24 bytes. Looks good, Reviewed-by: Christoph Hellwig