From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45607C433B4 for ; Tue, 6 Apr 2021 14:13:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E1870613A0 for ; Tue, 6 Apr 2021 14:13:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1870613A0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5FD466B0081; Tue, 6 Apr 2021 10:13:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AD846B0082; Tue, 6 Apr 2021 10:13:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44ED76B0083; Tue, 6 Apr 2021 10:13:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id 2856E6B0081 for ; Tue, 6 Apr 2021 10:13:15 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D45E618014A18 for ; Tue, 6 Apr 2021 14:13:14 +0000 (UTC) X-FDA: 78002134308.11.327883B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 5E1C12000249 for ; Tue, 6 Apr 2021 14:13:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pZwMcf5iEm9vQedhznNSrB1eoBlpxK0vTkFxcd3+VS4=; b=fCLis4aRjdezyDv5mCGo2tcDKb /AR6CsS8iGBK+ThwUJMuULlVAdDQeN+Rmlex9MFGZisePOqgXNQc75EAcPGIrjJBLtp+JgHU7uY2B 2emgSSuq+jO6ayyxTR85dlGVBsWYGiw7GGtEcZHtZMhMVSlG6oc47q4iVx/orrKOTHVwXApxp25z3 SsBTeJkKze3KLs5dfdAJ0SM58KVMz2trc2ExJhm/OMdoqxgWfP7oGHKdvJMkgeat/ID0uyHa0qB5j BYo2KlA3pI3KSXUxBX0dl1BwiVWQ/blR2F9+joYd/hnqH37P27I0WFubF503vmc6Tgk+H6/kAaLXl r/dvou2Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmQp-00Cukf-Ls; Tue, 06 Apr 2021 14:12:11 +0000 Date: Tue, 6 Apr 2021 15:11:51 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 21/27] mm/filemap: Add wait_on_folio_locked Message-ID: <20210406141151.GT3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-22-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-22-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 5E1C12000249 X-Stat-Signature: fg7d5u18iqymkfhtsgs6d3aibfnwwa71 X-Rspamd-Server: rspam02 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf28; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617718392-493451 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:22PM +0100, Matthew Wilcox (Oracle) wrote: > Also add wait_on_folio_locked_killable(). Turn wait_on_page_locked() > and wait_on_page_locked_killable() into wrappers. This eliminates a > call to compound_head() from each call-site, reducing text size by 200 > bytes for me. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig