From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8218C433ED for ; Tue, 6 Apr 2021 14:14:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 909C46139C for ; Tue, 6 Apr 2021 14:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 909C46139C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1C93E6B0081; Tue, 6 Apr 2021 10:14:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1662D6B0082; Tue, 6 Apr 2021 10:14:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07CB26B0083; Tue, 6 Apr 2021 10:14:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0181.hostedemail.com [216.40.44.181]) by kanga.kvack.org (Postfix) with ESMTP id E2B156B0081 for ; Tue, 6 Apr 2021 10:14:26 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9F1DE68BE for ; Tue, 6 Apr 2021 14:14:26 +0000 (UTC) X-FDA: 78002137332.20.937C3F9 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 2C41DE000119 for ; Tue, 6 Apr 2021 14:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sW2y093nFNEIVmRMn1QkeEs0LwLNK5xSldsHE5h9ZOM=; b=oVysegC+dFydqmBJ0Byn5gAzg+ A4X43UInM3ZxUMbOYHtO0IGNAQBlWH4n3ELfVtf1pSU8lVt3e+FXqu1ONsj+6ZScylr8v5YiyI1IZ QmvJ23g0LstpSSoZ6nK2ELlIc2r+XqVVhZeG6zS2eYg4tAyA9bE95Em6nCYtj2s9B5a+h1liXzIRn zAX9NPiOHzPHEbnCHUme0KSwP4206wkrvBogXBtY/SHNjssg+gHmME/e9Pn82HJ4EbuqpN8jwPWoK S2Y8GIaz9bqQc3Ubeie3q9oNwBWIMnfnHNjUNVsuFwIuFZQqkdFODJsT82gKylHGnN8cbItx2dvBj bz8tASKg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmSM-00Cuq9-3M; Tue, 06 Apr 2021 14:13:31 +0000 Date: Tue, 6 Apr 2021 15:13:26 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 22/27] mm/filemap: Add end_folio_writeback Message-ID: <20210406141326.GU3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-23-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-23-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2C41DE000119 X-Stat-Signature: qyypdedmdq5tddoprktte796tznpi4j3 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617718460-754576 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:23PM +0100, Matthew Wilcox (Oracle) wrote: > Add an end_page_writeback() wrapper function for users that are not yet > converted to folios. > > end_folio_writeback() is less than half the size of end_page_writeback() > at just 105 bytes compared to 213 bytes, due to removing all the > compound_head() calls. The 30 byte wrapper function makes this a net > saving of 70 bytes. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good, Reviewed-by: Christoph Hellwig