From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80FA7C433ED for ; Tue, 6 Apr 2021 14:24:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 350BC613BD for ; Tue, 6 Apr 2021 14:24:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 350BC613BD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 889396B0081; Tue, 6 Apr 2021 10:24:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 811886B0082; Tue, 6 Apr 2021 10:24:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68AF76B0083; Tue, 6 Apr 2021 10:24:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id 4827F6B0081 for ; Tue, 6 Apr 2021 10:24:01 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id F03A38249980 for ; Tue, 6 Apr 2021 14:24:00 +0000 (UTC) X-FDA: 78002161440.38.F675E87 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 9A096E000110 for ; Tue, 6 Apr 2021 14:23:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h8Ohb5Nl+BWd1e8JB1eKnm6zirqglOxK/PIdWxnDxGc=; b=RnPjPifYJLwE8ugTNLmyZ8ufmm WkEAfmFeG9q6iEoiCYK01PLavR5/z1Ea4z/iZjVNq3RoXmBLDHxU2mR1d6x4lQb3YAJa9jlqe2u+r eWPQNkHGCaIOwyTOx0kdTw/1R64fQMrQPB0S1WenBmo34SNWpd+eqmqq1Nc5AjilJSqMKoNrGa5T4 +8s5HQC9vZbW0JmxPcovuIisYw+eH1XijlQmlnqGLI0hsA6TNlmYE3BHSXf7pj+134GYbN1SvgY2W MlHFBTxAFVE1Fxrv6faOk/PuDsSlfZleybcANMFgDb/y/bSLGsUoBOgI0yCZoZitYnZPhZRPgWqoZ 6895580w==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmbs-00Cvj3-2f; Tue, 06 Apr 2021 14:23:22 +0000 Date: Tue, 6 Apr 2021 15:23:16 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 26/27] mm/filemap: Convert wake_up_page_bit to wake_up_folio_bit Message-ID: <20210406142316.GY3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-27-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-27-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 9A096E000110 X-Stat-Signature: hq69hfhrdzerqr7finik3rngrk64frac Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf30; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617719035-94878 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 31, 2021 at 07:47:27PM +0100, Matthew Wilcox (Oracle) wrote: > void unlock_page_private_2(struct page *page) > { > - page = compound_head(page); > - VM_BUG_ON_PAGE(!PagePrivate2(page), page); > - clear_bit_unlock(PG_private_2, &page->flags); > - wake_up_page_bit(page, PG_private_2); > + struct folio *folio = page_folio(page); > + VM_BUG_ON_FOLIO(!FolioPrivate2(folio), folio); A whitespace between the declaration and the code would be nice. Otherwise looks good; Reviewed-by: Christoph Hellwig