From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CF7CC433B4 for ; Tue, 6 Apr 2021 15:08:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A9AEE61279 for ; Tue, 6 Apr 2021 15:08:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9AEE61279 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EE6F76B0081; Tue, 6 Apr 2021 11:08:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E97686B0082; Tue, 6 Apr 2021 11:08:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4C436B0083; Tue, 6 Apr 2021 11:08:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0128.hostedemail.com [216.40.44.128]) by kanga.kvack.org (Postfix) with ESMTP id B65406B0081 for ; Tue, 6 Apr 2021 11:08:05 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 651898134 for ; Tue, 6 Apr 2021 15:08:05 +0000 (UTC) X-FDA: 78002272530.36.AAE583B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 71C2813A for ; Tue, 6 Apr 2021 15:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lDs7/lCOjqt9xEn6CNej+2SxO3jRNqh20hRXcKO0GYg=; b=I8nVYP3I1MUGAF7JEjSydH9W0+ yekQ0x5fiIsBdIbM2C2elScPeQdYie5pfHnFpuWuC3sI75XmS5jSTkKQgQcBgwnEVX30QIUg8sJno +FLXbuLADU6UdEk+h4d+YIf6pr41znZIg6lJVRl6OxjMZoRVwZfIId/7qOCdc1Op1XJgnTJxj1hu+ P0S8raOEI5fYhh6jp9q5cqh1GgXbxT5P9ozAUvv7RoI8s4V5nLezKmeCEMtSq9k0V3dophXH3W4kl Z32V4NoUFjCJE86Lk/lZRRRAq/TSzwCWWfEBzA7r2UhXkcIzBEpvP71HEzBt+CpDaL3rWmQuMBPnb BFq+Hl4w==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTnH4-00Cz7X-Fq; Tue, 06 Apr 2021 15:06:09 +0000 Date: Tue, 6 Apr 2021 16:05:50 +0100 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 01/27] mm: Introduce struct folio Message-ID: <20210406150550.GA3094215@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-2-willy@infradead.org> <20210406122918.h5dsnbjhmwpfasf4@box.shutemov.name> <20210406124807.GO2531743@casper.infradead.org> <20210406143150.GA3082513@infradead.org> <20210406144022.GR2531743@casper.infradead.org> <20210406144712.GA3087660@infradead.org> <20210406145511.GS2531743@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210406145511.GS2531743@casper.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 71C2813A X-Stat-Signature: mcrmzdzx3rp15yt1syds4pmog176c5to X-Rspamd-Server: rspam02 Received-SPF: none (casper.srs.infradead.org>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617721683-509224 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 06, 2021 at 03:55:11PM +0100, Matthew Wilcox wrote: > Assuming we're getting rid of them all though, we have to include: > > $ git grep 'page->mapping' fs |wc -l > 358 > $ git grep 'page->index' fs |wc -l > 355 Are they all going to stay? Or are we going to clean up some of that mess. A lot of ->index should be page_offet, and on the mapping side the page_mapping and page_file_mapping mess is also waiting to be sorted..