From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33C88C433B4 for ; Thu, 8 Apr 2021 13:36:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7D82E61158 for ; Thu, 8 Apr 2021 13:36:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D82E61158 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BD0356B0078; Thu, 8 Apr 2021 09:36:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B81376B007E; Thu, 8 Apr 2021 09:36:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A21896B0080; Thu, 8 Apr 2021 09:36:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 879C46B0078 for ; Thu, 8 Apr 2021 09:36:41 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 3A39D1838A43C for ; Thu, 8 Apr 2021 13:36:41 +0000 (UTC) X-FDA: 78009299802.29.DB56779 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by imf22.hostedemail.com (Postfix) with ESMTP id 9F393C0007CA for ; Thu, 8 Apr 2021 13:36:32 +0000 (UTC) Received: from zn.tnic (p200300ec2f095000f2588bda42a4deac.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:5000:f258:8bda:42a4:deac]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DB7111EC027D; Thu, 8 Apr 2021 15:36:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1617888993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=rcbTJeL0qCfNlPnpFLbjPA0s8qIHLH+BaXYJGvFUr2g=; b=PDCV24O1Z649Q88tnfXsownQZeUZXSFWR4FeNJSNsjta/DvUSRpxK6tGwEy/LLEsimBc3D vqG2xQAf0LQ8xFqh3OAbTmynPGnaGgadjobeZppnuKJvD65My0JpcpEe67bjZqYLSBmx7i Lz7rgxBlHvmE7q2v5J6kjVbFNDzX438= Date: Thu, 8 Apr 2021 15:36:31 +0200 From: Borislav Petkov To: Tony Luck Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andy Lutomirski , Aili Yao , HORIGUCHI =?utf-8?B?TkFPWUEoIOWggOWPo+OAgOebtOS5nyk=?= Subject: Re: [PATCH 4/4] x86/mce: Avoid infinite loop for copy from user recovery Message-ID: <20210408133631.GJ10192@zn.tnic> References: <20210326000235.370514-1-tony.luck@intel.com> <20210326000235.370514-5-tony.luck@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326000235.370514-5-tony.luck@intel.com> X-Rspamd-Queue-Id: 9F393C0007CA X-Stat-Signature: sx74y4tscwcfpqj5pki9fpqbnqhmqu3x X-Rspamd-Server: rspam02 Received-SPF: none (alien8.de>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail.skyhub.de; client-ip=5.9.137.197 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617888992-458263 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 25, 2021 at 05:02:35PM -0700, Tony Luck wrote: ... > Expected worst case is two machine checks before moving on (e.g. one user > access with page faults disabled, then a repeat to the same addrsss with > page faults enabled). Just in case there is some code that loops forever > enforce a limit of 10. > > Signed-off-by: Tony Luck > --- > arch/x86/kernel/cpu/mce/core.c | 40 ++++++++++++++++++++++++++-------- > include/linux/sched.h | 1 + > 2 files changed, 32 insertions(+), 9 deletions(-) What I'm still unclear on, does this new version address that "mysterious" hang or panic which the validation team triggered or you haven't checked yet? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette