From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D48D6C433ED for ; Fri, 9 Apr 2021 11:26:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6711C6113A for ; Fri, 9 Apr 2021 11:26:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6711C6113A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E48E76B006E; Fri, 9 Apr 2021 07:26:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E20596B0070; Fri, 9 Apr 2021 07:26:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC0B36B0071; Fri, 9 Apr 2021 07:26:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0063.hostedemail.com [216.40.44.63]) by kanga.kvack.org (Postfix) with ESMTP id AF6946B006E for ; Fri, 9 Apr 2021 07:26:39 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5A0745008 for ; Fri, 9 Apr 2021 11:26:39 +0000 (UTC) X-FDA: 78012600918.33.B585290 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 8A835C0007D2 for ; Fri, 9 Apr 2021 11:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=r8vsQAWqPO257QZ14b6/67BsYk32ojx3EAVHaQFltyM=; b=ZqgBOOOVr8Xg5gLfjCGe8UTcyL VLHWVrkDWGsOAZvGBCi4v8R7+frMSg3kDV6atzgQdS7NNpzGiR2I2TDzdZ3Knat9ed2wUzhjsCpNh FJD0HeD7A6k5ik83urs9txoAuWXtj7Pj2VIoLObRahlAS3m6xtw64nBdwjyCskD5+kgPTER6b4e4w C8Ms8a2NHJ5vu8vaLJL9efvyWzIZE45C+Y23OLonG9BpTSIfkJkHBUApavG/uyd60BKQDn1h/h9k0 xKaEE0zYerAUJCJfF+J6B3JoDsrnDALhW/tmeOA+8BJ2fvVnmUzxtR411IpAZXL3csMnvGbV6sza6 Wbkz1ZyA==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lUpFw-000HJN-Uc; Fri, 09 Apr 2021 11:25:05 +0000 Date: Fri, 9 Apr 2021 12:24:56 +0100 From: Matthew Wilcox To: David Howells Cc: torvalds@linux-foundation.org, Christoph Hellwig , Josef Bacik , Alexander Viro , Andrew Morton , linux-mm@kvack.org, linux-cachefs@redhat.com, jlayton@kernel.org, linux-fsdevel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/3] mm: Split page_has_private() in two to better handle PG_private_2 Message-ID: <20210409112456.GS2531743@casper.infradead.org> References: <161796596902.350846.10297397888865722494.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <161796596902.350846.10297397888865722494.stgit@warthog.procyon.org.uk> X-Stat-Signature: hi4jrt9ferkhkkuwg51649936kfxqp3a X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8A835C0007D2 Received-SPF: none (infradead.org>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=casper.infradead.org; client-ip=90.155.50.34 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617967593-630158 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 09, 2021 at 11:59:29AM +0100, David Howells wrote: > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 414769a6ad11..9c89db033548 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -41,7 +41,7 @@ static inline struct iomap_page *to_iomap_page(struct page *page) > */ > VM_BUG_ON_PGFLAGS(PageTail(page), page); > > - if (page_has_private(page)) > + if (page_needs_cleanup(page)) That should be PagePrivate(page) > return (struct iomap_page *)page_private(page); > return NULL; > } > @@ -163,7 +163,7 @@ iomap_set_range_uptodate(struct page *page, unsigned off, unsigned len) > if (PageError(page)) > return; > > - if (page_has_private(page)) > + if (PagePrivate(page)) > iomap_iop_set_range_uptodate(page, off, len); > else > SetPageUptodate(page); > @@ -502,7 +502,7 @@ iomap_migrate_page(struct address_space *mapping, struct page *newpage, > if (ret != MIGRATEPAGE_SUCCESS) > return ret; > > - if (page_has_private(page)) > + if (PagePrivate(page)) > attach_page_private(newpage, detach_page_private(page)); > > if (mode != MIGRATE_SYNC_NO_COPY)