From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73BDC43461 for ; Fri, 9 Apr 2021 15:07:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 594D361177 for ; Fri, 9 Apr 2021 15:07:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 594D361177 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DEDA06B006E; Fri, 9 Apr 2021 11:07:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9096B0070; Fri, 9 Apr 2021 11:07:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEFF56B0071; Fri, 9 Apr 2021 11:07:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 9FC7D6B006E for ; Fri, 9 Apr 2021 11:07:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 503EE8248047 for ; Fri, 9 Apr 2021 15:07:43 +0000 (UTC) X-FDA: 78013158006.28.69165B5 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf25.hostedemail.com (Postfix) with ESMTP id 0CD2D6000106 for ; Fri, 9 Apr 2021 15:07:40 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id u10so6841923lju.7 for ; Fri, 09 Apr 2021 08:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5R0fVCeHI02UlQLdapgLA7qXq0+kRyGBepCME8oAmkA=; b=rc6Z9d4IrUjZ4kexJ6ehZlP6IFxFELakXS9VnTdU1bv6iIntHvfsZUNsj7QkKlZwJB h9HN8ZYHKiwQdHk3IU5LT+e60cRaQ2qaK//ec5Gn4aibdvxcnL0AH5jbgC2IvJveUkTn 0lJRkO8x3efs1EOYUtjTM/1tHAjaBbrprV6udKvD7ELb1TfCEQREsVVFAUa/N9+ZLYr6 j2f04sXurWjLi5UsN8I71AgGLO1s8vXq2zEEcpXm6cuBK5tbL0hYS/8RAJZ01WTj8j7j 87iblWwGwyWhmUfqgClFYrJyqKIWBySgwZIbx8QSCstd+Bl0Knj+sUtgVQv9E6G0+ull 2tCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5R0fVCeHI02UlQLdapgLA7qXq0+kRyGBepCME8oAmkA=; b=gEpDA9pfD4emoEF2tTv9mVf0iBVlK9MhFxsN3Pm9yygTzKSneoKmQVkx9c+c9gVKTn Ca9Biylm8eil8GzegALF0zk5AZtNk5c7JNVb7Sk7iWvziUEH24gW5EL1D69gc1ty141e ZGh5NjGMKxpCe5SvrA4DCMQUO00PbB0KF4OSVdtrEn5kkp1oTA4Pllr+dQX4Vky0SKVR XzD/aFEGaPZWHbEEw0kc1Fj1P8bYpjuOjUGj+f/CpeXXdm5VJXeIk7KaXEarBjQ+vNf7 myOt1ynL8Pv51XCg1a3GwG2snYiRPqcjuZsGf0vRL46o8qytMclzKQ4mhaPwrNLmipiJ tcmw== X-Gm-Message-State: AOAM530xBxPw/0qx+YMLxAMv6IgPSjJ23++jyprPHsnJ4cims8nO4AQK kl+XAuZ/aIKYjYgT072pjj28bA== X-Google-Smtp-Source: ABdhPJy7ldNuQTjwQekvob6ldP9BqT3S8xV53RsxLS7SF7QEPJ/vfYmt9l2XEIpgFi1qf8DmGODT/w== X-Received: by 2002:a05:651c:2129:: with SMTP id a41mr9940174ljq.193.1617980861126; Fri, 09 Apr 2021 08:07:41 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id i4sm290997lfv.161.2021.04.09.08.07.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 08:07:40 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id C7AEF102498; Fri, 9 Apr 2021 18:07:39 +0300 (+03) Date: Fri, 9 Apr 2021 18:07:39 +0300 From: "Kirill A. Shutemov" To: Yu-cheng Yu Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Haitao Huang , "Kirill A . Shutemov" Subject: Re: [PATCH v24 12/30] x86/mm: Update ptep_set_wrprotect() and pmdp_set_wrprotect() for transition from _PAGE_DIRTY to _PAGE_COW Message-ID: <20210409150739.y2ahsuoog6mivckq@box.shutemov.name> References: <20210401221104.31584-1-yu-cheng.yu@intel.com> <20210401221104.31584-13-yu-cheng.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210401221104.31584-13-yu-cheng.yu@intel.com> X-Stat-Signature: rq3twjqu5y98qrkxfstus9pq7rs6ymwb X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0CD2D6000106 Received-SPF: none (shutemov.name>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail-lj1-f182.google.com; client-ip=209.85.208.182 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617980860-974155 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 01, 2021 at 03:10:46PM -0700, Yu-cheng Yu wrote: > When Shadow Stack is introduced, [R/O + _PAGE_DIRTY] PTE is reserved for > shadow stack. Copy-on-write PTEs have [R/O + _PAGE_COW]. > > When a PTE goes from [R/W + _PAGE_DIRTY] to [R/O + _PAGE_COW], it could > become a transient shadow stack PTE in two cases: > > The first case is that some processors can start a write but end up seeing > a read-only PTE by the time they get to the Dirty bit, creating a transient > shadow stack PTE. However, this will not occur on processors supporting > Shadow Stack, and a TLB flush is not necessary. > > The second case is that when _PAGE_DIRTY is replaced with _PAGE_COW non- > atomically, a transient shadow stack PTE can be created as a result. > Thus, prevent that with cmpxchg. > > Dave Hansen, Jann Horn, Andy Lutomirski, and Peter Zijlstra provided many > insights to the issue. Jann Horn provided the cmpxchg solution. > > Signed-off-by: Yu-cheng Yu > Reviewed-by: Kees Cook > Cc: Kirill A. Shutemov Reviewed-by: Kirill A. Shutemov -- Kirill A. Shutemov