From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FDAC433ED for ; Sat, 10 Apr 2021 10:58:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E864F6101D for ; Sat, 10 Apr 2021 10:58:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E864F6101D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 77CD76B006C; Sat, 10 Apr 2021 06:58:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7548E6B006E; Sat, 10 Apr 2021 06:58:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A6A86B0070; Sat, 10 Apr 2021 06:58:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0180.hostedemail.com [216.40.44.180]) by kanga.kvack.org (Postfix) with ESMTP id 3CBE86B006C for ; Sat, 10 Apr 2021 06:58:17 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CC07E8248047 for ; Sat, 10 Apr 2021 10:58:16 +0000 (UTC) X-FDA: 78016158192.22.ECAB75C Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf24.hostedemail.com (Postfix) with ESMTP id DB5C4A000398 for ; Sat, 10 Apr 2021 10:58:11 +0000 (UTC) Received: by mail-ed1-f50.google.com with SMTP id g17so8659295edm.6 for ; Sat, 10 Apr 2021 03:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=rXYsHG3mre/V1Rg4udvEnf6Zyhecq0scL5Z8jX06kJE=; b=ejFKL3jofImx/+4W0WfCPMDVP9qon0V8sVEmSSrzDl+mN+CFVeLw+Ccojknv+GEVSb 4FQBxrp+0hG62BC79GScl9tYP4gxbToBy9xJM3FXuzE/7CGeQwJN0YOAGUiGgsMtk3ay j3soYxvidxwpRKaEuHBmNSIwyweUMOz31QYMjE5daL0oTRKnIvHdJ0KTUfTViHr1+Umz 22ud7RMUhSfNcDQzA8ZC4abiyXCPFewq+Vemow3N8zAn1r/ZfaEk+lkBiv/m2+ogCMoQ K8VEDtAjHVJUIQVPAORgdxRfWc5MpPsXE6WVqnbxYgf32r6ejAihkAtJMkA45OnCWd3D G9QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=rXYsHG3mre/V1Rg4udvEnf6Zyhecq0scL5Z8jX06kJE=; b=eLAHyfXCWV16ZRyplBrKIJvdMeoEtsDXMnH0aYsKrZHHBNs1RoabvHmRKTqMe3sYkF 8GKCo+3zlcPmvsxx4+xeQZrRQwT3Kws86hvFDHNc842+pt6EU6x1pgmmQwc03xCDYXoz xYFm6vPzigauVEfN948O88EvOVdnTHPGV2Nq5qvbONhfYQeQGNc96JIggF3nag4/9cLN XaI0SYyLfJ9GEgLpltll+PoxCEJgUjGF5nkUhftDwiWwuYNCAVGOIEGK6nkZRskdPjoG z1K9Bt6mzR5frLRsxUYx5AxiEaf3jTaKxICPxY61XOl+gXhZIHCKm99SJVFl5hXiJB+F lUyw== X-Gm-Message-State: AOAM5339ZmRaQ/3J/PmjxnDaMhm/90U6raA5sPHx0CPXjp1V3DmjJXYq 1++luUbbtfIuhh9ANoNf2LU= X-Google-Smtp-Source: ABdhPJwD2huBIGY1JQUImXC1zPdJeA0+yCL5ahszNVf+Orz2fpn1/PZjAa1tREwuaIn/ooYQXATB9g== X-Received: by 2002:a05:6402:350b:: with SMTP id b11mr20899457edd.288.1618052295285; Sat, 10 Apr 2021 03:58:15 -0700 (PDT) Received: from localhost.localdomain ([2a02:2454:826:3e00:ced:ed1a:293:c96]) by smtp.gmail.com with ESMTPSA id o17sm2888503edt.10.2021.04.10.03.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Apr 2021 03:58:14 -0700 (PDT) From: SeongJae Park To: Greg KH Cc: SeongJae Park , akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface Date: Sat, 10 Apr 2021 12:57:59 +0200 Message-Id: <20210410105759.12611-1-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: X-Stat-Signature: 4rdne7kzmpcxu8aoufo5ajgnccw5zi5n X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: DB5C4A000398 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf24; identity=mailfrom; envelope-from=""; helo=mail-ed1-f50.google.com; client-ip=209.85.208.50 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618052291-658151 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park On Sat, 10 Apr 2021 10:55:01 +0200 Greg KH wrote: > On Thu, Apr 08, 2021 at 01:48:48PM +0000, SeongJae Park wrote: > > +static int dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) > > +{ > > + const char * const file_names[] = {"attrs", "target_ids"}; > > + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(file_names); i++) > > + debugfs_create_file(file_names[i], 0600, dir, ctx, fops[i]); > > + > > + return 0; > > +} > > Why do you have a function that can only return 0, actually return > something? It should be void, right? You're right, I will make it return void in the next spin. Thanks, SeongJae Park > > thanks, > > greg k-h >