From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B853C433ED for ; Mon, 12 Apr 2021 08:15:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1CFD16120F for ; Mon, 12 Apr 2021 08:15:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CFD16120F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A57D36B0036; Mon, 12 Apr 2021 04:15:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A2F386B006C; Mon, 12 Apr 2021 04:15:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F66C6B006E; Mon, 12 Apr 2021 04:15:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 728A66B0036 for ; Mon, 12 Apr 2021 04:15:22 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 215DF18024DF1 for ; Mon, 12 Apr 2021 08:15:22 +0000 (UTC) X-FDA: 78023005284.32.C6C24F2 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf04.hostedemail.com (Postfix) with ESMTP id 11E623C2 for ; Mon, 12 Apr 2021 08:15:19 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 6F7FB600EF; Mon, 12 Apr 2021 08:15:18 +0000 (UTC) Date: Mon, 12 Apr 2021 09:15:15 +0100 From: Catalin Marinas To: Andrew Morton Cc: Andrey Konovalov , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Nathan Chancellor , Arnd Bergmann , kasan-dev , Linux Memory Management List , LKML , Linux ARM , wsd_upstream , "moderated list:ARM/Mediatek SoC..." , Walter Wu Subject: Re: [PATCH v4] kasan: remove redundant config option Message-ID: <20210412081515.GB2060@arm.com> References: <20210226012531.29231-1-walter-zh.wu@mediatek.com> <20210330223637.f3c73a78c64587e615d26766@linux-foundation.org> <20210411105332.GA23778@arm.com> <20210411150316.d60aa0b5174adf2370538809@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210411150316.d60aa0b5174adf2370538809@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 11E623C2 X-Stat-Signature: 571nwpjeux86z35ddky6g9swcmg65s5e Received-SPF: none (kernel.org>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: none/none X-HE-Tag: 1618215319-979932 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Apr 11, 2021 at 03:03:16PM -0700, Andrew Morton wrote: > On Sun, 11 Apr 2021 11:53:33 +0100 Catalin Marinas wrote: > > On Tue, Mar 30, 2021 at 10:36:37PM -0700, Andrew Morton wrote: > > > On Mon, 29 Mar 2021 16:54:26 +0200 Andrey Konovalov wrote: > > > > Looks like my patch "kasan: fix KASAN_STACK dependency for HW_TAGS" > > > > that was merged into 5.12-rc causes a build time warning: > > > > > > > > include/linux/kasan.h:333:30: warning: 'CONFIG_KASAN_STACK' is not > > > > defined, evaluates to 0 [-Wundef] > > > > #if defined(CONFIG_KASAN) && CONFIG_KASAN_STACK > > > > > > > > The fix for it would either be reverting the patch (which would leave > > > > the initial issue unfixed) or applying this "kasan: remove redundant > > > > config option" patch. > > > > > > > > Would it be possible to send this patch (with the fix-up you have in > > > > mm) for the next 5.12-rc? > > > > > > > > Here are the required tags: > > > > > > > > Fixes: d9b571c885a8 ("kasan: fix KASAN_STACK dependency for HW_TAGS") > > > > Cc: stable@vger.kernel.org > > > > > > Got it, thanks. I updated the changelog to mention the warning fix and > > > moved these ahead for a -rc merge. > > > > Is there a chance this patch makes it into 5.12? I still get the warning > > with the latest Linus' tree (v5.12-rc6-408-g52e44129fba5) when enabling > > KASAN_HW_TAGS. > > Trying. We're still awaiting a tested fix for > https://lkml.kernel.org/r/CA+fCnZf1ABrQg0dsxtoZa9zM1BSbLYq_Xbu+xi9cv8WAZxdC2g@mail.gmail.com Thanks Andrew. I didn't realise it was sent and then dropped. However, we should decouple (or rather reorder) the two patches. There's no functional dependency between removing the redundant config option (a fix for an existing commit) and adding support for KASAN_SW_TAGS with gcc-11, only a conflict in scripts/Makefile.kasan. Walter's original patch applies on top of vanilla 5.12-rc3: https://lkml.kernel.org/r/20210226012531.29231-1-walter-zh.wu@mediatek.com -- Catalin