From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7CA8C433ED for ; Mon, 12 Apr 2021 11:23:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 62FF86121D for ; Mon, 12 Apr 2021 11:23:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 62FF86121D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E8DDC6B0036; Mon, 12 Apr 2021 07:23:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3E076B006C; Mon, 12 Apr 2021 07:23:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C74BE6B006E; Mon, 12 Apr 2021 07:23:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id A74536B0036 for ; Mon, 12 Apr 2021 07:23:09 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 625808248047 for ; Mon, 12 Apr 2021 11:23:09 +0000 (UTC) X-FDA: 78023478498.40.93DB263 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf06.hostedemail.com (Postfix) with ESMTP id BAFDDC0001EE for ; Mon, 12 Apr 2021 11:23:10 +0000 (UTC) Received: by mail-qt1-f169.google.com with SMTP id z15so1507804qtj.7 for ; Mon, 12 Apr 2021 04:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to; bh=OgUbXuBzSRofrzBQCx4mAQ2LZNbN5PuQPiNdAazw0Ho=; b=ZUBD1jGgN6XVnao7IsxZ1I2FDe29dEXCHyjYN0tFkc5/yUMstzOWmWVrdUT6d7JQPe cSE9RueHb8pfoYnq9NQZ5giDoEiqPqdSW2XYpQVIagiyw744yfNUfJHpe9shZFRRevWn K/RHIfJjEEcm1YossFY3GwkyJoByA1c2Bo6n9Yo3oUTTVrzeOgKJY6moE8xXa1HJ5DRB GNQtn+21D2G7DaUMlRB9003dqJDQEtx4WFx89GfuYZhKp3/nokHREDJ25kiHAsywUPr5 FBbtSGJ8C1l7nsQEAfy+0qme4+ukv6rjrUdLErJy4nf7uhzD2mhkVylVGLYVTUd8Td2C a/tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to; bh=OgUbXuBzSRofrzBQCx4mAQ2LZNbN5PuQPiNdAazw0Ho=; b=HA/UORHhVhyJO9AgkyklwotlXJfN66yU2hTfPZBMwXS+bzkSZS2DhQQAt14HUDQQBW UTaqiF9e3heTqN5TaWNh0FI4NJdrHCLHHo0EjTe6G/+yYpA/5AXfSPX6xriL6Brlul8b piumMDkmJms0ovhnnFuhJp/3gs/azQ25IAIYbf2JtbUA349pn2zXzaz8dlw9sE5uWxcX tUjs9Icl5DVGB9yt3J5kOPcSMR4c3/6GTBpiHrrQizDyq4dm1KxsuB2XbdpaNN+Kp+zc jaVx0zrTBC30q1H+KimVnN3qPZ2SBrEpiu+UxNlLguGrODbWICOSjMNgFfpCO0TvCexM LPGw== X-Gm-Message-State: AOAM533LaseVEs+DY76kdxW6YZf0eoO1KlbkLylPsavpbdAPf59HOKkd 2xwaP/EbS8QKartZDEw52fQ= X-Google-Smtp-Source: ABdhPJza0U1rYURiE0BCd/YhE0d1DdciEXOiw0jZ9gDdcstOKZKsaeY/CiqAuyLUfzntVD6f/yblcw== X-Received: by 2002:ac8:4f4b:: with SMTP id i11mr24829182qtw.284.1618226588408; Mon, 12 Apr 2021 04:23:08 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id 81sm6651605qkl.121.2021.04.12.04.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Apr 2021 04:23:07 -0700 (PDT) From: SeongJae Park X-Google-Original-From: SeongJae Park To: SeongJae Park Cc: akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v27 07/13] mm/damon: Implement a debugfs-based user space interface Date: Mon, 12 Apr 2021 11:22:56 +0000 Message-Id: <20210412112256.880-1-sjpark@amazon.de> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210408134854.31625-8-sj38.park@gmail.com> X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BAFDDC0001EE X-Stat-Signature: 7wg4yzqaswyzrmrbih9cg955hagtx4ka Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf06; identity=mailfrom; envelope-from=""; helo=mail-qt1-f169.google.com; client-ip=209.85.160.169 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618226590-972449 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park On Thu, 8 Apr 2021 13:48:48 +0000 SeongJae Park wrote: > From: SeongJae Park > > DAMON is designed to be used by kernel space code such as the memory > management subsystems, and therefore it provides only kernel space API. > That said, letting the user space control DAMON could provide some > benefits to them. For example, it will allow user space to analyze > their specific workloads and make their own special optimizations. > > For such cases, this commit implements a simple DAMON application kernel > module, namely 'damon-dbgfs', which merely wraps the DAMON api and > exports those to the user space via the debugfs. > [...] > +/* > + * Functions for the initialization > + */ > + > +static int __init damon_dbgfs_init(void) > +{ > + int rc; > + > + dbgfs_ctxs = kmalloc(sizeof(*dbgfs_ctxs), GFP_KERNEL); > + if (!dbgfs_ctxs) { > + pr_err("%s: dbgfs ctxs alloc failed\n", __func__); > + return -ENOMEM; > + } > + dbgfs_ctxs[0] = dbgfs_new_ctx(); > + if (!dbgfs_ctxs[0]) { > + pr_err("%s: dbgfs ctx alloc failed\n", __func__); > + return -ENOMEM; My colleague, Stefan found 'dbgfs_ctxs' is not freed here. Similar in below '__damon_dbgfs_init()' failure handling. I will fix these in the next version. Reported-by: Stefan Nuernberger Thanks, SeongJae Park > + } > + dbgfs_nr_ctxs = 1; > + > + rc = __damon_dbgfs_init(); > + if (rc) > + pr_err("%s: dbgfs init failed\n", __func__); > + > + return rc; > +} > + > +module_init(damon_dbgfs_init); > -- > 2.17.1 >