From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 142D1C43462 for ; Tue, 13 Apr 2021 20:43:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 842AD61154 for ; Tue, 13 Apr 2021 20:43:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 842AD61154 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0E4266B0070; Tue, 13 Apr 2021 16:43:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 094706B0071; Tue, 13 Apr 2021 16:43:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E50F06B0072; Tue, 13 Apr 2021 16:43:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id C5CE56B0070 for ; Tue, 13 Apr 2021 16:43:09 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7CDDB82499B9 for ; Tue, 13 Apr 2021 20:43:09 +0000 (UTC) X-FDA: 78028518498.40.04C4E86 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 7C8A9C0007DA for ; Tue, 13 Apr 2021 20:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618346588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7+E0a1RmQtz9OdkPBWVwzVjeeLrb1IaJD410lr0Tlc=; b=fD0sYZLA3YodHgRIFQTQBHzMknKBGjWYWq7iX8NtN9lxtrlBjgVjEMyHc2hPkGrMW50EkW 6sEdZLb84o0EalDsAqrp3ldCzkSfIaj1X7Ep8NkC5Pw7sIZ0n74Ohu1p9YOYJ7a8lcgCDK GVm66+oZt3joLX/ygM5FNm7iHCtREXk= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-nXREf82BMbCilsLBUsGTAA-1; Tue, 13 Apr 2021 16:43:07 -0400 X-MC-Unique: nXREf82BMbCilsLBUsGTAA-1 Received: by mail-qv1-f72.google.com with SMTP id dk17so6569281qvb.12 for ; Tue, 13 Apr 2021 13:43:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l7+E0a1RmQtz9OdkPBWVwzVjeeLrb1IaJD410lr0Tlc=; b=SZBvk4g69KLL0jVev0ga/iUTCpSHzEZWXDp6vVyFT8x/dAZfFBse2ZFCSNcornzgmQ R/spsU8W/0834KiBAzdkOnqkuqwrDj3FmyatyMdyGmhMcscbMf2MFBxBvmKogMKCgR/D 69qnOjJVII/PwZm4o4ASKi08Roa1OXtapJzblnK8bEhHD9zZyB7vBQ11N6ubKtMeuXdS 6dYmv7x4/AGTcJWucPuZE7F/7QGAprnr+dOcX9tTvQmBap77TEchaKIbNCvU5hIneufy TkSKVOLnrLz5u/xUfQmkOB/mB1Icr2HUjBrUTPaMqzHVXO0mrJxH8gq5V0Sr5AHeVB87 IHmA== X-Gm-Message-State: AOAM530vQhmBkBWYVHDyRM197pub5NYIBvMLD7+ipoIDHOS+Rgv/Ziie pANmWiDRYtsCTm6ijZhDxBb6XV3T0O9ejrTBJvfxMub4nFEfv7ibkSV6TiC+9HVzaZpZBYBCMmQ RJSF77/TZpG8= X-Received: by 2002:ac8:529a:: with SMTP id s26mr9139698qtn.86.1618346586711; Tue, 13 Apr 2021 13:43:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhhgdT699IOjKyQMCFGRKWPZFD1wjCraEpotriSy8OLfP4IZ7xZ1qfAYCJAbXf3dGDou98CA== X-Received: by 2002:ac8:529a:: with SMTP id s26mr9139679qtn.86.1618346586512; Tue, 13 Apr 2021 13:43:06 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-88-174-93-75-154.dsl.bell.ca. [174.93.75.154]) by smtp.gmail.com with ESMTPSA id i2sm3031068qtg.0.2021.04.13.13.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 13:43:05 -0700 (PDT) Date: Tue, 13 Apr 2021 16:43:04 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrea Arcangeli , Andrew Morton , Hugh Dickins , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v2 3/9] userfaultfd/shmem: support minor fault registration for shmem Message-ID: <20210413204304.GG4440@xz-x1> References: <20210413051721.2896915-1-axelrasmussen@google.com> <20210413051721.2896915-4-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: <20210413051721.2896915-4-axelrasmussen@google.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7C8A9C0007DA X-Stat-Signature: f8ue781pyykhuibmxuegqp4zcgtrr79h Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618346585-271833 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 12, 2021 at 10:17:15PM -0700, Axel Rasmussen wrote: > This patch allows shmem-backed VMAs to be registered for minor faults. > Minor faults are appropriately relayed to userspace in the fault path, > for VMAs with the relevant flag. > > This commit doesn't hook up the UFFDIO_CONTINUE ioctl for shmem-backed > minor faults, though, so userspace doesn't yet have a way to resolve > such faults. > > Signed-off-by: Axel Rasmussen Everything looks right to me, but it'll be great if Andrea or Hugh will have a look too. Acked-by: Peter Xu -- Peter Xu