From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B31D2C433ED for ; Mon, 19 Apr 2021 08:49:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 34FBD6113C for ; Mon, 19 Apr 2021 08:49:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34FBD6113C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B83766B0036; Mon, 19 Apr 2021 04:49:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B33996B006E; Mon, 19 Apr 2021 04:49:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D4926B0070; Mon, 19 Apr 2021 04:49:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0005.hostedemail.com [216.40.44.5]) by kanga.kvack.org (Postfix) with ESMTP id 7E4006B0036 for ; Mon, 19 Apr 2021 04:49:32 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 3A1478249980 for ; Mon, 19 Apr 2021 08:49:32 +0000 (UTC) X-FDA: 78048492984.12.273A0EC Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by imf20.hostedemail.com (Postfix) with ESMTP id 9F399DA for ; Mon, 19 Apr 2021 08:49:24 +0000 (UTC) IronPort-SDR: 2gAP7NuAUMyd1KP8h0HX5PKAkTjg3YDvbNXDLpeTd2Hs9vOY5SyekD46Q3ZlWcOScEGzr4HFH3 dGDkpQO9XE8Q== X-IronPort-AV: E=McAfee;i="6200,9189,9958"; a="195319909" X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="195319909" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2021 01:49:29 -0700 IronPort-SDR: 5pGzEFUPX9/KckEUEI2UzoMvgHjAX82IHL+o76QjBKXS3Ps0vKtR4+dn4vmU8aqimOtr5Ji2gP e7Qs5qdTMzcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,233,1613462400"; d="scan'208";a="454219270" Received: from shbuild999.sh.intel.com (HELO localhost) ([10.239.147.94]) by fmsmga002.fm.intel.com with ESMTP; 19 Apr 2021 01:49:25 -0700 Date: Mon, 19 Apr 2021 16:49:24 +0800 From: Feng Tang To: Michal Hocko , Dave Hansen , Ben Widawsky Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Andrea Arcangeli , David Rientjes , Mel Gorman , Mike Kravetz , Randy Dunlap , Vlastimil Babka , Andi Kleen , Dan Williams , Dave Hansen Subject: Re: [PATCH v4 04/13] mm/mempolicy: allow preferred code to take a nodemask Message-ID: <20210419084924.GA25519@shbuild999.sh.intel.com> References: <1615952410-36895-1-git-send-email-feng.tang@intel.com> <1615952410-36895-5-git-send-email-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Stat-Signature: m9qzuknka1ru74j4ea8mpqks6fag5oyo X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9F399DA Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from=""; helo=mga03.intel.com; client-ip=134.134.136.65 X-HE-DKIM-Result: none/none X-HE-Tag: 1618822164-216497 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 14, 2021 at 02:55:39PM +0200, Michal Hocko wrote: > On Wed 17-03-21 11:40:01, Feng Tang wrote: > > From: Dave Hansen > > > > Create a helper function (mpol_new_preferred_many()) which is usable > > both by the old, single-node MPOL_PREFERRED and the new > > MPOL_PREFERRED_MANY. > > > > Enforce the old single-node MPOL_PREFERRED behavior in the "new" > > version of mpol_new_preferred() which calls mpol_new_preferred_many(). > > > > v3: > > * fix a stack overflow caused by emty nodemask (Feng) > > > > Link: https://lore.kernel.org/r/20200630212517.308045-5-ben.widawsky@intel.com > > Signed-off-by: Dave Hansen > > Signed-off-by: Ben Widawsky > > Signed-off-by: Feng Tang > > --- > > mm/mempolicy.c | 21 +++++++++++++++++++-- > > 1 file changed, 19 insertions(+), 2 deletions(-) > > > > diff --git a/mm/mempolicy.c b/mm/mempolicy.c > > index 1228d8e..6fb2cab 100644 > > --- a/mm/mempolicy.c > > +++ b/mm/mempolicy.c > > @@ -203,17 +203,34 @@ static int mpol_new_interleave(struct mempolicy *pol, const nodemask_t *nodes) > > return 0; > > } > > > > -static int mpol_new_preferred(struct mempolicy *pol, const nodemask_t *nodes) > > +static int mpol_new_preferred_many(struct mempolicy *pol, > > + const nodemask_t *nodes) > > { > > if (!nodes) > > pol->flags |= MPOL_F_LOCAL; /* local allocation */ > > Now you have confused me. I thought that MPOL_PREFERRED_MANY for NULL > nodemask will be disallowed as it is effectively MPOL_PREFERRED aka > MPOL_F_LOCAL. Or do I misread the code? I think you are right, with current code, the 'nodes' can't be NULL for MPOL_PREFERRED_MANY, we'll revisit this. And I have to admit that I am confused by the current logic for MPOL_PREFERRED, that the nodemask paramter changes between raw user input, empty nodes and NULL. Maybe the following patch can make it more clear, as it doesn't play the NULL nmask trick? --- diff --git a/mm/mempolicy.c b/mm/mempolicy.c index be160d4..9cabfca 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -200,12 +200,9 @@ static int mpol_new_interleave(struct mempolicy *pol, const nodemask_t *nodes) static int mpol_new_preferred(struct mempolicy *pol, const nodemask_t *nodes) { - if (!nodes) - pol->flags |= MPOL_F_LOCAL; /* local allocation */ - else if (nodes_empty(*nodes)) + if (nodes_empty(*nodes)) return -EINVAL; /* no allowed nodes */ - else - pol->v.preferred_node = first_node(*nodes); + pol->v.preferred_node = first_node(*nodes); return 0; } @@ -239,9 +236,11 @@ static int mpol_set_nodemask(struct mempolicy *pol, cpuset_current_mems_allowed, node_states[N_MEMORY]); VM_BUG_ON(!nodes); - if (pol->mode == MPOL_PREFERRED && nodes_empty(*nodes)) - nodes = NULL; /* explicit local allocation */ - else { + if (pol->mode == MPOL_PREFERRED && nodes_empty(*nodes)) { + /* explicit local allocation */ + pol->flags |= MPOL_F_LOCAL; + return 0; + } else { if (pol->flags & MPOL_F_RELATIVE_NODES) mpol_relative_nodemask(&nsc->mask2, nodes, &nsc->mask1); else @@ -254,10 +253,7 @@ static int mpol_set_nodemask(struct mempolicy *pol, cpuset_current_mems_allowed; } - if (nodes) - ret = mpol_ops[pol->mode].create(pol, &nsc->mask2); - else - ret = mpol_ops[pol->mode].create(pol, NULL); + ret = mpol_ops[pol->mode].create(pol, &nsc->mask2); return ret; } Thanks, Feng