From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3C49C433B4 for ; Wed, 21 Apr 2021 08:49:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6575F6144E for ; Wed, 21 Apr 2021 08:49:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6575F6144E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C973F6B006C; Wed, 21 Apr 2021 04:49:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C485D6B006E; Wed, 21 Apr 2021 04:49:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0F0A6B0070; Wed, 21 Apr 2021 04:49:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 932AA6B006C for ; Wed, 21 Apr 2021 04:49:15 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 5159C18044726 for ; Wed, 21 Apr 2021 08:49:15 +0000 (UTC) X-FDA: 78055749870.31.097BD7A Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP id 06CEDA000390 for ; Wed, 21 Apr 2021 08:49:12 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id D9E81B176; Wed, 21 Apr 2021 08:49:13 +0000 (UTC) Date: Wed, 21 Apr 2021 10:49:11 +0200 From: Oscar Salvador To: Muchun Song Cc: Michal Hocko , Mike Kravetz , Andrew Morton , Linux Memory Management List , LKML , Naoya Horiguchi Subject: Re: [External] Re: [PATCH] mm: hugetlb: fix a race between memory-failure/soft_offline and gather_surplus_pages Message-ID: <20210421084911.GH22456@linux> References: <20210421060259.67554-1-songmuchun@bytedance.com> <20210421082103.GE22456@linux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 06CEDA000390 X-Stat-Signature: ngpiotxfskf1bafkw7sg1jy56k8hzs6o X-Rspamd-Server: rspam02 Received-SPF: none (suse.de>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mx2.suse.de; client-ip=195.135.220.15 X-HE-DKIM-Result: none/none X-HE-Tag: 1618994952-138062 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Apr 21, 2021 at 04:41:10PM +0800, Muchun Song wrote: > But softoffline does not set page hwpoison before > __get_hwpoison_page(). So the page still can be > allocated. Right? Yep, soft_offline() only marks the page as hwpoison once the page has been fully contended and no other use is possible. But yeah, hugetlb is a bit trickier in that regard. This needs fixing in there. -- Oscar Salvador SUSE L3