From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB650C433B4 for ; Sun, 25 Apr 2021 00:39:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39AAC61466 for ; Sun, 25 Apr 2021 00:39:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39AAC61466 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5759D6B0036; Sat, 24 Apr 2021 20:39:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54AD88D0001; Sat, 24 Apr 2021 20:39:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4132F6B006E; Sat, 24 Apr 2021 20:39:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0086.hostedemail.com [216.40.44.86]) by kanga.kvack.org (Postfix) with ESMTP id 2295B6B0036 for ; Sat, 24 Apr 2021 20:39:10 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id C58A35DF4 for ; Sun, 25 Apr 2021 00:39:09 +0000 (UTC) X-FDA: 78069030018.25.4C80199 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by imf04.hostedemail.com (Postfix) with ESMTP id B9BDA3C2 for ; Sun, 25 Apr 2021 00:39:05 +0000 (UTC) IronPort-SDR: MThG5Y8fRa9ctugAT6sF53/b+nnb3pSyXBu968eFwZ/xRHLHQrT3S0HSLrKYPJFo6V3qc5vJUk iZtIwI48tkDA== X-IronPort-AV: E=McAfee;i="6200,9189,9964"; a="183687282" X-IronPort-AV: E=Sophos;i="5.82,249,1613462400"; d="scan'208";a="183687282" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2021 17:39:05 -0700 IronPort-SDR: /HLTSyqcCtlfvHUFj3U7R4dejlUUolV2MFsbJsGIJRfXxhBwKpNZCeRz9tzola9ulGY624IieT Blo7cZgL6B6Q== X-IronPort-AV: E=Sophos;i="5.82,249,1613462400"; d="scan'208";a="422180239" Received: from xsang-optiplex-9020.sh.intel.com (HELO xsang-OptiPlex-9020) ([10.239.159.140]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2021 17:39:00 -0700 Date: Sun, 25 Apr 2021 08:56:17 +0800 From: Oliver Sang To: Lyude Paul Cc: "Sarvela, Tomi P" , Jani Nikula , Vasily Khoruzhick , LKML , Linux Memory Management List , lkp@lists.01.org, lkp@intel.com, rui.zhang@intel.com, yu.c.chen@intel.com Subject: Re: [drm/i915/dp] 4a8d79901d: WARNING:at_drivers/gpu/drm/i915/display/intel_display_power.c:#assert_can_disable_lcpll[i915] Message-ID: <20210425005610.GA5251@xsang-OptiPlex-9020> References: <20210204090229.GH17757@xsang-OptiPlex-9020> <20210318021320.GA10304@xsang-OptiPlex-9020> <90e58cf788299c76b80ec72735ebfd33eef7fffd.camel@redhat.com> <20210325135342.GA17080@xsang-OptiPlex-9020> <3f97d13aab87ca8023f6607b419e3c0f3249871a.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3f97d13aab87ca8023f6607b419e3c0f3249871a.camel@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B9BDA3C2 X-Stat-Signature: cnagug8ropcgk543tn78kma7rfy7medi Received-SPF: none (intel.com>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=mga18.intel.com; client-ip=134.134.136.126 X-HE-DKIM-Result: none/none X-HE-Tag: 1619311145-544158 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: hi, Lyude Paul, On Fri, Apr 09, 2021 at 04:30:55PM -0400, Lyude Paul wrote: > Could you retest this against the latest drm-tip? I pushed something th= at I > think might fix this sorry for late. we tested on the tip for drm-tip several days ago, confirmed the issue wa= s gone. the test commit is: commit 0d733c1e940857595e3f647dd59bf98c126806c4 Author: Ville Syrjl AuthorDate: Wed Apr 21 02:02:02 2021 +0300 Commit: Ville Syrjl CommitDate: Wed Apr 21 02:02:02 2021 +0300 drm-tip: 2021y-04m-20d-23h-01m-26s UTC integration manifest on repo: git://anongit.freedesktop.org/drm/drm-tip branch: drm-tip >=20 > On Thu, 2021-03-25 at 21:53 +0800, Oliver Sang wrote: > > Hi, Lyude, > >=20 > > On Tue, Mar 23, 2021 at 01:27:29PM -0400, Lyude Paul wrote: > > > BTW Oliver - I'm still happy to look at this issue, I just need the= extra > > > logs I > > > mentioned below in order to figure out what's going on here > >=20 > > I enabled "drm.debug=3D0x16 log_buf_len=3D5M" and got attached kmsg.x= z for > > 4a8d79901d. > > hope it's useful. > >=20 > > >=20 > > > On Thu, 2021-03-18 at 13:16 -0400, Lyude Paul wrote: > > > > Well this is surprising, because I had been pretty sure we had as= ked > > > > someone > > > > at > > > > Intel to test that this patch worked on samus and they had said t= hat it > > > > did.=20 > > > >=20 > > > > Is there any way you can get me the kernel messages from this fai= lure with > > > > drm.debug=3D0x16 log_buf_len=3D5M added to the kernel commandline= ? It's hard > > > > to > > > > see > > > > what's actually going on here that's causing this issue to still = reoccur. > > > >=20 > > > > Also adding Tomi P Sarvela onto this thread, since they were the = ones who > > > > originally tested this > > > >=20 > > > > On Thu, 2021-03-18 at 10:13 +0800, Oliver Sang wrote: > > > > > Hi Lyude, sorry for later. > > > > >=20 > > > > > before we send out the report, we also tested fe7d52bccab6, the= issue > > > > > still > > > > > exists on it. > > > > > attached one kmsg-fe7d52bccab6.xz FYI. > > > > >=20 > > > > > we also tested on latest v5.12-rc3, also exists. > > > > > attached kmsg-v5.12-rc3.xz FYI. > > > > >=20 > > > > >=20 > > > > >=20 > > > > > On Fri, Feb 05, 2021 at 02:53:11PM -0500, Lyude Paul wrote: > > > > > > Am I right in assuming this is likely a very delayed test res= ult from > > > > > > before: > > > > > >=20 > > > > > > fe7d52bccab6 ("drm/i915/dp: Don't use DPCD backlights that ne= ed PWM > > > > > > enable/disable") > > > > > >=20 > > > > > > Made it into the kernel? I see that there's a PWM being left = on, which > > > > > > was > > > > > > the > > > > > > same issue we were seeing on fi-bdw-samus > > > > > >=20 > > > > > > On Thu, 2021-02-04 at 17:02 +0800, kernel test robot wrote: > > > > > > >=20 > > > > > > > Greeting, > > > > > > >=20 > > > > > > > FYI, we noticed the following commit (built with gcc-9): > > > > > > >=20 > > > > > > > commit: 4a8d79901d5bed0812d272c372aa40282937b50f ("drm/i915= /dp: > > > > > > > Enable > > > > > > > Intel's > > > > > > > HDR backlight interface (only SDR for now)") > > > > > > > https://git.kernel.org/cgit/linux/kernel/git/next/linux-nex= t.git=A0mas > > > > > > > ter > > > > > > >=20 > > > > > > >=20 > > > > > > > in testcase: suspend-stress > > > > > > > version:=20 > > > > > > > with following parameters: > > > > > > >=20 > > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0mode: freeze > > > > > > > =A0=A0=A0=A0=A0=A0=A0=A0iterations: 10 > > > > > > >=20 > > > > > > >=20 > > > > > > >=20 > > > > > > > on test machine: 4 threads Broadwell-Y with 8G memory > > > > > > >=20 > > > > > > > caused below changes (please refer to attached dmesg/kmsg f= or entire > > > > > > > log/backtrace): > > > > > > >=20 > > > > > > >=20 > > > > > > >=20 > > > > > > > If you fix the issue, kindly add following tag > > > > > > > Reported-by: kernel test robot > > > > > > >=20 > > > > > > >=20 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.137894] ------------[ cut her= e ]------------ > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.137897] CPU PWM1 enabled > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.137930] WARNING: CPU: 3 PID: = 575 at > > > > > > > drivers/gpu/drm/i915/display/intel_display_power.c:4902 > > > > > > > assert_can_disable_lcpll+0x335/0x3c0 [i915] > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138084] Modules linked in: sd= _mod t10_pi sg > > > > > > > x86_pkg_temp_thermal intel_powerclamp i915 hid_rmi rmi_core > > > > > > > hid_multitouch > > > > > > > coretemp intel_ra > > > > > > > pl_msr crct10dif_pclmul wmi_bmof crc32_pclmul intel_gtt crc= 32c_intel > > > > > > > ghash_clmulni_intel rapl drm_kms_helper intel_cstate ahci l= ibahci > > > > > > > serio_raw > > > > > > > mei_me proces > > > > > > > sor_thermal_device intel_uncore processor_thermal_rfim sysc= opyarea > > > > > > > sysfillrect > > > > > > > intel_soc_dts_iosf sysimgblt intel_pch_thermal hid_sensor_c= ustom > > > > > > > fb_sys_fops > > > > > > > li > > > > > > > bata bcma processor_thermal_mbox joydev mei drm > > > > > > > processor_thermal_rapl > > > > > > > intel_rapl_common int340x_thermal_zone i2c_hid ideapad_lapt= op > > > > > > > sparse_keymap > > > > > > > wmi rfkill > > > > > > > video int3400_thermal acpi_thermal_rel i2c_designware_platf= orm > > > > > > > dw_dmac > > > > > > > i2c_designware_core acpi_pad ip_tables > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138148] CPU: 3 PID: 575 Comm:= kworker/u8:6 > > > > > > > Tainted: > > > > > > > G=A0=A0=A0=A0=A0=A0=A0 W I=A0=A0=A0=A0=A0=A0 5.11.0-rc2-007= 45-g4a8d79901d5b #1 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138153] Hardware name: LENOVO= 80HE/VIUU4, BIOS > > > > > > > A6CN38WW > > > > > > > 09/30/2014 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138155] Workqueue: events_unb= ound > > > > > > > async_run_entry_fn > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138161] RIP: > > > > > > > 0010:assert_can_disable_lcpll+0x335/0x3c0 > > > > > > > [i915] > > > > > > > kern=A0 :info=A0 : [=A0=A0 21.138263] ahci 0000:00:1f.2: > > > > > > > pci_pm_suspend_late+0x0/0x40 > > > > > > > returned 0 after 0 usecs > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138296] Code: c0 75 22 e8 8d = 61 cb ff e9 f3 fd > > > > > > > ff > > > > > > > ff > > > > > > > e8 > > > > > > > fd bc 6a c1 0f 0b e9 0c fd ff ff e8 f1 bc 6a c1 0f 0b e9 05= fe ff ff > > > > > > > e8 > > > > > > > e5 > > > > > > > bc > > > > > > > 6a c1 <0f> 0b e9 cf fd ff ff e8 d9 bc 6a c1 0f 0b e9 a2 fd = ff ff e8 > > > > > > > cd > > > > > > > bc > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138300] RSP: 0018:ffffc900006= f3d58 EFLAGS: > > > > > > > 00010282 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138304] RAX: 0000000000000000= RBX: > > > > > > > ffff8881451002e8 > > > > > > > RCX: > > > > > > > 0000000000000027 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138307] RDX: 0000000000000027= RSI: > > > > > > > 0000000000000002 > > > > > > > RDI: > > > > > > > ffff888249397cf8 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138310] RBP: ffff888145100000= R08: > > > > > > > ffff888249397cf0 > > > > > > > R09: > > > > > > > ffffc900006f3cf0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138313] R10: 0000000000000001= R11: > > > > > > > 3030302035313969 > > > > > > > R12: > > > > > > > ffff8881451007f0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138316] R13: ffff888145106c60= R14: > > > > > > > 0000000000000002 > > > > > > > R15: > > > > > > > 0000000000000000 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138319] FS:=A0 00000000000000= 00(0000) > > > > > > > GS:ffff888249380000(0000) knlGS:0000000000000000 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138322] CS:=A0 0010 DS: 0000 = ES: 0000 CR0: > > > > > > > 0000000080050033 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138325] CR2: 0000557c22ec68a0= CR3: > > > > > > > 0000000004c0a003 > > > > > > > CR4: > > > > > > > 00000000003706e0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138329] Call Trace: > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138334]=A0 hsw_disable_lcpll+= 0x22/0x280 [i915] > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138479]=A0 i915_drm_suspend_l= ate+0x5e/0x100 > > > > > > > [i915] > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138578]=A0 ? pci_pm_poweroff_= late+0x40/0x40 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138582]=A0 dpm_run_callback+0= x4c/0x140 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138590]=A0 __device_suspend_l= ate+0x98/0x1a0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138596]=A0 async_suspend_late= +0x1b/0xa0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138602]=A0 async_run_entry_fn= +0x39/0x160 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138608]=A0 process_one_work+0= x1ed/0x3c0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138612]=A0 worker_thread+0x50= /0x3c0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138617]=A0 ? process_one_work= +0x3c0/0x3c0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138620]=A0 kthread+0x116/0x16= 0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138626]=A0 ? kthread_park+0xa= 0/0xa0 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138631]=A0 ret_from_fork+0x22= /0x30 > > > > > > > kern=A0 :warn=A0 : [=A0=A0 21.138640] ---[ end trace a93fe4= d40a5a37bb ]--- > > > > > > >=20 > > > > > > >=20 > > > > > > >=20 > > > > > > > To reproduce: > > > > > > >=20 > > > > > > > =A0=A0=A0=A0=A0=A0=A0 git clone https://github.com/intel/lk= p-tests.git > > > > > > > =A0=A0=A0=A0=A0=A0=A0 cd lkp-tests > > > > > > > =A0=A0=A0=A0=A0=A0=A0 bin/lkp install job.yaml=A0 # job fil= e is attached in this > > > > > > > email > > > > > > > =A0=A0=A0=A0=A0=A0=A0 bin/lkp run=A0=A0=A0=A0 job.yaml > > > > > > >=20 > > > > > > >=20 > > > > > > >=20 > > > > > > > Thanks, > > > > > > > Oliver Sang > > > > > > >=20 > > > > > >=20 > > > > > > --=20 > > > > > > Sincerely, > > > > > > =A0=A0 Lyude Paul (she/her) > > > > > > =A0=A0 Software Engineer at Red Hat > > > > > > =A0=A0=20 > > > > > > Note: I deal with a lot of emails and have a lot of bugs on m= y plate. > > > > > > If > > > > > > you've > > > > > > asked me a question, are waiting for a review/merge on a patc= h, etc. > > > > > > and I > > > > > > haven't responded in a while, please feel free to send me ano= ther > > > > > > email to > > > > > > check > > > > > > on my status. I don't bite! > > > > > >=20 > > > >=20 > > >=20 > > > --=20 > > > Sincerely, > > > =A0=A0 Lyude Paul (she/her) > > > =A0=A0 Software Engineer at Red Hat > > > =A0=A0=20 > > > Note: I deal with a lot of emails and have a lot of bugs on my plat= e. If > > > you've > > > asked me a question, are waiting for a review/merge on a patch, etc= . and I > > > haven't responded in a while, please feel free to send me another e= mail to > > > check > > > on my status. I don't bite! > > >=20 >=20 > --=20 > Sincerely, > Lyude Paul (she/her) > Software Engineer at Red Hat > =20 > Note: I deal with a lot of emails and have a lot of bugs on my plate. I= f you've > asked me a question, are waiting for a review/merge on a patch, etc. an= d I > haven't responded in a while, please feel free to send me another email= to check > on my status. I don't bite! >=20