From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D82E9C433ED for ; Tue, 27 Apr 2021 15:57:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 39448613CA for ; Tue, 27 Apr 2021 15:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39448613CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 871686B006C; Tue, 27 Apr 2021 11:57:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8477B6B006E; Tue, 27 Apr 2021 11:57:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C24B6B0070; Tue, 27 Apr 2021 11:57:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0087.hostedemail.com [216.40.44.87]) by kanga.kvack.org (Postfix) with ESMTP id 468746B006C for ; Tue, 27 Apr 2021 11:57:23 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0AAF9824999B for ; Tue, 27 Apr 2021 15:57:23 +0000 (UTC) X-FDA: 78078601566.08.7F9605A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 7BDE9C0007C9 for ; Tue, 27 Apr 2021 15:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619539038; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UeRAYJi3jVz2RcJA5cfm9/ZZeziOqivA1BEyk0ctB+8=; b=cPw5KuU5YKX57TvUkrq0W/Bm1Zp2yUw19CrCFDBBWUqu0InCoXXYyHPmCB7U4z3hTqjVb/ jJIDvQMPlki2zShs2iuAJm81/wRHJBrZev6SBDZYVo879CqQPJXgrsugNhkOXGp6U/KjKc QYmQkK4MA7xKhhZl65RZhyDexxCjqV0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619539042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UeRAYJi3jVz2RcJA5cfm9/ZZeziOqivA1BEyk0ctB+8=; b=QZMQ1WVRUU4txOIHT54UDbZsFKJeEur1dRdfFM2McTeZ9bRWzhY5x8hulwvfzUjPhRhBw1 odaG1DIRXGohcDkAJId77KNOG3AAJ5DYMWSCHZyDrAXiOzDjsOjsxWn5ForW7jl7iPG+rG w/VygeT883Sos4RY9SecMr3yv0wu4bs= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-280-fq1J045wPIewAQC-e91oRw-1; Tue, 27 Apr 2021 11:57:16 -0400 X-MC-Unique: fq1J045wPIewAQC-e91oRw-1 Received: by mail-qk1-f200.google.com with SMTP id k12-20020a05620a0b8cb02902e028cc62baso23222377qkh.17 for ; Tue, 27 Apr 2021 08:57:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UeRAYJi3jVz2RcJA5cfm9/ZZeziOqivA1BEyk0ctB+8=; b=Fs3Tq71SD+kdc+gbrE+UzrT8t23+QMLYr0E1oBD41rHD3qUmYJeXYbxN1mwTxO5SeL H2d2G3+a4JBpo70v+x3OjCAMSk0Rz9xC9ZAfIvGQIg4mIEXB1/MrT/qC+2f+Y5cXUqYs rf0BXswJnjrvolOLNww5PLPC4Uc7rhWpeTc/gJWh89qXkcdiAMJsaDiG0yxiVJVpQ3zS dDrjo6myjnLjPzqjcc2H7Vj3QQ69oK2qZslSM5ENj8Q8xc9bap/uOZ74ww+2sSrdL92V XIse8t6G1RBdrkPswMFH5DEdpvroSJIR7c/zDXaOP9Fe/+F98HcZsKvE4g7yjLLxZxD/ 5L9g== X-Gm-Message-State: AOAM530fvHErjLUWLKbrx8m9UFhTFmsLidrwBDrw93ZGftrSJjuqCTlb q52Aq6DtL6opa489VOHOfhnS1QrB9Ep4DBFLc7XlTpMjkLqMnjLm7qgqgJSMS9eDrPWUoEIw+Ke vHKtia4ineBo= X-Received: by 2002:a37:9305:: with SMTP id v5mr23224452qkd.223.1619539036071; Tue, 27 Apr 2021 08:57:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwt9C9yyPCKjs/11oWJ2ljp8cgvSKc3nf/K+fOGkHMK5svdKo+b6nP8QjYAWsUrtuDALqrP7A== X-Received: by 2002:a37:9305:: with SMTP id v5mr23224422qkd.223.1619539035849; Tue, 27 Apr 2021 08:57:15 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-77-184-145-104-227.dsl.bell.ca. [184.145.104.227]) by smtp.gmail.com with ESMTPSA id h62sm2925543qkf.116.2021.04.27.08.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 08:57:15 -0700 (PDT) Date: Tue, 27 Apr 2021 11:57:13 -0400 From: Peter Xu To: Hugh Dickins Cc: Axel Rasmussen , Alexander Viro , Andrea Arcangeli , Andrew Morton , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v4 04/10] userfaultfd/shmem: support minor fault registration for shmem Message-ID: <20210427155713.GC6820@xz-x1> References: <20210420220804.486803-1-axelrasmussen@google.com> <20210420220804.486803-5-axelrasmussen@google.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 7BDE9C0007C9 X-Stat-Signature: 4fot84fphiuazkmapr5en98fba5bodx3 Received-SPF: none (redhat.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=us-smtp-delivery-124.mimecast.com; client-ip=170.10.133.124 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619539027-705950 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Apr 26, 2021 at 07:23:57PM -0700, Hugh Dickins wrote: > On Tue, 20 Apr 2021, Axel Rasmussen wrote: > > > This patch allows shmem-backed VMAs to be registered for minor faults. > > Minor faults are appropriately relayed to userspace in the fault path, > > for VMAs with the relevant flag. > > > > This commit doesn't hook up the UFFDIO_CONTINUE ioctl for shmem-backed > > minor faults, though, so userspace doesn't yet have a way to resolve > > such faults. > > > > Acked-by: Peter Xu > > Signed-off-by: Axel Rasmussen > > And if this "04/10" had been numbered 03/10, I would have said > Acked-by: Hugh Dickins > > Just read the comment above: "so userspace doesn't yet have a way to > resolve such faults" - if it doesn't by this stage, we're in trouble. Right, so merging the two patches might be easier. Even if we don't merge them, we'll need to touch up the commit message since at least above paragraph is not true anymore as we've already have UFFDIO_CONTINUE. Thanks, -- Peter Xu