From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3384C43460 for ; Wed, 28 Apr 2021 09:54:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7890361426 for ; Wed, 28 Apr 2021 09:54:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7890361426 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 00FC76B006E; Wed, 28 Apr 2021 05:54:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F01316B0070; Wed, 28 Apr 2021 05:54:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79FB6B0071; Wed, 28 Apr 2021 05:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id BB5156B006E for ; Wed, 28 Apr 2021 05:54:06 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 66F9F180AD817 for ; Wed, 28 Apr 2021 09:54:06 +0000 (UTC) X-FDA: 78081314892.36.DE25A94 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf16.hostedemail.com (Postfix) with ESMTP id B635280192F8 for ; Wed, 28 Apr 2021 09:54:01 +0000 (UTC) Received: by mail-pl1-f174.google.com with SMTP id h20so32520922plr.4 for ; Wed, 28 Apr 2021 02:54:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9oUrOqpAChDXaXDoRREdcI5L9MHP6oIlBRQpnJzUeII=; b=KjmVrYt4/mY4WAr2kGNuBttDXe558+QJuBQ0FarvEbVpYaJKm1byHI0esEdym/Sbms ro0NbPCCKfv5HOUetWMK0UzUV/wBvWj1pdq6vDvbMZJSDoWUsAEaM5qnn0Zn94mGyu76 CIdM0kJHKdvY2YznYTJNRCQjsDJ89lLa/6V9en+m4TrMBSXszIAsfpheCjK7mXscPLii f4WMz1stInaW9MZwHqi5sRS8/FdZ3f75T59LuLxAzP9za4ip+85ii2835JA9zLFnKkwg /7LBEqHUDEYbsKjDOXcN00GLzP6ZQcqmZwgmfvE5wno6F5pVKaC2ocCOaWtiQmLDvMik WWRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9oUrOqpAChDXaXDoRREdcI5L9MHP6oIlBRQpnJzUeII=; b=ByQYj+l/4y9GoBd5bZICDEmagTIUZdHmWDNQPDClZHq7Z4w3z3e+Uidbnq7mzVT5+h j/hXpKUSTlY9IjzJCw7VvMWSUYwLjFAiNyRoS4faCT14N8p5wx7/JT8M7SBWxE88rpot FI7cZHDTnAqioaW8wZEcy0dY7EnVVKKJzIMZ2Ul8RvGxSYbLqGyzMbHiE49m82ai3uPs 95rAvI/GNoHYwmm35GaMjYDV+epbMAd3lbXfj0mc9Z7S5kPY998US7JHXu8U/VCuVGCi 9hvDIhaJEyPRdIGg+M9roEr3mgwwase7cXJkoil137rx2WxUn7zt7h+sR0EDYH+rnvkm JTCg== X-Gm-Message-State: AOAM531kni/plYuMAnunYoSiX48Nf3fadRXHFUqttDtwMg8uZOedItRh 5JRstM1xyYy9uDNIKPDsZ4doQg== X-Google-Smtp-Source: ABdhPJxBl/GM8wieywRB0WXvNHzOvK1MwlC3y0XOZRlQNnVIeOPVORj003QMYJqVZivfXIWTUHMcqg== X-Received: by 2002:a17:902:7d89:b029:ec:c084:d4bc with SMTP id a9-20020a1709027d89b02900ecc084d4bcmr29571045plm.18.1619603645050; Wed, 28 Apr 2021 02:54:05 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.233]) by smtp.gmail.com with ESMTPSA id x77sm4902365pfc.19.2021.04.28.02.54.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Apr 2021 02:54:04 -0700 (PDT) From: Muchun Song To: willy@infradead.org, akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, shakeelb@google.com, guro@fb.com, shy828301@gmail.com, alexs@kernel.org, alexander.h.duyck@linux.intel.com, richard.weiyang@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Muchun Song Subject: [PATCH 1/9] mm: list_lru: fix list_lru_count_one() return value Date: Wed, 28 Apr 2021 17:49:41 +0800 Message-Id: <20210428094949.43579-2-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) In-Reply-To: <20210428094949.43579-1-songmuchun@bytedance.com> References: <20210428094949.43579-1-songmuchun@bytedance.com> MIME-Version: 1.0 X-Stat-Signature: h9hoi5yw38h4bcj4noont99budhqkb9u X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B635280192F8 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-pl1-f174.google.com; client-ip=209.85.214.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1619603641-797789 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit 2788cf0c401c ("memcg: reparent list_lrus and free kmemcg_id on css offline"), the ->nr_items can be negative during memory cgroup reparenting. In this case, list_lru_count_one() can returns an unusually large value. In order to not surprise the user. So return zero when ->nr_items is negative. Signed-off-by: Muchun Song --- mm/list_lru.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mm/list_lru.c b/mm/list_lru.c index cd58790d0fb3..4962d48d4410 100644 --- a/mm/list_lru.c +++ b/mm/list_lru.c @@ -176,13 +176,16 @@ unsigned long list_lru_count_one(struct list_lru *l= ru, { struct list_lru_node *nlru =3D &lru->node[nid]; struct list_lru_one *l; - unsigned long count; + long count; =20 rcu_read_lock(); l =3D list_lru_from_memcg_idx(nlru, memcg_cache_id(memcg)); count =3D READ_ONCE(l->nr_items); rcu_read_unlock(); =20 + if (unlikely(count < 0)) + count =3D 0; + return count; } EXPORT_SYMBOL_GPL(list_lru_count_one); --=20 2.11.0