Re: [PATCH v9 46/96] mm: Add flush_dcache_folio

From: kernel test robot <lkp@intel.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Cc: kbuild-all@lists.01.org,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 46/96] mm: Add flush_dcache_folio
Date: Thu, 6 May 2021 07:35:16 +0800	[thread overview]
Message-ID: <202105060752.es5znqMC-lkp@intel.com> (raw)
In-Reply-To: <20210505150628.111735-47-willy@infradead.org>

[-- Attachment #1: Type: text/plain, Size: 9633 bytes --]

Hi "Matthew,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210505]
[cannot apply to hnaz-linux-mm/master xfs-linux/for-next tip/perf/core shaggy/jfs-next block/for-next linus/master asm-generic/master v5.12 v5.12-rc8 v5.12-rc7 v5.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Memory-folios/20210506-014108
base:    29955e0289b3255c5f609a7564a0f0bb4ae35c7a
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2104ef87cf0390e2def04a508c79a664b4a4fcc4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Memory-folios/20210506-014108
        git checkout 2104ef87cf0390e2def04a508c79a664b4a4fcc4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/cacheflush.h:31,
                    from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
   include/asm-generic/cacheflush.h: In function 'flush_dcache_folio':
>> include/asm-generic/cacheflush.h:61:19: error: implicit declaration of function 'folio_nr_pages'; did you mean 'folio_page'? [-Werror=implicit-function-declaration]
      61 |  unsigned int n = folio_nr_pages(folio);
         |                   ^~~~~~~~~~~~~~
         |                   folio_page
   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
>> include/asm-generic/cacheflush.h:65:21: error: implicit declaration of function 'nth_page' [-Werror=implicit-function-declaration]
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |                     ^~~~~~~~
   arch/ia64/include/asm/cacheflush.h:18:25: note: in definition of macro 'flush_dcache_page'
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                         ^~~~
>> arch/ia64/include/asm/cacheflush.h:18:30: error: invalid type argument of '->' (have 'int')
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                              ^~
   include/asm-generic/cacheflush.h:65:3: note: in expansion of macro 'flush_dcache_page'
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |   ^~~~~~~~~~~~~~~~~
   arch/ia64/kernel/asm-offsets.c: At top level:
   arch/ia64/kernel/asm-offsets.c:23:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
      23 | void foo(void)
         |      ^~~
   cc1: some warnings being treated as errors
--
   In file included from arch/ia64/include/asm/cacheflush.h:31,
                    from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
   include/asm-generic/cacheflush.h: In function 'flush_dcache_folio':
>> include/asm-generic/cacheflush.h:61:19: error: implicit declaration of function 'folio_nr_pages'; did you mean 'folio_page'? [-Werror=implicit-function-declaration]
      61 |  unsigned int n = folio_nr_pages(folio);
         |                   ^~~~~~~~~~~~~~
         |                   folio_page
   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
>> include/asm-generic/cacheflush.h:65:21: error: implicit declaration of function 'nth_page' [-Werror=implicit-function-declaration]
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |                     ^~~~~~~~
   arch/ia64/include/asm/cacheflush.h:18:25: note: in definition of macro 'flush_dcache_page'
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                         ^~~~
>> arch/ia64/include/asm/cacheflush.h:18:30: error: invalid type argument of '->' (have 'int')
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                              ^~
   include/asm-generic/cacheflush.h:65:3: note: in expansion of macro 'flush_dcache_page'
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |   ^~~~~~~~~~~~~~~~~
   arch/ia64/kernel/asm-offsets.c: At top level:
   arch/ia64/kernel/asm-offsets.c:23:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
      23 | void foo(void)
         |      ^~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:118: arch/ia64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1313: prepare0] Error 2
   make[1]: Target 'modules_prepare' not remade because of errors.
   make: *** [Makefile:222: __sub-make] Error 2
   make: Target 'modules_prepare' not remade because of errors.
--
   error: no override and no default toolchain set
   init/Kconfig:70:warning: 'RUSTC_VERSION': number is invalid
   In file included from arch/ia64/include/asm/cacheflush.h:31,
                    from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
   include/asm-generic/cacheflush.h: In function 'flush_dcache_folio':
>> include/asm-generic/cacheflush.h:61:19: error: implicit declaration of function 'folio_nr_pages'; did you mean 'folio_page'? [-Werror=implicit-function-declaration]
      61 |  unsigned int n = folio_nr_pages(folio);
         |                   ^~~~~~~~~~~~~~
         |                   folio_page
   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from include/linux/sched/task.h:11,
                    from include/linux/sched/signal.h:9,
                    from arch/ia64/kernel/asm-offsets.c:10:
>> include/asm-generic/cacheflush.h:65:21: error: implicit declaration of function 'nth_page' [-Werror=implicit-function-declaration]
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |                     ^~~~~~~~
   arch/ia64/include/asm/cacheflush.h:18:25: note: in definition of macro 'flush_dcache_page'
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                         ^~~~
>> arch/ia64/include/asm/cacheflush.h:18:30: error: invalid type argument of '->' (have 'int')
      18 |  clear_bit(PG_arch_1, &(page)->flags); \
         |                              ^~
   include/asm-generic/cacheflush.h:65:3: note: in expansion of macro 'flush_dcache_page'
      65 |   flush_dcache_page(nth_page(&folio->page, n));
         |   ^~~~~~~~~~~~~~~~~
   arch/ia64/kernel/asm-offsets.c: At top level:
   arch/ia64/kernel/asm-offsets.c:23:6: warning: no previous prototype for 'foo' [-Wmissing-prototypes]
      23 | void foo(void)
         |      ^~~
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:118: arch/ia64/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1313: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:222: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.

vim +61 include/asm-generic/cacheflush.h

    57	
    58	#ifndef ARCH_IMPLEMENTS_FLUSH_DCACHE_FOLIO
    59	static inline void flush_dcache_folio(struct folio *folio)
    60	{
  > 61		unsigned int n = folio_nr_pages(folio);
    62	
    63		do {
    64			n--;
  > 65			flush_dcache_page(nth_page(&folio->page, n));
    66		} while (n);
    67	}
    68	#endif
    69	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64551 bytes --]