From: Aili Yao <yaoaili@kingsoft.com>
To: Naoya Horiguchi <nao.horiguchi@gmail.com>
Cc: <linux-mm@kvack.org>, Tony Luck <tony.luck@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oscar Salvador <osalvador@suse.de>,
"David Hildenbrand" <david@redhat.com>,
Borislav Petkov <bp@alien8.de>,
"Andy Lutomirski" <luto@kernel.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Jue Wang <juew@google.com>, <linux-kernel@vger.kernel.org>,
<yaoaili126@gmail.com>
Subject: Re: [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races
Date: Thu, 6 May 2021 17:37:57 +0800 [thread overview]
Message-ID: <20210506173757.586580bd@alex-virtual-machine> (raw)
In-Reply-To: <20210427062953.2080293-2-nao.horiguchi@gmail.com>
On Tue, 27 Apr 2021 15:29:52 +0900
Naoya Horiguchi <nao.horiguchi@gmail.com> wrote:
> From: Tony Luck <tony.luck@intel.com>
>
> There can be races when multiple CPUs consume poison from the same
> page. The first into memory_failure() atomically sets the HWPoison
> page flag and begins hunting for tasks that map this page. Eventually
> it invalidates those mappings and may send a SIGBUS to the affected
> tasks.
>
> But while all that work is going on, other CPUs see a "success"
> return code from memory_failure() and so they believe the error
> has been handled and continue executing.
>
> Fix by wrapping most of the internal parts of memory_failure() in
> a mutex.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
> Reviewed-by: Borislav Petkov <bp@suse.de>
Sorry to interrupt, I just thought one thing:
This mutex seems not been bind to the error page, will there be some core case
like test code or multi-poison case whick will break this mutex?
Thanks!
Aili Yao
next prev parent reply other threads:[~2021-05-06 9:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 6:29 [PATCH v4 0/2] mm,hwpoison: fix sending SIGBUS for Action Required MCE Naoya Horiguchi
2021-04-27 6:29 ` [PATCH v4 1/2] mm/memory-failure: Use a mutex to avoid memory_failure() races Naoya Horiguchi
2021-05-06 9:37 ` Aili Yao [this message]
2021-05-06 15:34 ` Luck, Tony
2021-04-27 6:29 ` [PATCH v4 2/2] mm,hwpoison: send SIGBUS when the page has already been poisoned Naoya Horiguchi
2021-05-07 9:38 ` Aili Yao
2021-05-10 7:21 ` HORIGUCHI NAOYA(堀口 直也)
2021-05-10 8:00 ` Aili Yao
2021-05-10 8:31 ` HORIGUCHI NAOYA(堀口 直也)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506173757.586580bd@alex-virtual-machine \
--to=yaoaili@kingsoft.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=david@redhat.com \
--cc=juew@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=nao.horiguchi@gmail.com \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=tony.luck@intel.com \
--cc=yaoaili126@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).