From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 433C8C433B4 for ; Mon, 10 May 2021 04:46:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 876AB61424 for ; Mon, 10 May 2021 04:46:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 876AB61424 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 061B96B0070; Mon, 10 May 2021 00:46:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D3B6B0071; Mon, 10 May 2021 00:46:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA65D6B0072; Mon, 10 May 2021 00:46:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id BADBA6B0070 for ; Mon, 10 May 2021 00:46:05 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6C029180AD817 for ; Mon, 10 May 2021 04:46:05 +0000 (UTC) X-FDA: 78124084290.14.3C9A170 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf22.hostedemail.com (Postfix) with ESMTP id 1B487C0007C8 for ; Mon, 10 May 2021 04:45:57 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E47D613CE; Mon, 10 May 2021 04:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620621964; bh=rp7Pr5ZwLz7xf26y8soMdGC8+zpjFeP6bya6HohveU8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CqyexdQOXdYJurd8t44gilCxJyd/22uk3uYbXEYUkNJt1aSbnwkCuFEt6rLVjHaFQ ZtJ0VcZ4E1eih/esEpLdf/IQYyVMLueE6B2tv+RKF3LqRezylSovsacOdKMbEPZ4YL P9NiKYAR7R7YOj1GRmmDexSjy73xHqOshwnt2G+4= Date: Sun, 9 May 2021 21:46:03 -0700 From: Andrew Morton To: glittao@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects Message-Id: <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> References: <20210414163434.4376-1-glittao@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=CqyexdQO; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org X-Stat-Signature: 44wsz6p7atkt431ka4dnufpeuc1w5uuo X-Rspamd-Queue-Id: 1B487C0007C8 X-Rspamd-Server: rspam05 Received-SPF: none (linux-foundation.org>: No applicable sender policy available) receiver=imf22; identity=mailfrom; envelope-from=""; helo=mail.kernel.org; client-ip=198.145.29.99 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620621957-723907 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote: > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. Which tree was this prepared against? 5.12's kmem_obj_info() is significantly different from the version you were working on. Please take a look, redo, retest and resend? Thanks.