From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98AD9C433B4 for ; Mon, 10 May 2021 15:38:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F0AC6147F for ; Mon, 10 May 2021 15:38:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F0AC6147F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 59B8D6B0036; Mon, 10 May 2021 11:38:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54ACF6B0073; Mon, 10 May 2021 11:38:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39E626B0074; Mon, 10 May 2021 11:38:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0053.hostedemail.com [216.40.44.53]) by kanga.kvack.org (Postfix) with ESMTP id 1BB506B0036 for ; Mon, 10 May 2021 11:38:54 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id CE9F7B79E for ; Mon, 10 May 2021 15:38:53 +0000 (UTC) X-FDA: 78125729346.09.FA4BA6B Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf20.hostedemail.com (Postfix) with ESMTP id 1A7D1F9 for ; Mon, 10 May 2021 15:38:52 +0000 (UTC) Received: by mail-pj1-f42.google.com with SMTP id gx21-20020a17090b1255b02901589d39576eso4009733pjb.0 for ; Mon, 10 May 2021 08:38:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TPvcQCXvDX0U7RDZdZH95k1gUsIcweRlVHc3KTXarJk=; b=WnjtfBz40ML+d5x7ADRLmiMm02c4xlccwyOfB7T0FwayBGuUM6iJs8p80tPE3oWU9Z odiz7lrk8BpAQpTqXOX5PrvaUtObz0ueImqdLyv/ZdhkSMoBTBbe3VXkbXUdDOpw3MRe 52iLnbOmREYc7yXY44Ns+VBgu9NyYP6NhJgQ7FSsTLXtsNKvXGCueGEbyWxv5/sbXAMY LS9ctApBNtOrFPewoFktTYCApjymEO339L8mGvFnIc21e7zr9pM/boKZESypGRjqGzYP vmeh36hX6xqOg558QkZuAG+Oc9dK3mu3BDghGEUq1PpvIBXuUwqoxLyTwflreugeZBf9 iixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TPvcQCXvDX0U7RDZdZH95k1gUsIcweRlVHc3KTXarJk=; b=Rl8g+FdMiTl4fW/D6ieE2aRPIzCUGsBEDKLtUbtcDZLum4NrkWYMKnsgBDqj+rhoUp 6GswVr6eQjWDHlzPYmIsWkv1ZW9t5KcFOGkPgONW5dzqO+XGJOqv6alvnKx/9kKRYVDV o0n7CtBZG2tsM+T0+YLx5b2pO3iiUtV9cx+zcqjdNW5h0ESKWM1G7bGAQKxqcymkDI/0 ZTW38g9xNUcW1E0F3Z/2vHZsbngysm4iNzJCQ1NqrykhP31e9WrijA4o2uXrXYdZ5IA4 fs29d06Spt/QiuExiTlPcXAYRjhXnbXlUt4xcZ029MN3LN3OB/dnMN94WaRNwSRqCmpR Tiuw== X-Gm-Message-State: AOAM531WyIk+IO9RV1qKOj36H+BhZr+m1ahGr48Nn8u8Vtbj2oOZ6Wgv Rhxt1VNQnZEQ7IarMibogFo= X-Google-Smtp-Source: ABdhPJyynsLokTt/82/HW6Tevuk0fqq3BYQm0YcYjS4dmODSbGZ5VnnetREWJxRuS2iPTVsmiB0VIg== X-Received: by 2002:a17:90a:55c5:: with SMTP id o5mr27742585pjm.169.1620661132340; Mon, 10 May 2021 08:38:52 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id 79sm11530219pfz.202.2021.05.10.08.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 08:38:52 -0700 (PDT) Date: Tue, 11 May 2021 00:38:46 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Vlastimil Babka Cc: Matthew Wilcox , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Message-ID: <20210510153846.GA77398@hyeyoo> References: <20210508221328.7338-1-42.hyeyoo@gmail.com> <20210510135857.GA3594@hyeyoo> <9d0ffe49-a2e2-6c81-377b-4c8d2147dff8@suse.cz> <20210510150230.GA74915@hyeyoo> <90591d7e-41e4-9ae5-54ae-ded467c498cf@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90591d7e-41e4-9ae5-54ae-ded467c498cf@suse.cz> X-Rspamd-Server: rspam01 Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=WnjtfBz4; spf=pass (imf20.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: nya3erfjwtooop5jugc5zjtu6rnjk9im X-Rspamd-Queue-Id: 1A7D1F9 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf20; identity=mailfrom; envelope-from="<42.hyeyoo@gmail.com>"; helo=mail-pj1-f42.google.com; client-ip=209.85.216.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620661132-202337 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 10, 2021 at 05:19:58PM +0200, Vlastimil Babka wrote: > I'd rephrase the subject: > mm, slub: change run-time assertion in kmalloc_index() to compile-time > > "... compiler will generate a run-time BUG() while a compile-time error is also > possible, and better" > "there's no need to..." > kmalloc-32M Vlastimil Babka and Christoph Lameter, thank you for reviewing the patch. I'm not familiar with kernel community yet. should I send patch v3 again, or can you update it directly?