From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FD0C433ED for ; Tue, 11 May 2021 03:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3E3AD61469 for ; Tue, 11 May 2021 03:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E3AD61469 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C576B6B006E; Mon, 10 May 2021 23:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C082F6B0071; Mon, 10 May 2021 23:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AA93D6B0072; Mon, 10 May 2021 23:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 90B3F6B006E for ; Mon, 10 May 2021 23:09:10 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4DE2DA2DF for ; Tue, 11 May 2021 03:09:10 +0000 (UTC) X-FDA: 78127468860.40.BB78CA3 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by imf08.hostedemail.com (Postfix) with ESMTP id 07C7F80192C6 for ; Tue, 11 May 2021 03:08:42 +0000 (UTC) Received: by mail-pg1-f178.google.com with SMTP id t193so2213978pgb.4 for ; Mon, 10 May 2021 20:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vDycCYZUMZTRqclL05OsIOu92QLf1/h6CaOCTWyUtQo=; b=Dhn/BhszXa2kmPxmeAjJZYOD5Q7FN+5J43AnvUof7WBdQWttlGaEwkvQQgWAjXaE9u qJOZ/yX1ulX4HuW7ajZ6GdoCulDHmG8cQswpAnl3+iJL8DOgHsVLW1YyYB4LYdGJZNwM AcMlHdcxwlaDuwr0hSzgL6r2fUoWKQ/77/FmOpBUh49HQv/HDBJmTIoO5nqiqGYhn9zb ywTZkmiylk4imwnye5wkH+Sp5f92j9gZCLkOTO97qVPSmpbMp8Ei60l4a+1k+LDg+b9T Ki3KkwIZB6ZLy124T1rtAfmH9ZUwN7k1Uj6aql+DKdQae9U7Q0dML4K8qQvKwamwtO78 Cf0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vDycCYZUMZTRqclL05OsIOu92QLf1/h6CaOCTWyUtQo=; b=h1umL0uHAZs+3DCwynix1GcuELvA5qn/JDt7ACH4e5Igug+iRLtU7cdnGMxiMh6D4h 5g8U/wGqV7C8Z9u5rrYr7QB/knE9OzJVa+3jV6jB2dRp+mCa0jaOBbXu4sCIJDNutWGm 7K+86nQEKhP8RvZnBTssb1Yj8yCUHRUPSXK4MSCx1blnY5d5VMEkHKJEHsXoZ3m/zvf6 TxqXwUjuRKwcLfCY4EHowzPvF/uVEr5yNYJin2xJvgvyI0I4lYPAwBZ6r/7v7N7ZN/GR X0gnTTZIEtHpWIAuh52MVZEdemb4JlqMf9Oc/QrPyR6xXQWWc2Di5+1chzTxeuqvfw47 uJGA== X-Gm-Message-State: AOAM532tVdEMVSwcWM4SLbVeFn3xAdql7sm3rCztE/Aasex2x6p1A9C3 k0ZHdLR+3e3swKnC59cN6Oc= X-Google-Smtp-Source: ABdhPJxISlNL5PKuFc7Rg+E15Siv9zOgzobxSxMwxXxHlu7yfVRnn/rquLYu7UIk06fA7eJDL9CrNw== X-Received: by 2002:a62:1c0c:0:b029:2b7:6dd2:adb3 with SMTP id c12-20020a621c0c0000b02902b76dd2adb3mr12703106pfc.44.1620702548963; Mon, 10 May 2021 20:09:08 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id 33sm12156742pgq.21.2021.05.10.20.09.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 20:09:08 -0700 (PDT) Date: Tue, 11 May 2021 12:09:03 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Christoph Lameter Cc: Vlastimil Babka , Matthew Wilcox , penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm: kmalloc_index: make compiler break when size is not supported Message-ID: <20210511030903.GA105690@hyeyoo> References: <20210508221328.7338-1-42.hyeyoo@gmail.com> <20210510135857.GA3594@hyeyoo> <9d0ffe49-a2e2-6c81-377b-4c8d2147dff8@suse.cz> <20210510150230.GA74915@hyeyoo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 07C7F80192C6 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b="Dhn/Bhsz"; spf=pass (imf08.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.215.178 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: amxmsh4hdapbe4t9hufikqysaqbdtyni Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf08; identity=mailfrom; envelope-from="<42.hyeyoo@gmail.com>"; helo=mail-pg1-f178.google.com; client-ip=209.85.215.178 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1620702522-666674 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 10, 2021 at 05:15:23PM +0200, Christoph Lameter wrote: > I guess this needs to be reviewed and tested by the users of architectures > that can use large MAXORDER pages such as powerpc and Itanium. as Vlastimil Babka said, I think it's fine too. because KMALLOC_SHIFT_HIGH can't be bigger than 25 regardless of MAX_ORDER