From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B865FC43461 for ; Fri, 14 May 2021 14:53:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 285E661480 for ; Fri, 14 May 2021 14:53:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 285E661480 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9D3366B0036; Fri, 14 May 2021 10:53:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9842F6B006E; Fri, 14 May 2021 10:53:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FD4F6B0070; Fri, 14 May 2021 10:53:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0219.hostedemail.com [216.40.44.219]) by kanga.kvack.org (Postfix) with ESMTP id 5025B6B0036 for ; Fri, 14 May 2021 10:53:47 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id DFC3A1802FA58 for ; Fri, 14 May 2021 14:53:46 +0000 (UTC) X-FDA: 78140130852.38.02B801B Received: from outbound-smtp57.blacknight.com (outbound-smtp57.blacknight.com [46.22.136.241]) by imf26.hostedemail.com (Postfix) with ESMTP id 1541240002D7 for ; Fri, 14 May 2021 14:53:45 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp57.blacknight.com (Postfix) with ESMTPS id 9511DFA914 for ; Fri, 14 May 2021 15:53:44 +0100 (IST) Received: (qmail 14594 invoked from network); 14 May 2021 14:53:44 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.23.168]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 14 May 2021 14:53:44 -0000 Date: Fri, 14 May 2021 15:46:22 +0100 From: Mel Gorman To: Andrew Morton Cc: Chuck Lever , Jesper Dangaard Brouer , Thomas Gleixner , Sebastian Andrzej Siewior , Peter Zijlstra , Ingo Molnar , Michal Hocko , Vlastimil Babka , Linux-MM , Linux-RT-Users , LKML Subject: [PATCH] mm/page_alloc: Split per cpu page lists and zone stats -fix Message-ID: <20210514144622.GA3735@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 1541240002D7 Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf26.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.241 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Rspamd-Server: rspam04 X-Stat-Signature: 46f5ewj8cg64om4rdu3ibwg18h4hyjk3 X-HE-Tag: 1621004025-486020 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: mm/ is not W=3D1 clean for allnoconfig but the patch "mm/page_alloc: Spli= t per cpu page lists and zone stats" makes it worse with the following warning mm/vmstat.c: In function =E2=80=98zoneinfo_show_print=E2=80=99: mm/vmstat.c:1698:28: warning: variable =E2=80=98pzstats=E2=80=99 set bu= t not used [-Wunused-but-set-variable] struct per_cpu_zonestat *pzstats; ^~~~~~~ This is a fix to the mmotm patch mm-page_alloc-split-per-cpu-page-lists-and-zone-stats.patch. Signed-off-by: Mel Gorman --- mm/vmstat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index e3bcd317ea55..a2c3f58253be 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1695,10 +1695,9 @@ static void zoneinfo_show_print(struct seq_file *m= , pg_data_t *pgdat, seq_printf(m, "\n pagesets"); for_each_online_cpu(i) { struct per_cpu_pages *pcp; - struct per_cpu_zonestat *pzstats; + struct per_cpu_zonestat __maybe_unused *pzstats; =20 pcp =3D per_cpu_ptr(zone->per_cpu_pageset, i); - pzstats =3D per_cpu_ptr(zone->per_cpu_zonestats, i); seq_printf(m, "\n cpu: %i" "\n count: %i" @@ -1709,6 +1708,7 @@ static void zoneinfo_show_print(struct seq_file *m,= pg_data_t *pgdat, pcp->high, pcp->batch); #ifdef CONFIG_SMP + pzstats =3D per_cpu_ptr(zone->per_cpu_zonestats, i); seq_printf(m, "\n vm stats threshold: %d", pzstats->stat_threshold); #endif