From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7FE6C433B4 for ; Tue, 18 May 2021 00:39:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4C95D6139A for ; Tue, 18 May 2021 00:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4C95D6139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9756C6B009E; Mon, 17 May 2021 20:39:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 924EA6B009F; Mon, 17 May 2021 20:39:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778A86B00A0; Mon, 17 May 2021 20:39:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 41B226B009E for ; Mon, 17 May 2021 20:39:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id CCDF0A8D7 for ; Tue, 18 May 2021 00:39:08 +0000 (UTC) X-FDA: 78152492376.03.2727A52 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf10.hostedemail.com (Postfix) with ESMTP id E69EA40002DC for ; Tue, 18 May 2021 00:39:05 +0000 (UTC) Received: by mail-pj1-f49.google.com with SMTP id g6-20020a17090adac6b029015d1a9a6f1aso787044pjx.1 for ; Mon, 17 May 2021 17:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=XJERjlzz2JqpiW35y50+LdlSX0FgN6gm7UsIOMCxH9A=; b=XeKcnEwIAG/jlT7UuXSkRXgKn/eA0UPk8FvIvNgMe99vO7rC2Jkful5ErQarQwJJnr n4br+xjc2HCI6mIgAuKGsrWC4xbyUeT/0kqiDUIIKoO9x6JYTEWaXehEcP2cWX4BfC4L HhMvKWnOqgo4a1v9rE9zhQ/6JLDz2+XZy6IgL2Thw3zIUx5t6+6gMp/Y41Turv6j/3LQ o8x+s2ga//Ra3u2TPDpW6iK6YlIjc3+ebLP+YGn8ZSConOBK4rRUoZ6OVMDmxjo8K7lf cy4KPcg8DU0DD251z8cogCRiq1e4QvM7lx0CJpqKqNKbqYCD71wNkPyxVbywL22Pr8nG h3HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XJERjlzz2JqpiW35y50+LdlSX0FgN6gm7UsIOMCxH9A=; b=CiNrandlYFVC9VvJJJ/rkPdSktm39q80SDe3XBLxwqlBVLz7pjpPU+54DbLz/jE/YV 3Hcg16/NpU8o4vR07E6h/92GDh8zFt/PtDnAvlSiwcriEfpdSa5tt7OCmJnI8YqIrqAJ kFjcMIPezRL052TJqnUl3NL04dsWDjIpdKWmpV+iHT3RbqAhJ3jK5eIxTewOr6QmrsEc 9XxVBFkbBKRvqknUDBeAztLbB30uBe/mkebaXWDUAMYso7MeE3HthiP1fK8x7hhZySmk 4udse/UZVihf2Wyal8hJfESbQdy6ilSoclM7eje5qhNbQTmx/0slg9vWG10QdXtJ9FB4 JAlw== X-Gm-Message-State: AOAM532MhIcfvCqfB8YH5hJkb4hgMXu/4PH2VHraiAhJbJYDs+cjBoMq Y9ZEhtph3C6D6pOTsH8m+EQ= X-Google-Smtp-Source: ABdhPJwBowksJGQuhUZRWk/iQ7EWmJQSyFcQA9q0auXwUBgVqteIlgHI5UsBOMw1P7h2E9Q5qnJs7A== X-Received: by 2002:a17:90a:fa5:: with SMTP id 34mr1938655pjz.113.1621298347440; Mon, 17 May 2021 17:39:07 -0700 (PDT) Received: from hyeyoo ([183.99.11.150]) by smtp.gmail.com with ESMTPSA id z65sm10940314pfb.13.2021.05.17.17.39.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 17:39:07 -0700 (PDT) Date: Tue, 18 May 2021 09:38:59 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Nathan Chancellor Cc: Vlastimil Babka , akpm@linux-foundation.org, iamjoonsoo.kim@lge.com, rientjes@google.com, penberg@kernel.org, cl@linux.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org, clang-built-linux@googlegroups.com, linux-next@vger.kernel.org, ndesaulniers@google.com, lkft-triage@lists.linaro.org, sfr@canb.auug.org.au, arnd@arndb.de, Marco Elver Subject: Re: [PATCH v3] mm, slub: change run-time assertion in kmalloc_index() to compile-time Message-ID: <20210518003859.GC80297@hyeyoo> References: <20210511173448.GA54466@hyeyoo> <20210515210950.GA52841@hyeyoo> <41c65455-a35b-3ad3-54f9-49ca7105bfa9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=XeKcnEwI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 42hyeyoo@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=42hyeyoo@gmail.com X-Stat-Signature: qymenwz38h9zcjfcu8t7h1qgy5j3uww7 X-Rspamd-Queue-Id: E69EA40002DC X-Rspamd-Server: rspam02 X-HE-Tag: 1621298345-71580 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 15, 2021 at 11:34:49PM -0700, Nathan Chancellor wrote: > This should work I think: compiled well with clang-10.0.1, clang-11.0.0, and gcc-10.2.0 with x86_64 default config. is the condition CONFIG_CLANG_VERSION > 110000, not including 110000 it self? > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 9d316aac0aba..1b653266f2aa 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -413,7 +413,7 @@ static __always_inline unsigned int __kmalloc_index(size_t size, > if (size <= 16 * 1024 * 1024) return 24; > if (size <= 32 * 1024 * 1024) return 25; > > - if (size_is_constant) > + if ((IS_ENABLED(CONFIG_CC_IS_GCC) || CONFIG_CLANG_VERSION > 110000) && size_is_constant) > BUILD_BUG_ON_MSG(1, "unexpected size in kmalloc_index()"); > else > BUG();