From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D025CC433B4 for ; Wed, 19 May 2021 13:06:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6272D6135F for ; Wed, 19 May 2021 13:06:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6272D6135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E55B86B0036; Wed, 19 May 2021 09:06:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E050D6B006C; Wed, 19 May 2021 09:06:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7F476B006E; Wed, 19 May 2021 09:06:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 9A47B6B0036 for ; Wed, 19 May 2021 09:06:15 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 38D33180AD838 for ; Wed, 19 May 2021 13:06:15 +0000 (UTC) X-FDA: 78158003910.08.AB3D717 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 4C4977B1 for ; Wed, 19 May 2021 13:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621429574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xqzvhqKhh1nFQM60OV9hcT/mMJVDvQ3rAokoQfYzmz4=; b=ckzUFq7gmIf0T+2h7tVlUshE9TKbHSUYU6m56fZIpPru5HaZ3wcrTAYb8hdvAebnykc24t vNPtEqSHvSssj0Hd1VouVkzvluK9ZUTJlyj40yPMSfYY4w+ylVb5j4EA8f7i4P0eyoLl09 jwwwX83akG3vpingPt6MoX+UCJ8rDro= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-KrTlIzA_PbeCQlS9QxoVhA-1; Wed, 19 May 2021 09:06:12 -0400 X-MC-Unique: KrTlIzA_PbeCQlS9QxoVhA-1 Received: by mail-wr1-f72.google.com with SMTP id 67-20020adf81490000b029010756d109e6so7069405wrm.13 for ; Wed, 19 May 2021 06:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xqzvhqKhh1nFQM60OV9hcT/mMJVDvQ3rAokoQfYzmz4=; b=QeGdgRmjbWlFi81JodUJ5FOwIdx/2qXCaFm93+f8yxSRE5ahhQtJvrZtc1ZChBAP4L 46EjyCkAmHFFSgONGzurWD8u4jLRJ4npd/hxWAxKZga0LTZ6UenPxR9hz5WbK7tg9d3z anyADQu5zywQeWWq4XrJk0Viz2uA+cZqg5PwAuwLe1d0H40+ZEuzEqw7OQUA8E23m0RH FZW1IQdt34W2u+KxDNbAuYRAVjXIvfr9ZLWKcOx8FANyJzh9uzS/LsmglWBTCNFYidQl 4532P+zNi6FNqz7M+nDNq+WZJ8fd9XTUfTfm9BHd5JYj4UAeKf2HchGQf2ZD80fKjWbW z+5w== X-Gm-Message-State: AOAM532yaDy2pJuBMMmrPnUEsohPsT6yHpufWmSGQsfDG4DGWRL8J512 Uzhc6g/nSmYHk2pJE2Hu0wfEHRceb4uDo1iRi1XoARqTNCnvLCK24Pc+ev1WFjSJhKKFfOjvSpE iqtH/xeuWcA== X-Received: by 2002:a5d:64aa:: with SMTP id m10mr14731771wrp.291.1621429571654; Wed, 19 May 2021 06:06:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwmkaVogALKjMKQCJnqNqqS951xIsSZNejhsUEMl2kc6HJVeWXrLDE4wji4CEWD3+ScKdprvA== X-Received: by 2002:a5d:64aa:: with SMTP id m10mr14731738wrp.291.1621429571451; Wed, 19 May 2021 06:06:11 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id s11sm3277535wmf.14.2021.05.19.06.06.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 06:06:11 -0700 (PDT) Date: Wed, 19 May 2021 14:06:09 +0100 From: Aaron Tomlin To: Michal Hocko Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Vlastimil Babka Subject: Re: [PATCH] mm/page_alloc: try oom if reclaim is unable to make forward progress Message-ID: <20210519130609.r3ml6ohb2qsrfq2t@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20210315165837.789593-1-atomlin@redhat.com> <20210319172901.cror2u53b7caws3a@ava.usersys.com> <20210325210159.r565fvfitoqeuykp@ava.usersys.com> <20210326112254.jy5jkiwtgj3pqkt2@ava.usersys.com> <20210518140554.dwan66i4ttmzw4hj@ava.usersys.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ckzUFq7g; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=atomlin@redhat.com X-Stat-Signature: bxe3xh55drbxx7sc1r3yc6qceqqzj8r4 X-Rspamd-Queue-Id: 4C4977B1 X-Rspamd-Server: rspam02 X-HE-Tag: 1621429573-697407 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Michal, On Wed 2021-05-19 13:10 +0200, Michal Hocko wrote: > > Looking at try_to_compact_pages(), indeed COMPACT_SKIPPED can be returned; > > albeit, not every zone, on the zone list, would be considered in the case > > a fatal signal is found to be pending. Yet, in should_compact_retry(), > > given the last known compaction result, each zone, on the zone list, can be > > considered/or checked (see compaction_zonelist_suitable()). If a zone e.g. > > was found to succeed then reclaim/compaction would be tried again > > (notwithstanding the above). > > I believe Vlastimil would be much better fit into looking into those > details but it smells like pending fatal signals can lead to a unbound > retry indeed. Understood. I will post a trivial patch to hopefully address this particular condition in the compaction retry code path, shortly for further discussion. Kind regards, -- Aaron Tomlin