From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C356DC4708A for ; Thu, 27 May 2021 07:26:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D12B5613D4 for ; Thu, 27 May 2021 07:26:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D12B5613D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2E90B6B0036; Thu, 27 May 2021 03:26:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 297B96B006E; Thu, 27 May 2021 03:26:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1389F6B0070; Thu, 27 May 2021 03:26:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0148.hostedemail.com [216.40.44.148]) by kanga.kvack.org (Postfix) with ESMTP id CC8156B0036 for ; Thu, 27 May 2021 03:26:05 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 689DB9079 for ; Thu, 27 May 2021 07:26:05 +0000 (UTC) X-FDA: 78186177090.15.CDD7F65 Received: from ozlabs.org (ozlabs.org [203.11.71.1]) by imf27.hostedemail.com (Postfix) with ESMTP id E5A4480192C0 for ; Thu, 27 May 2021 07:25:56 +0000 (UTC) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4FrK9g0ggkz9sTD; Thu, 27 May 2021 17:25:59 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1622100359; bh=YQLamtKVY98aqdADqaCNSOAc4QEP5KeiQ0HcfFqfhzU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YVl/21u/M3kDvYmBlgqmwh7ToSlY8Ep9ndJmrZ7D3LFQQ2h/XOP8FYU9X7NZmoTcL QxGsXnWvfwk6mWJ8XHGTRJOZBDZHdcxIf5Eam2lIWbgoGFerXxxJoYyBBCzoLZzhns YwIRE3qEO5SYaKtetdA4Oj6Ilwgrri2Iiy7pqeS3Szz+fxJDAPTz/T/Et9Ww1xWZiW 4iGOxqGfBxV+tLRCcwsGSnl7XqkfJF2bj4FMSpb0TeG5GJlfcyWROWfeQ922UrDlHf Kc6htnu30A/TtpqgzEAycHk8DH9Qurn5DhGKBkJG/vXvBYVUsMLcfFVx64PZTHySlq 8c1cP7AZjJlfA== Date: Thu, 27 May 2021 17:25:56 +1000 From: Stephen Rothwell To: Andrew Morton Cc: Qian Cai , Mike Rapoport , David Hildenbrand , Catalin Marinas , Anshuman Khandual , Ard Biesheuvel , Linux Memory Management List , Will Deacon , Marc Zyngier , Linux Kernel Mailing List , Linux ARM Subject: Re: Arm64 crash while reading memory sysfs Message-ID: <20210527172556.31e63155@canb.auug.org.au> In-Reply-To: <20210526173141.f1b511816fb33eab881e0c8f@linux-foundation.org> References: <20210526173141.f1b511816fb33eab881e0c8f@linux-foundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/CoLTGC06BAEA8Pb41FEqUbs"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Rspamd-Queue-Id: E5A4480192C0 Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b="YVl/21u/"; dmarc=none; spf=pass (imf27.hostedemail.com: domain of sfr@canb.auug.org.au designates 203.11.71.1 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au X-Rspamd-Server: rspam03 X-Stat-Signature: xi6jy75ssnxacwf8mpm1za5oyihyqefw X-HE-Tag: 1622100356-799859 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --Sig_/CoLTGC06BAEA8Pb41FEqUbs Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Andrew, On Wed, 26 May 2021 17:31:41 -0700 Andrew Morton wrote: > > On Wed, 26 May 2021 20:16:14 -0400 Qian Cai wr= ote: >=20 > >=20 > >=20 > > On 5/26/2021 1:24 PM, Mike Rapoport wrote: =20 > > > On Wed, May 26, 2021 at 12:09:14PM +0000, Qian Cai (QUIC) wrote: =20 > > >>> > > >>> On Tue, May 25, 2021 at 03:25:59PM +0000, Qian Cai (QUIC) wrote: =20 > > >>>> Reverting the patchset "arm64: drop pfn_valid_within() and simplif= y pfn_valid()" [1] from today's linux-next fixed a crash while =20 > > >>> reading files under /sys/devices/system/memory. =20 > > >=20 > > > Does the issue persist of you only revert the latest patch in the ser= ies? > > > In next-20210525 it would be commit=20 > > > 89fb47db72f2 ("arm64-drop-pfn_valid_within-and-simplify-pfn_valid-fix= ") > > > and commit > > > dfe215e9bac2 ("arm64: drop pfn_valid_within() and simplify pfn_valid(= )"). =20 > >=20 > > Reverting those two commits alone is enough to fix the issue. =20 >=20 > (cc Stephen) >=20 > Thanks, I'll drop >=20 > arm64-drop-pfn_valid_within-and-simplify-pfn_valid.patch > arm64-drop-pfn_valid_within-and-simplify-pfn_valid-fix.patch Reverted from linux-next for today as well. --=20 Cheers, Stephen Rothwell --Sig_/CoLTGC06BAEA8Pb41FEqUbs Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmCvSYQACgkQAVBC80lX 0GzcRAf+IcVmcfKdbF7o0IBQyg9HEg/Rcb8kBI0CBkTTje9mMZ7V0C8LZldlFNdu WnY34wef4b0APpBIT+AP4bQErjms9oTddLo9NRHoMGGzLoDXQu+VUW2em1LVQs+y 9wEjgoCDE4jonLosojerFgBADLdwQEViBF5+Z9f3TPzkPuI8Z+A2ySBVP0mDkz7C yGn7aX5DNmsFBv5PwxadLSYgb/qOHDqBEMSkKnpmEO474UgY+cl+xXmtIJ5jB9cN Iy8A1gQTKQK862+JcdY08IlG6W12m88o9647HfUlTZCnza2eEpU/Iokk4aqEmc+I hnXdiEWzC2q0JgqYCanI9hwOpmfdYA== =eDK7 -----END PGP SIGNATURE----- --Sig_/CoLTGC06BAEA8Pb41FEqUbs--