From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E643FC47082 for ; Sat, 29 May 2021 06:38:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 015BD613B6 for ; Sat, 29 May 2021 06:38:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 015BD613B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F02846B0036; Sat, 29 May 2021 02:38:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2806B006E; Sat, 29 May 2021 02:38:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2C3A6B0070; Sat, 29 May 2021 02:38:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 9C0766B0036 for ; Sat, 29 May 2021 02:38:33 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1D1D8181AF5C3 for ; Sat, 29 May 2021 06:38:33 +0000 (UTC) X-FDA: 78193314906.37.2AEB71C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 7E6B2A001A8C for ; Sat, 29 May 2021 06:38:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id DF14B68AFE; Sat, 29 May 2021 08:38:28 +0200 (CEST) Date: Sat, 29 May 2021 08:38:28 +0200 From: Christoph Hellwig To: Felix Kuehling Cc: felix.kuehling@amd.com, akpm@linux-foundation.org, linux-mm@kvack.org, hch@lst.de, jglisse@redhat.com, jgg@nvidia.com, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, Alex Sierra Subject: Re: [RFC PATCH 1/5] drm/amdkfd: add SPM support for SVM Message-ID: <20210529063828.GA15834@lst.de> References: <20210527230809.3701-1-Felix.Kuehling@amd.com> <20210527230809.3701-2-Felix.Kuehling@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527230809.3701-2-Felix.Kuehling@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 7E6B2A001A8C Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam03 X-Stat-Signature: yns4jxzwd9ywx1sa198io1trhq1wwtgx X-HE-Tag: 1622270304-125108 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 27, 2021 at 07:08:05PM -0400, Felix Kuehling wrote: > diff --git a/kernel/resource.c b/kernel/resource.c > index 627e61b0c124..da137553b83e 100644 > --- a/kernel/resource.c > +++ b/kernel/resource.c > @@ -783,7 +783,7 @@ struct resource *lookup_resource(struct resource *root, resource_size_t start) > > return res; > } > - > +EXPORT_SYMBOL(lookup_resource); NAK on hiding random exports in a driver patch. This needs to be a proper patch with a proper rationale, a kerneldoc comment and use EXPORT_SYMBOL_GPL. And even then it smells rather fishy, but I'll wait for the rationale.