From: sj38.park@gmail.com
To: akpm@linux-foundation.org
Cc: SeongJae Park <sjpark@amazon.de>,
Jonathan.Cameron@Huawei.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, amit@kernel.org,
benh@kernel.crashing.org, brendanhiggins@google.com,
corbet@lwn.net, david@redhat.com, dwmw@amazon.com,
elver@google.com, fan.du@intel.com, foersleo@amazon.de,
greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com,
mgorman@suse.de, minchan@kernel.org, mingo@redhat.com,
namhyung@kernel.org, peterz@infradead.org, riel@surriel.com,
rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org,
shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com,
snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com,
zgf574564920@gmail.com, linux-damon@amazon.com,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 04/13] mm/damon/dbgfs: Support schemes speed limit
Date: Mon, 31 May 2021 13:38:07 +0000 [thread overview]
Message-ID: <20210531133816.12689-5-sj38.park@gmail.com> (raw)
In-Reply-To: <20210531133816.12689-1-sj38.park@gmail.com>
From: SeongJae Park <sjpark@amazon.de>
This commit makes the debugfs interface of DAMON to support the schemes
speed limit by chaning the format of the input for the schemes file.
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
mm/damon/dbgfs.c | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c
index 4b45b69db697..ea6d4fdb57fa 100644
--- a/mm/damon/dbgfs.c
+++ b/mm/damon/dbgfs.c
@@ -227,11 +227,12 @@ static ssize_t sprint_schemes(struct damon_ctx *c, char *buf, ssize_t len)
damon_for_each_scheme(s, c) {
rc = scnprintf(&buf[written], len - written,
- "%lu %lu %u %u %u %u %d %lu %lu\n",
+ "%lu %lu %u %u %u %u %d %lu %lu %lu %lu\n",
s->min_sz_region, s->max_sz_region,
s->min_nr_accesses, s->max_nr_accesses,
s->min_age_region, s->max_age_region,
- s->action, s->stat_count, s->stat_sz);
+ s->action, s->limit.sz, s->limit.ms,
+ s->stat_count, s->stat_sz);
if (!rc)
return -ENOMEM;
@@ -312,10 +313,11 @@ static struct damos **str_to_schemes(const char *str, ssize_t len,
while (pos < len && *nr_schemes < max_nr_schemes) {
struct damos_speed_limit limit = {};
- ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u%n",
+ ret = sscanf(&str[pos], "%lu %lu %u %u %u %u %u %lu %lu%n",
&min_sz, &max_sz, &min_nr_a, &max_nr_a,
- &min_age, &max_age, &action, &parsed);
- if (ret != 7)
+ &min_age, &max_age, &action, &limit.sz,
+ &limit.ms, &parsed);
+ if (ret != 9)
break;
if (!damos_action_valid(action)) {
pr_err("wrong action %d\n", action);
@@ -1133,6 +1135,15 @@ static ssize_t dbgfs_monitor_on_write(struct file *file,
return ret;
}
+/*
+ * v1: Add the scheme speed limit
+ */
+static ssize_t dbgfs_version_read(struct file *file,
+ char __user *buf, size_t count, loff_t *ppos)
+{
+ return simple_read_from_buffer(buf, count, ppos, "1\n", 2);
+}
+
static const struct file_operations mk_contexts_fops = {
.owner = THIS_MODULE,
.write = dbgfs_mk_context_write,
@@ -1149,13 +1160,18 @@ static const struct file_operations monitor_on_fops = {
.write = dbgfs_monitor_on_write,
};
+static const struct file_operations version_fops = {
+ .owner = THIS_MODULE,
+ .read = dbgfs_version_read,
+};
+
static int __init __damon_dbgfs_init(void)
{
struct dentry *dbgfs_root;
const char * const file_names[] = {"mk_contexts", "rm_contexts",
- "monitor_on"};
+ "monitor_on", "version"};
const struct file_operations *fops[] = {&mk_contexts_fops,
- &rm_contexts_fops, &monitor_on_fops};
+ &rm_contexts_fops, &monitor_on_fops, &version_fops};
int i;
dbgfs_root = debugfs_create_dir("damon", NULL);
--
2.17.1
next prev parent reply other threads:[~2021-05-31 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 13:38 [RFC PATCH 00/13] Introduce DAMON-based Proactive Reclamation sj38.park
2021-05-31 13:38 ` [RFC PATCH 01/13] mm/damon/paddr: Support the pageout scheme sj38.park
2021-05-31 13:38 ` [RFC PATCH 02/13] mm/damon/damos: Make schemes aggressiveness controllable sj38.park
2021-05-31 13:38 ` [RFC PATCH 03/13] damon/core/schemes: Skip already charged targets and regions sj38.park
2021-05-31 13:38 ` sj38.park [this message]
2021-05-31 13:38 ` [RFC PATCH 05/13] mm/damon/selftests: Support schemes speed limit sj38.park
2021-05-31 13:38 ` [RFC PATCH 06/13] mm/damon/schemes: Prioritize regions within " sj38.park
2021-05-31 13:38 ` [RFC PATCH 07/13] mm/damon/vaddr,paddr: Support pageout prioritization sj38.park
2021-05-31 13:38 ` [RFC PATCH 08/13] mm/damon/dbgfs: Support prioritization weights sj38.park
2021-05-31 13:38 ` [RFC PATCH 09/13] tools/selftests/damon: Update for regions prioritization of schemes sj38.park
2021-05-31 13:38 ` [RFC PATCH 10/13] mm/damon/schemes: Activate schemes based on a watermarks mechanism sj38.park
2021-06-07 8:40 ` SeongJae Park
2021-05-31 13:38 ` [RFC PATCH 11/13] mm/damon/dbgfs: Support watermarks sj38.park
2021-05-31 13:38 ` [RFC PATCH 12/13] selftests/damon: " sj38.park
2021-05-31 13:38 ` [RFC PATCH 13/13] mm/damon: Introduce DAMON-based reclamation sj38.park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210531133816.12689-5-sj38.park@gmail.com \
--to=sj38.park@gmail.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=amit@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=dwmw@amazon.com \
--cc=elver@google.com \
--cc=fan.du@intel.com \
--cc=foersleo@amazon.de \
--cc=greg@kroah.com \
--cc=gthelen@google.com \
--cc=guoju.fgj@alibaba-inc.com \
--cc=linux-damon@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@surriel.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.de \
--cc=snu@zelle79.org \
--cc=vbabka@suse.cz \
--cc=vdavydov.dev@gmail.com \
--cc=zgf574564920@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).