From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF140C07E94 for ; Fri, 4 Jun 2021 15:54:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 50365613F1 for ; Fri, 4 Jun 2021 15:54:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 50365613F1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CCC7D6B00A3; Fri, 4 Jun 2021 11:54:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C7C186B00A5; Fri, 4 Jun 2021 11:54:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A80CD6B00A6; Fri, 4 Jun 2021 11:54:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 703FE6B00A3 for ; Fri, 4 Jun 2021 11:54:29 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0BB8D82CE564 for ; Fri, 4 Jun 2021 15:54:29 +0000 (UTC) X-FDA: 78216488658.21.A4C4178 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf19.hostedemail.com (Postfix) with ESMTP id F2C409001E73 for ; Fri, 4 Jun 2021 15:54:06 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id bn21so12211719ljb.1 for ; Fri, 04 Jun 2021 08:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oFCNS8GD7XvNmkv9HevhbndY3QsLqxRxLrMyqE667So=; b=UbOamRQHTZORVcXzhrMn/JyMDM+zIvF6b53/bvhyd4Z6Z+1vnCWIG5EUV4KwH20QQB dtyHuIrAJX1kPAafBIXocSAdE57/cmfu2mW1cNn4jAR2ykCkvgFzpvPrfkFaovSXgDab 00bqljuG+JwZrwO/9hYvcFYeel1GtYmrq34SU3fDfWS2+htGxnml5R1Hr7jMDrgVWuEN FipvcGl5PvEb/pukv9AEvBurqWxdSon+MWxcgF/B3QCRn1AEnuvVlXMoCOt6nBrvva85 eyuoN4uT53nlRD2IJ5MLjbugLz1YWD/LsFyqM8wrymTHxG2v6OIpy6IQRv/nkLXtAHel j+Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oFCNS8GD7XvNmkv9HevhbndY3QsLqxRxLrMyqE667So=; b=V5oTksC/EmNeOEMtwpC1wf6sXIVK/wfYRCzS/Rt5DY1URNdS40f7ZCFsn/JGV+a++N 5tzqeiknb1un/ocZpT1Owe+nynYFPpPMQ8dRyCCHb9VabX37x8DcMp3GqEQDFJ0T4p+2 vjdD/jQNe8JlrdTV0HSoiDDzRiTqdkna/oAMeOfvvQZKQnNB2w5QpDyaYXIjgPYApXGM 9A08xTLYUdYvR+ydTAlVCDRP3MEMFvEpIKjrJ7ahdeUkYhWj6m+JOKhWjUTpSteDqLX2 8PiuntkByxzoAUnPIPhZdYXs9XvjjsRlnzYRgjPvXzvNrc4AsroLya3416fElLPPg8Ff 7EDw== X-Gm-Message-State: AOAM530GauCNJt3nKy+FpSYWJjDJaLjhMnxPE2XFJWXsebmsG5vQgcXo wgKd/LrLhqxCXkrcUvl5BltFEg== X-Google-Smtp-Source: ABdhPJwpjzyw/b3727kENoSPhg40Ytzl4GcMz+cvzzRZKYIuveBTVYT4ONLVB+m+zT7XDDPLSmF1zA== X-Received: by 2002:a2e:b60d:: with SMTP id r13mr4103967ljn.220.1622822063167; Fri, 04 Jun 2021 08:54:23 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id v1sm646109lfq.284.2021.06.04.08.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 08:54:22 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E0D401027A9; Fri, 4 Jun 2021 18:54:34 +0300 (+03) Date: Fri, 4 Jun 2021 18:54:34 +0300 From: "Kirill A. Shutemov" To: Hugh Dickins Cc: Andrew Morton , "Kirill A. Shutemov" , Yang Shi , Wang Yugui , Matthew Wilcox , Naoya Horiguchi , Alistair Popple , Ralph Campbell , Zi Yan , Miaohe Lin , Minchan Kim , Jue Wang , Peter Xu , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] mm/thp: fix page_address_in_vma() on file THP tails Message-ID: <20210604155434.uexotqaf5dmh3ygj@box.shutemov.name> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: hz1kmqjy1c59753bseau1huic37hrim5 X-Rspamd-Queue-Id: F2C409001E73 X-Rspamd-Server: rspam02 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=UbOamRQH; dmarc=none; spf=none (imf19.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.180) smtp.mailfrom=kirill@shutemov.name X-HE-Tag: 1622822046-364825 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 01, 2021 at 02:11:22PM -0700, Hugh Dickins wrote: > From: Jue Wang > > Anon THP tails were already supported, but memory-failure may need to use > page_address_in_vma() on file THP tails, which its page->mapping check did > not permit: fix it. > > hughd adds: no current usage is known to hit the issue, but this does fix > a subtle trap in a general helper: best fixed in stable sooner than later. > > Fixes: 800d8c63b2e9 ("shmem: add huge pages support") > Signed-off-by: Jue Wang > Signed-off-by: Hugh Dickins > Cc: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov