From: kernel test robot <lkp@intel.com>
To: John Ogness <john.ogness@linutronix.de>, Petr Mladek <pmladek@suse.com>
Cc: kbuild-all@lists.01.org,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH next v2 1/2] dump_stack: move cpu lock to printk.c
Date: Tue, 8 Jun 2021 10:43:46 +0800 [thread overview]
Message-ID: <202106081055.UgUlUS1Z-lkp@intel.com> (raw)
In-Reply-To: <20210607200232.22211-2-john.ogness@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 2245 bytes --]
Hi John,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20210607]
url: https://github.com/0day-ci/linux/commits/John-Ogness/introduce-printk-cpu-lock/20210608-040454
base: 7f09e895a7f3e0af63bf9ec6c7c22893ec7e6c8e
config: mips-randconfig-r036-20210607 (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/136bcc2980e636b2ae156ca63fbe95c713e44c1b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review John-Ogness/introduce-printk-cpu-lock/20210608-040454
git checkout 136bcc2980e636b2ae156ca63fbe95c713e44c1b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
lib/dump_stack.c: In function 'dump_stack_lvl':
>> lib/dump_stack.c:107:2: warning: 'lock_flag' is used uninitialized in this function [-Wuninitialized]
107 | printk_cpu_unlock_irqrestore(lock_flag, irq_flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/lock_flag +107 lib/dump_stack.c
90
91 /**
92 * dump_stack - dump the current task information and its stack trace
93 *
94 * Architectures can override this implementation by implementing its own.
95 */
96 asmlinkage __visible void dump_stack_lvl(const char *log_lvl)
97 {
98 unsigned long irq_flags;
99 bool lock_flag;
100
101 /*
102 * Permit this cpu to perform nested stack dumps while serialising
103 * against other CPUs
104 */
105 printk_cpu_lock_irqsave(&lock_flag, &irq_flags);
106 __dump_stack(log_lvl);
> 107 printk_cpu_unlock_irqrestore(lock_flag, irq_flags);
108 }
109 EXPORT_SYMBOL(dump_stack_lvl);
110
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26602 bytes --]
next parent reply other threads:[~2021-06-08 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210607200232.22211-2-john.ogness@linutronix.de>
2021-06-08 2:43 ` kernel test robot [this message]
2021-06-08 13:48 ` [PATCH next v2 1/2] dump_stack: move cpu lock to printk.c Petr Mladek
2021-06-10 13:26 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202106081055.UgUlUS1Z-lkp@intel.com \
--to=lkp@intel.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=elver@google.com \
--cc=john.ogness@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).