From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Matthew Wilcox <willy@infradead.org>
Cc: Xu Yu <xuyu@linux.alibaba.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hughd@google.com, akpm@linux-foundation.org,
gavin.dg@linux.alibaba.com
Subject: Re: [PATCH v2] mm, thp: use head page in __migration_entry_wait
Date: Tue, 8 Jun 2021 15:58:38 +0300 [thread overview]
Message-ID: <20210608125838.6ixdlz3t334gjnp7@box.shutemov.name> (raw)
In-Reply-To: <YL9jVYgWYBydOYst@casper.infradead.org>
On Tue, Jun 08, 2021 at 01:32:21PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 08, 2021 at 03:00:26PM +0300, Kirill A. Shutemov wrote:
> > But there's one quirk: if split succeed we effectively wait on wrong
> > page to be unlocked. And it may take indefinite time if split_huge_page()
> > was called on the head page.
>
> Hardly indefinite time ... callers of split_huge_page_to_list() usually
> unlock the page soon after. Actually, I can't find one that doesn't call
> unlock_page() within a few lines of calling split_huge_page_to_list().
I didn't check all callers, but it's not guaranteed by the interface and
it's not hard to imagine a future situation when a page got split on the
way to IO and kept locked until IO is complete.
The wake up shouldn't have much overhead as in most cases split going to
be called on the head page.
--
Kirill A. Shutemov
next prev parent reply other threads:[~2021-06-08 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 9:22 [PATCH v2] mm, thp: use head page in __migration_entry_wait Xu Yu
2021-06-08 12:00 ` Kirill A. Shutemov
2021-06-08 12:32 ` Matthew Wilcox
2021-06-08 12:58 ` Kirill A. Shutemov [this message]
2021-06-08 13:35 ` Matthew Wilcox
2021-06-09 9:59 ` Kirill A. Shutemov
2021-06-08 13:22 ` Yu Xu
2021-06-09 10:08 ` Kirill A. Shutemov
2021-06-08 20:00 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608125838.6ixdlz3t334gjnp7@box.shutemov.name \
--to=kirill@shutemov.name \
--cc=akpm@linux-foundation.org \
--cc=gavin.dg@linux.alibaba.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
--cc=xuyu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).