From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8481C48BCD for ; Wed, 9 Jun 2021 11:40:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B9C360FD8 for ; Wed, 9 Jun 2021 11:40:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B9C360FD8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C818D6B0098; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B93496B009B; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 926BA6B0098; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0116.hostedemail.com [216.40.44.116]) by kanga.kvack.org (Postfix) with ESMTP id 2300F6B008C for ; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BFC85B9E8 for ; Wed, 9 Jun 2021 11:39:37 +0000 (UTC) X-FDA: 78233990394.11.71169DE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id 020DDC00CBC0 for ; Wed, 9 Jun 2021 11:39:32 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1AF66219E7; Wed, 9 Jun 2021 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CLObwQuENcRgoukMvNxRJzoRvFwUKPTdwZDaHjVrHHA=; b=YlGl6sq2LuhXUI56gbtKfae6pZ4AY5ckS09vFiOApOYSgzTheLO36HgdqBhxrpyvLXrv6H xouoMVF2jZrrd2Qj+k4B9VDu3nuRfGAPRnJE+XSP1Wozu8FXIR5jMNUUmTKpLqUlSt+jgv Z/yDLxcN+rOcHGR4MgtzhMN/GThiauA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CLObwQuENcRgoukMvNxRJzoRvFwUKPTdwZDaHjVrHHA=; b=Tf1wjSQaqv/yJ3IoWAa7MJQE8Qp0aY6MDq08lGLOT3kASNsCN2/NXpw1KdzDwsUIYOjxTa N68AarkIwtKZCbAw== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id E01C611A98; Wed, 9 Jun 2021 11:39:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CLObwQuENcRgoukMvNxRJzoRvFwUKPTdwZDaHjVrHHA=; b=YlGl6sq2LuhXUI56gbtKfae6pZ4AY5ckS09vFiOApOYSgzTheLO36HgdqBhxrpyvLXrv6H xouoMVF2jZrrd2Qj+k4B9VDu3nuRfGAPRnJE+XSP1Wozu8FXIR5jMNUUmTKpLqUlSt+jgv Z/yDLxcN+rOcHGR4MgtzhMN/GThiauA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CLObwQuENcRgoukMvNxRJzoRvFwUKPTdwZDaHjVrHHA=; b=Tf1wjSQaqv/yJ3IoWAa7MJQE8Qp0aY6MDq08lGLOT3kASNsCN2/NXpw1KdzDwsUIYOjxTa N68AarkIwtKZCbAw== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id uFI8NneowGD6XgAALh3uQQ (envelope-from ); Wed, 09 Jun 2021 11:39:35 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn , Vlastimil Babka Subject: [RFC v2 23/34] mm, slub: discard slabs in unfreeze_partials() without irqs disabled Date: Wed, 9 Jun 2021 13:38:52 +0200 Message-Id: <20210609113903.1421-24-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609113903.1421-1-vbabka@suse.cz> References: <20210609113903.1421-1-vbabka@suse.cz> MIME-Version: 1.0 Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YlGl6sq2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Tf1wjSQa; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=YlGl6sq2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Tf1wjSQa; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam02 X-Stat-Signature: 5pmauy5n663j3479pmeefn19e95nifix X-Rspamd-Queue-Id: 020DDC00CBC0 X-HE-Tag: 1623238772-979001 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: No need for disabled irqs when discarding slabs, so restore them before discarding. Signed-off-by: Vlastimil Babka --- mm/slub.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 4a3cd8174cd2..dcbc5baea702 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2346,6 +2346,8 @@ static void unfreeze_partials(struct kmem_cache *s, if (n) spin_unlock(&n->list_lock); =20 + local_irq_restore(flags); + while (discard_page) { page =3D discard_page; discard_page =3D discard_page->next; @@ -2355,7 +2357,6 @@ static void unfreeze_partials(struct kmem_cache *s, stat(s, FREE_SLAB); } =20 - local_irq_restore(flags); #endif /* CONFIG_SLUB_CPU_PARTIAL */ } =20 --=20 2.31.1