From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68075C48BD1 for ; Wed, 9 Jun 2021 11:40:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20788613B1 for ; Wed, 9 Jun 2021 11:40:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20788613B1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F9B26B0081; Wed, 9 Jun 2021 07:39:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 15C906B009C; Wed, 9 Jun 2021 07:39:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E788D6B0099; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id A15CF6B0099 for ; Wed, 9 Jun 2021 07:39:38 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4474D81F3 for ; Wed, 9 Jun 2021 11:39:38 +0000 (UTC) X-FDA: 78233990436.03.4383B1C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf16.hostedemail.com (Postfix) with ESMTP id 4B16180192FE for ; Wed, 9 Jun 2021 11:39:34 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E5990219EA; Wed, 9 Jun 2021 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBcrguTXnI9hsctZTgQ7OZG0uV6yh0oH29eLHd7YhOM=; b=S9aDCy8NqeSbElUMJ7WzqpduEvWVpEeZGxboXI4yXCxlIEu7fG1uKF0z9lJHnm7rpwddij n+bVZPPSvlT349WpwhqNFVtX8b//dGxw4IcvqKw8avsziFGZSHgZ6f2LHEqpK7YFhw79LZ Ybbq1xJcy2WHL07mz5xEhmKZbLmb+dc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBcrguTXnI9hsctZTgQ7OZG0uV6yh0oH29eLHd7YhOM=; b=rL6U8d/br+ltLXTLyZtABuUoy7FOyMm0b6uCrM6FmDpyc330LYQnO+vOXlpMJMsavg/6bQ 1wJyokoIUQFb+EDQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id B64C611A98; Wed, 9 Jun 2021 11:39:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBcrguTXnI9hsctZTgQ7OZG0uV6yh0oH29eLHd7YhOM=; b=S9aDCy8NqeSbElUMJ7WzqpduEvWVpEeZGxboXI4yXCxlIEu7fG1uKF0z9lJHnm7rpwddij n+bVZPPSvlT349WpwhqNFVtX8b//dGxw4IcvqKw8avsziFGZSHgZ6f2LHEqpK7YFhw79LZ Ybbq1xJcy2WHL07mz5xEhmKZbLmb+dc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1623238776; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YBcrguTXnI9hsctZTgQ7OZG0uV6yh0oH29eLHd7YhOM=; b=rL6U8d/br+ltLXTLyZtABuUoy7FOyMm0b6uCrM6FmDpyc330LYQnO+vOXlpMJMsavg/6bQ 1wJyokoIUQFb+EDQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id MKT/K3iowGD6XgAALh3uQQ (envelope-from ); Wed, 09 Jun 2021 11:39:36 +0000 From: Vlastimil Babka To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Mel Gorman , Jesper Dangaard Brouer , Peter Zijlstra , Jann Horn , Vlastimil Babka Subject: [RFC v2 27/34] mm, slub: don't disable irqs in slub_cpu_dead() Date: Wed, 9 Jun 2021 13:38:56 +0200 Message-Id: <20210609113903.1421-28-vbabka@suse.cz> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210609113903.1421-1-vbabka@suse.cz> References: <20210609113903.1421-1-vbabka@suse.cz> MIME-Version: 1.0 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B16180192FE X-Stat-Signature: jffotx9qsepffu4gw1b56xebx3chy5my Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=S9aDCy8N; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rL6U8d/b"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=S9aDCy8N; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="rL6U8d/b"; dmarc=none; spf=pass (imf16.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-HE-Tag: 1623238774-795726 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: slub_cpu_dead() cleans up for an offlined cpu from another cpu and calls = only functions that are now irq safe, so we don't need to disable irqs anymore= . Signed-off-by: Vlastimil Babka --- mm/slub.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 5a81189608e6..12d35d6a6eaa 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2498,14 +2498,10 @@ static void flush_all(struct kmem_cache *s) static int slub_cpu_dead(unsigned int cpu) { struct kmem_cache *s; - unsigned long flags; =20 mutex_lock(&slab_mutex); - list_for_each_entry(s, &slab_caches, list) { - local_irq_save(flags); + list_for_each_entry(s, &slab_caches, list) __flush_cpu_slab(s, cpu); - local_irq_restore(flags); - } mutex_unlock(&slab_mutex); return 0; } --=20 2.31.1