From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20E27C47094 for ; Thu, 10 Jun 2021 12:23:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 866CB613BC for ; Thu, 10 Jun 2021 12:23:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 866CB613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07A566B0036; Thu, 10 Jun 2021 08:23:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02B1C6B006E; Thu, 10 Jun 2021 08:23:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE6676B0070; Thu, 10 Jun 2021 08:23:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0248.hostedemail.com [216.40.44.248]) by kanga.kvack.org (Postfix) with ESMTP id B132F6B0036 for ; Thu, 10 Jun 2021 08:23:28 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 527A5180AD81F for ; Thu, 10 Jun 2021 12:23:28 +0000 (UTC) X-FDA: 78237729696.31.7DE350C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 6C8CBA00024C for ; Thu, 10 Jun 2021 12:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623327807; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k3ZsCUUFI0x3gcU4BiStSbLUQmPZdLJKXVyrciTNj1w=; b=Um8nuXS5/ATis/XaB4oVqNDkjtp4sosVKokfk5aVmF8rAm5d9BALScXie+BIAnejlB99Nz 3qt1K2PUYEY8TUvY/AupXn2xsBXYkLRHDWPq5+H6D7+ePmpdTriMLOt1LSnyRNy77Plmsm N/t6HDVOjJ1c99NAxhjrDzfpzddvfZU= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-ncEPfrI6N3-XMNOEOxhQuA-1; Thu, 10 Jun 2021 08:23:26 -0400 X-MC-Unique: ncEPfrI6N3-XMNOEOxhQuA-1 Received: by mail-wr1-f72.google.com with SMTP id x9-20020a5d49090000b0290118d8746e06so820342wrq.10 for ; Thu, 10 Jun 2021 05:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k3ZsCUUFI0x3gcU4BiStSbLUQmPZdLJKXVyrciTNj1w=; b=GMMbWHi4zWJHE4WyGT2OwaUh6fa9+YYTPTVGPdEwrTXZGGWSv5HeUWdjaZyVgkH/jS IxUdrXpqke23Cqi8OZhuGukB0JNpRvCfzNWWrgzd2dBr+PGx1JYO2uu6bXZxY95F3vA8 RHmyXXfA3NjHo6Tt/+nEkJ2XuYCGlo4yBfGtCNx/F5PlgR8Q1Oh7BcXFBag1Wnh3YP9L R+5zr8IOKPU4wkYmbbsJGlsk9TmMicj1okZSY7vBaCV2qmskMLehE+Cex18HcLQKJXBI 5U4/+LSAENh8DmO51gXiKfETDJ/Jm7YhheYPBYZQSvsA+HGEBToWn04hRuB+QPFLg9Nl TtVQ== X-Gm-Message-State: AOAM5330Rr1b+l08Tom68dLLEgVPsRm5e8yVzuK+xiwVYWDSuclCSO77 b7ggsTNg0g9CUONKXYGHh2QfW5lVKuoD8JibXUaDm6SE1BdY14HL6l84N9HnT4BWktLXu4iS/Fd klrQTrR0L6Q== X-Received: by 2002:a1c:98d0:: with SMTP id a199mr14932333wme.22.1623327804934; Thu, 10 Jun 2021 05:23:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLBOWhy739yhKr41MwPncysH3eK0v8XABzjqjEi2LNax5ipEJ+oI8jGaCj5PihtPVu26t8JQ== X-Received: by 2002:a1c:98d0:: with SMTP id a199mr14932315wme.22.1623327804761; Thu, 10 Jun 2021 05:23:24 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id o17sm3206320wrp.47.2021.06.10.05.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 05:23:24 -0700 (PDT) Date: Thu, 10 Jun 2021 13:23:23 +0100 From: Aaron Tomlin To: Michal Hocko Cc: Waiman Long , Shakeel Butt , Linux MM , Andrew Morton , Vlastimil Babka , LKML Subject: Re: [RFC PATCH] mm/oom_kill: allow oom kill allocating task for non-global case Message-ID: <20210610122323.6geriip66jjmdstj@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <6d23ce58-4c4b-116a-6d74-c2cf4947492b@redhat.com> <353d012f-e8d4-c54c-b33e-54737e1a0115@redhat.com> <20210609143534.v65qknfihqimiivd@ava.usersys.com> MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Um8nuXS5; spf=none (imf15.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=atomlin@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 6C8CBA00024C X-Stat-Signature: a5te3ya7sowzf3obzmohzbdf1fsdamip X-HE-Tag: 1623327806-521569 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 2021-06-10 12:00 +0200, Michal Hocko wrote: > If that was the case then the allocating (charging) task would not hit > the oom path at all Yes, you are correct. I was looking at another version of the source code. I does not make sense to consider the OOM code path at all, in this context. The allocating task is selected/or marked as an "OOM vicitm" after SIGKILL is sent (see __oom_kill_process()). > What do you mean by allocating task being unkillable? Please disregard this statement, as per the above. Anyhow, I think we should exclude tasks that have MMF_OOM_SKIP applied in dump_tasks() as it could be misleading. -- Aaron Tomlin