From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Christoph Lameter <cl@linux.com>,
David Rientjes <rientjes@google.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Thomas Gleixner <tglx@linutronix.de>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Jann Horn <jannh@google.com>
Subject: Re: [RFC v2 00/34] SLUB: reduce irq disabled scope and make it RT compatible
Date: Mon, 14 Jun 2021 10:49:02 +0100 [thread overview]
Message-ID: <20210614094902.GF30378@techsingularity.net> (raw)
In-Reply-To: <20210609113903.1421-1-vbabka@suse.cz>
On Wed, Jun 09, 2021 at 01:38:29PM +0200, Vlastimil Babka wrote:
> Changes since RFC v1 [1]:
> * Addressed feedback from Christoph and Mel, added their acks.
> * Finished RT conversion, including adopting 2 patches from the RT tree.
> * The optional local_lock conversion has to sacrifice lockless fathpaths on RT
> * Added some more cleanup patches to the front.
>
> This series was initially inspired by Mel's pcplist local_lock rewrite, and
> also by interest to better understand SLUB's locking and the new locking
> primitives and their RT variants and implications. It should make SLUB more
> preemption-friendly and fully RT compatible, hopefully without noticeable
> regressions on !RT kernels, as the fast paths are not affected there.
>
> Series is based on 5.13-rc5 and also available as a git branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/linux.git/log/?h=slub-local-lock-v2r1
>
This failed to boot for me inside KVM.
[ 0.273576] SRBDS: Unknown: Dependent on hypervisor status
[ 0.273576] MDS: Mitigation: Clear CPU buffers
[ 0.273576] Freeing SMP alternatives memory: 36K
[ 0.273576] bad: scheduling from the idle thread!
[ 0.273576] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.13.0-rc5-unspecified+ #1
[ 0.273576] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
[ 0.273576] Call Trace:
[ 0.273576] dump_stack+0x76/0x94
[ 0.273576] dequeue_task_idle+0x28/0x40
[ 0.273576] __do_set_cpus_allowed+0xe0/0x1a0
[ 0.273576] __schedule+0x7f7/0x8f0
[ 0.273576] __cond_resched+0x22/0x40
[ 0.273576] alloc_vmap_area+0x72/0x8b0
[ 0.273576] ? kmem_cache_alloc_node_trace+0x189/0x300
[ 0.273576] ? __get_vm_area_node+0x76/0x150
[ 0.273576] __get_vm_area_node+0xab/0x150
[ 0.273576] __vmalloc_node_range+0x6d/0x2c0
[ 0.273576] ? kernel_clone+0x9b/0x3e0
[ 0.273576] ? kmem_cache_alloc_node+0x18d/0x2f0
[ 0.273576] ? copy_process+0x218/0x1c40
[ 0.273576] copy_process+0x2c1/0x1c40
[ 0.273576] ? kernel_clone+0x9b/0x3e0
[ 0.273576] ? enqueue_task_fair+0xa1/0x590
[ 0.273576] kernel_clone+0x9b/0x3e0
[ 0.273576] ? acpi_hw_register_read+0x146/0x166
[ 0.273576] kernel_thread+0x55/0x70
[ 0.273576] ? kthread_is_per_cpu+0x30/0x30
[ 0.273576] rest_init+0x75/0xc0
[ 0.273576] start_kernel+0x7fb/0x822
[ 0.273576] secondary_startup_64_no_verify+0xc2/0xcb
[ 0.273576] BUG: kernel NULL pointer dereference, address: 0000000000000000
[ 0.273576] #PF: supervisor instruction fetch in kernel mode
[ 0.273576] #PF: error_code(0x0010) - not-present page
[ 0.273576] PGD 0 P4D 0
[ 0.273576] Oops: 0010 [#1] SMP PTI
[ 0.273576] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.13.0-rc5-unspecified+ #1
[ 0.273576] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
[ 0.273576] RIP: 0010:0x0
[ 0.273576] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
[ 0.273576] RSP: 0000:ffffffffbb803bb0 EFLAGS: 00010002
[ 0.273576] RAX: 0000000000000000 RBX: ffff9fa64ea2ecc0 RCX: ffffffffb9e00101
[ 0.273576] RDX: 000000000000000a RSI: ffffffffbb81a940 RDI: ffff9fa64ea2ecc0
[ 0.273576] RBP: ffffffffbb803c08 R08: 0000000000000000 R09: ffffffffbbaa699c
[ 0.273576] R10: 0000000000000000 R11: ffffffffbb803888 R12: ffffffffbb81a940
[ 0.273576] R13: ffff9f9a80245f40 R14: ffffffffbb1f0060 R15: 0000000000003fff
[ 0.273576] FS: 0000000000000000(0000) GS:ffff9fa64ea00000(0000) knlGS:0000000000000000
[ 0.273576] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.273576] CR2: ffffffffffffffd6 CR3: 0000000a60e10001 CR4: 0000000000170ef0
[ 0.273576] Call Trace:
[ 0.273576] __schedule+0x7f7/0x8f0
[ 0.273576] __cond_resched+0x22/0x40
[ 0.273576] alloc_vmap_area+0x72/0x8b0
[ 0.273576] ? kmem_cache_alloc_node_trace+0x189/0x300
[ 0.273576] ? __get_vm_area_node+0x76/0x150
[ 0.273576] __get_vm_area_node+0xab/0x150
[ 0.273576] __vmalloc_node_range+0x6d/0x2c0
[ 0.273576] ? kernel_clone+0x9b/0x3e0
[ 0.273576] ? kmem_cache_alloc_node+0x18d/0x2f0
[ 0.273576] ? copy_process+0x218/0x1c40
[ 0.273576] copy_process+0x2c1/0x1c40
[ 0.273576] ? kernel_clone+0x9b/0x3e0
[ 0.273576] ? enqueue_task_fair+0xa1/0x590
[ 0.273576] kernel_clone+0x9b/0x3e0
[ 0.273576] ? acpi_hw_register_read+0x146/0x166
[ 0.273576] kernel_thread+0x55/0x70
[ 0.273576] ? kthread_is_per_cpu+0x30/0x30
[ 0.273576] rest_init+0x75/0xc0
[ 0.273576] start_kernel+0x7fb/0x822
[ 0.273576] secondary_startup_64_no_verify+0xc2/0xcb
[ 0.273576] Modules linked in:
[ 0.273576] CR2: 0000000000000000
[ 0.273576] ---[ end trace 7199d6fbb50b4cf7 ]---
[ 0.273576] RIP: 0010:0x0
[ 0.273576] Code: Unable to access opcode bytes at RIP 0xffffffffffffffd6.
[ 0.273576] RSP: 0000:ffffffffbb803bb0 EFLAGS: 00010002
[ 0.273576] RAX: 0000000000000000 RBX: ffff9fa64ea2ecc0 RCX: ffffffffb9e00101
[ 0.273576] RDX: 000000000000000a RSI: ffffffffbb81a940 RDI: ffff9fa64ea2ecc0
[ 0.273576] RBP: ffffffffbb803c08 R08: 0000000000000000 R09: ffffffffbbaa699c
[ 0.273576] R10: 0000000000000000 R11: ffffffffbb803888 R12: ffffffffbb81a940
[ 0.273576] R13: ffff9f9a80245f40 R14: ffffffffbb1f0060 R15: 0000000000003fff
[ 0.273576] FS: 0000000000000000(0000) GS:ffff9fa64ea00000(0000) knlGS:0000000000000000
[ 0.273576] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.273576] CR2: ffffffffffffffd6 CR3: 0000000a60e10001 CR4: 0000000000170ef0
[ 0.273576] Kernel panic - not syncing: Attempted to kill the idle task!
[ 0.273576] Rebooting in 90 seconds..
next prev parent reply other threads:[~2021-06-14 9:49 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:38 [RFC v2 00/34] SLUB: reduce irq disabled scope and make it RT compatible Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 01/34] mm, slub: don't call flush_all() from list_locations() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 02/34] mm, slub: allocate private object map for sysfs listings Vlastimil Babka
2021-06-09 13:29 ` Christoph Lameter
2021-06-09 11:38 ` [RFC v2 03/34] mm, slub: allocate private object map for validate_slab_cache() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 04/34] mm, slub: don't disable irq for debug_check_no_locks_freed() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 05/34] mm, slub: remove redundant unfreeze_partials() from put_cpu_partial() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 06/34] mm, slub: unify cmpxchg_double_slab() and __cmpxchg_double_slab() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 07/34] mm, slub: extract get_partial() from new_slab_objects() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 08/34] mm, slub: dissolve new_slab_objects() into ___slab_alloc() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 09/34] mm, slub: return slab page from get_partial() and set c->page afterwards Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 10/34] mm, slub: restructure new page checks in ___slab_alloc() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 11/34] mm, slub: simplify kmem_cache_cpu and tid setup Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 12/34] mm, slub: move disabling/enabling irqs to ___slab_alloc() Vlastimil Babka
2021-07-06 4:38 ` Mike Galbraith
2021-06-09 11:38 ` [RFC v2 13/34] mm, slub: do initial checks in ___slab_alloc() with irqs enabled Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 14/34] mm, slub: move disabling irqs closer to get_partial() in ___slab_alloc() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 15/34] mm, slub: restore irqs around calling new_slab() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 16/34] mm, slub: validate slab from partial list or page allocator before making it cpu slab Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 17/34] mm, slub: check new pages with restored irqs Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 18/34] mm, slub: stop disabling irqs around get_partial() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 19/34] mm, slub: move reset of c->page and freelist out of deactivate_slab() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 20/34] mm, slub: make locking in deactivate_slab() irq-safe Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 21/34] mm, slub: call deactivate_slab() without disabling irqs Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 22/34] mm, slub: move irq control into unfreeze_partials() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 23/34] mm, slub: discard slabs in unfreeze_partials() without irqs disabled Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 24/34] mm, slub: detach whole partial list at once in unfreeze_partials() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 25/34] mm, slub: detach percpu partial list in unfreeze_partials() using this_cpu_cmpxchg() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 26/34] mm, slub: only disable irq with spin_lock in __unfreeze_partials() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 27/34] mm, slub: don't disable irqs in slub_cpu_dead() Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 28/34] mm, slab: make flush_slab() possible to call with irqs enabled Vlastimil Babka
2021-06-09 11:38 ` [RFC v2 29/34] mm: slub: Move flush_cpu_slab() invocations __free_slab() invocations out of IRQ context Vlastimil Babka
2021-06-09 22:29 ` Cyrill Gorcunov
2021-06-10 8:32 ` Vlastimil Babka
2021-06-10 8:36 ` Cyrill Gorcunov
2021-07-07 6:33 ` Hillf Danton
2021-06-09 11:38 ` [RFC v2 30/34] mm: slub: Make object_map_lock a raw_spinlock_t Vlastimil Babka
2021-06-09 11:39 ` [RFC v2 31/34] mm, slub: optionally save/restore irqs in slab_[un]lock()/ Vlastimil Babka
2021-07-02 12:17 ` Sebastian Andrzej Siewior
2021-06-09 11:39 ` [RFC v2 32/34] mm, slub: make slab_lock() disable irqs with PREEMPT_RT Vlastimil Babka
2021-06-09 11:39 ` [RFC v2 33/34] mm, slub: use migrate_disable() on PREEMPT_RT Vlastimil Babka
2021-06-14 11:07 ` Vlastimil Babka
2021-06-14 11:16 ` Sebastian Andrzej Siewior
2021-06-14 11:33 ` Vlastimil Babka
2021-06-14 12:54 ` Vlastimil Babka
2021-06-14 14:01 ` Sebastian Andrzej Siewior
2021-06-09 11:39 ` [RFC v2 34/34] mm, slub: convert kmem_cpu_slab protection to local_lock Vlastimil Babka
2021-06-14 9:49 ` Mel Gorman [this message]
2021-06-14 11:31 ` [RFC v2 00/34] SLUB: reduce irq disabled scope and make it RT compatible Mel Gorman
2021-06-14 11:10 ` Vlastimil Babka
2021-07-02 18:29 ` Sebastian Andrzej Siewior
2021-07-02 20:25 ` Vlastimil Babka
2021-07-29 13:49 ` Sebastian Andrzej Siewior
2021-07-29 14:17 ` Vlastimil Babka
2021-07-29 14:37 ` Sebastian Andrzej Siewior
2021-07-03 7:24 ` Mike Galbraith
2021-07-03 15:47 ` Mike Galbraith
2021-07-04 5:37 ` Mike Galbraith
2021-07-18 7:41 ` Vlastimil Babka
2021-07-18 8:29 ` Mike Galbraith
2021-07-18 12:09 ` Mike Galbraith
2021-07-05 16:00 ` Mike Galbraith
2021-07-06 17:56 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614094902.GF30378@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=bigeasy@linutronix.de \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).