From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9691BC2B9F4 for ; Wed, 23 Jun 2021 00:34:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4435560249 for ; Wed, 23 Jun 2021 00:34:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4435560249 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3CC056B0073; Tue, 22 Jun 2021 20:34:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37C4E6B0074; Tue, 22 Jun 2021 20:34:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F5EB6B0075; Tue, 22 Jun 2021 20:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id DA6116B0073 for ; Tue, 22 Jun 2021 20:34:21 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 231A520BD0 for ; Wed, 23 Jun 2021 00:34:22 +0000 (UTC) X-FDA: 78283117164.32.BE8C5CE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id BE96A400038B for ; Wed, 23 Jun 2021 00:34:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624408461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1HOBThsKFMdy6maQ0G0S3zSGdTuN0SvYRkinZMACScw=; b=HtL/VUEj8g5rlXDzxZ5nEukZCYq6aDZCe5jUfpgY+WD0QWm5xIw/rOV3i0zcfq8ixwl+eg 7xUtXVQzX9iUv3vsgiLAkpPOki9Dqr4YDahg6/SMDNO9Pt4njyY56+/mSn8h7h/DI462pe 3z3ZX0UOQgvqLn7LDyBZnc++rpFHbok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-5PnlMUC6Pk6LK6l-7iXPMA-1; Tue, 22 Jun 2021 20:34:18 -0400 X-MC-Unique: 5PnlMUC6Pk6LK6l-7iXPMA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B6853801B0F; Wed, 23 Jun 2021 00:34:16 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-84.bne.redhat.com [10.64.54.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id B15E51007623; Wed, 23 Jun 2021 00:34:13 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: alexander.duyck@gmail.com, david@redhat.com, mst@redhat.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, shan.gavin@gmail.com Subject: [PATCH v3 2/4] mm/page_reporting: Export reporting order as module parameter Date: Wed, 23 Jun 2021 10:34:16 +0800 Message-Id: <20210623023418.350616-3-gshan@redhat.com> In-Reply-To: <20210623023418.350616-1-gshan@redhat.com> References: <20210623023418.350616-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="HtL/VUEj"; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=gshan@redhat.com X-Stat-Signature: btrugyrje4qfu51tr4u8ow6p5nr7inpc X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BE96A400038B X-HE-Tag: 1624408461-266321 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The macro PAGE_REPORTING_MIN_ORDER is defined as the page reporting threshold. It can't be adjusted at runtime. This introduces a variable (@page_reporting_order) to replace the marcro (PAGE_REPORTING_MIN_ORDER). It's also exported so that the page reporting order can be adjusted at runtime. Suggested-by: David Hildenbrand Signed-off-by: Gavin Shan --- Documentation/admin-guide/kernel-parameters.txt | 6 ++++++ mm/page_reporting.c | 8 ++++++-- mm/page_reporting.h | 5 ++--- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentat= ion/admin-guide/kernel-parameters.txt index cb89dbdedc46..566c4b9af3cd 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -3566,6 +3566,12 @@ off: turn off poisoning (default) on: turn on poisoning =20 + page_reporting.page_reporting_order=3D + [KNL] Minimal page reporting order + Format: + Adjust the minimal page reporting order. The page + reporting is disabled when it exceeds (MAX_ORDER-1). + panic=3D [KNL] Kernel behaviour on panic: delay timeout > 0: seconds before rebooting timeout =3D 0: wait forever diff --git a/mm/page_reporting.c b/mm/page_reporting.c index df9c5054e1b4..293a8713ef7c 100644 --- a/mm/page_reporting.c +++ b/mm/page_reporting.c @@ -10,6 +10,10 @@ #include "page_reporting.h" #include "internal.h" =20 +unsigned int page_reporting_order =3D pageblock_order; +module_param(page_reporting_order, uint, 0644); +MODULE_PARM_DESC(page_reporting_order, "Set page reporting order"); + #define PAGE_REPORTING_DELAY (2 * HZ) static struct page_reporting_dev_info __rcu *pr_dev_info __read_mostly; =20 @@ -229,7 +233,7 @@ page_reporting_process_zone(struct page_reporting_dev= _info *prdev, =20 /* Generate minimum watermark to be able to guarantee progress */ watermark =3D low_wmark_pages(zone) + - (PAGE_REPORTING_CAPACITY << PAGE_REPORTING_MIN_ORDER); + (PAGE_REPORTING_CAPACITY << page_reporting_order); =20 /* * Cancel request if insufficient free memory or if we failed @@ -239,7 +243,7 @@ page_reporting_process_zone(struct page_reporting_dev= _info *prdev, return err; =20 /* Process each free list starting from lowest order/mt */ - for (order =3D PAGE_REPORTING_MIN_ORDER; order < MAX_ORDER; order++) { + for (order =3D page_reporting_order; order < MAX_ORDER; order++) { for (mt =3D 0; mt < MIGRATE_TYPES; mt++) { /* We do not pull pages from the isolate free list */ if (is_migrate_isolate(mt)) diff --git a/mm/page_reporting.h b/mm/page_reporting.h index 2c385dd4ddbd..c51dbc228b94 100644 --- a/mm/page_reporting.h +++ b/mm/page_reporting.h @@ -10,10 +10,9 @@ #include #include =20 -#define PAGE_REPORTING_MIN_ORDER pageblock_order - #ifdef CONFIG_PAGE_REPORTING DECLARE_STATIC_KEY_FALSE(page_reporting_enabled); +extern unsigned int page_reporting_order; void __page_reporting_notify(void); =20 static inline bool page_reported(struct page *page) @@ -38,7 +37,7 @@ static inline void page_reporting_notify_free(unsigned = int order) return; =20 /* Determine if we have crossed reporting threshold */ - if (order < PAGE_REPORTING_MIN_ORDER) + if (order < page_reporting_order) return; =20 /* This will add a few cycles, but should be called infrequently */ --=20 2.23.0