* [PATCH v3] slab: Use __func__ to trace function name
@ 2021-06-22 9:59 gumingtao
2021-06-22 9:59 ` gumingtao
0 siblings, 1 reply; 5+ messages in thread
From: gumingtao @ 2021-06-22 9:59 UTC (permalink / raw)
To: cl
Cc: penberg, rientjes, iamjoonsoo.kim, akpm, vbabka, nathan,
ndesaulniers, linux-mm, linux-kernel, clang-built-linux,
gumingtao
Changes in v3
- edit comment and the subject
Changes in v2
- use %s replace function name for the panic() call
- use %s replace function name:kmem_cache_destroy
gumingtao (1):
slab: Use __func__ to trace function name
mm/slab_common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v3] slab: Use __func__ to trace function name
2021-06-22 9:59 [PATCH v3] slab: Use __func__ to trace function name gumingtao
@ 2021-06-22 9:59 ` gumingtao
2021-06-22 11:55 ` Christoph Lameter
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: gumingtao @ 2021-06-22 9:59 UTC (permalink / raw)
To: cl
Cc: penberg, rientjes, iamjoonsoo.kim, akpm, vbabka, nathan,
ndesaulniers, linux-mm, linux-kernel, clang-built-linux,
gumingtao
It is better to use __func__ to trace function name.
Signed-off-by: gumingtao <gumingtao@xiaomi.com>
---
mm/slab_common.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/mm/slab_common.c b/mm/slab_common.c
index a4a5714..ffa3b11 100644
--- a/mm/slab_common.c
+++ b/mm/slab_common.c
@@ -378,11 +378,11 @@ kmem_cache_create_usercopy(const char *name,
if (err) {
if (flags & SLAB_PANIC)
- panic("kmem_cache_create: Failed to create slab '%s'. Error %d\n",
- name, err);
+ panic("%s: Failed to create slab '%s'. Error %d\n",
+ __func__, name, err);
else {
- pr_warn("kmem_cache_create(%s) failed with error %d\n",
- name, err);
+ pr_warn("%s(%s) failed with error %d\n",
+ __func__, name, err);
dump_stack();
}
return NULL;
@@ -509,8 +509,8 @@ void kmem_cache_destroy(struct kmem_cache *s)
err = shutdown_cache(s);
if (err) {
- pr_err("kmem_cache_destroy %s: Slab cache still has objects\n",
- s->name);
+ pr_err("%s %s: Slab cache still has objects\n",
+ __func__, s->name);
dump_stack();
}
out_unlock:
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] slab: Use __func__ to trace function name
2021-06-22 9:59 ` gumingtao
@ 2021-06-22 11:55 ` Christoph Lameter
2021-06-22 23:48 ` David Rientjes
2021-06-23 8:17 ` Aaron Tomlin
2 siblings, 0 replies; 5+ messages in thread
From: Christoph Lameter @ 2021-06-22 11:55 UTC (permalink / raw)
To: gumingtao
Cc: penberg, rientjes, iamjoonsoo.kim, akpm, vbabka, nathan,
ndesaulniers, linux-mm, linux-kernel, clang-built-linux,
gumingtao
On Tue, 22 Jun 2021, gumingtao wrote:
> It is better to use __func__ to trace function name.
Acked-by: Christoph Lameter <cl@linux.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] slab: Use __func__ to trace function name
2021-06-22 9:59 ` gumingtao
2021-06-22 11:55 ` Christoph Lameter
@ 2021-06-22 23:48 ` David Rientjes
2021-06-23 8:17 ` Aaron Tomlin
2 siblings, 0 replies; 5+ messages in thread
From: David Rientjes @ 2021-06-22 23:48 UTC (permalink / raw)
To: gumingtao
Cc: cl, penberg, iamjoonsoo.kim, akpm, vbabka, nathan, ndesaulniers,
linux-mm, linux-kernel, clang-built-linux, gumingtao
On Tue, 22 Jun 2021, gumingtao wrote:
> It is better to use __func__ to trace function name.
>
> Signed-off-by: gumingtao <gumingtao@xiaomi.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] slab: Use __func__ to trace function name
2021-06-22 9:59 ` gumingtao
2021-06-22 11:55 ` Christoph Lameter
2021-06-22 23:48 ` David Rientjes
@ 2021-06-23 8:17 ` Aaron Tomlin
2 siblings, 0 replies; 5+ messages in thread
From: Aaron Tomlin @ 2021-06-23 8:17 UTC (permalink / raw)
To: gumingtao
Cc: cl, penberg, rientjes, iamjoonsoo.kim, akpm, vbabka, nathan,
ndesaulniers, linux-mm, linux-kernel, clang-built-linux,
gumingtao
On Tue 2021-06-22 17:59 +0800, gumingtao wrote:
> It is better to use __func__ to trace function name.
>
> Signed-off-by: gumingtao <gumingtao@xiaomi.com>
> ---
> mm/slab_common.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Aaron Tomlin <atomlin@redhat.com>
--
Aaron Tomlin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-23 8:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 9:59 [PATCH v3] slab: Use __func__ to trace function name gumingtao
2021-06-22 9:59 ` gumingtao
2021-06-22 11:55 ` Christoph Lameter
2021-06-22 23:48 ` David Rientjes
2021-06-23 8:17 ` Aaron Tomlin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).