From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA396C2B9F4 for ; Mon, 28 Jun 2021 12:38:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5265C61993 for ; Mon, 28 Jun 2021 12:38:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5265C61993 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 730AA8D0033; Mon, 28 Jun 2021 08:38:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 707878D0031; Mon, 28 Jun 2021 08:38:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A83D8D0033; Mon, 28 Jun 2021 08:38:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 27D6C8D0031 for ; Mon, 28 Jun 2021 08:38:52 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1572E181AEF09 for ; Mon, 28 Jun 2021 12:38:52 +0000 (UTC) X-FDA: 78303086904.26.A139EDD Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by imf03.hostedemail.com (Postfix) with ESMTP id B46F9C0201FA for ; Mon, 28 Jun 2021 12:38:51 +0000 (UTC) Received: by mail-lj1-f172.google.com with SMTP id w11so4881677ljh.0 for ; Mon, 28 Jun 2021 05:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ys+RScaibz83CdiYBfay2IdZEjpEuB17QTSkYmwaWUw=; b=oH+4Cd/L51GezleCLUVkNCwz00KpyQZLsFM8Dl22yq0fIQhWNX5J3Gaz4QWyCCbQeA qcyAC4DHJ4/vSwIRQAwct+gFD07lvNc1tOOzcDONALQNDERMomkjayzcfluYfVJba80b 1hn1f6PLn44tKpjdge/JHmgk4FedVMlGKk408/z6oCgs8bNiWBdJ/t29WbOeY1DWF2G+ 9mWFTW5reZhs+QT16JwZmxGtNIjz+1RSfAd8qygPBcylen7Lj3IHYnZG/qN+xkRNoAr7 +S5ExmnO2FQRqfrDi1T6/+oGuqIxYIJG5QxVKDHnjRNQy/HwMpCNNZyLXMjB8fHIRu1Z jlvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ys+RScaibz83CdiYBfay2IdZEjpEuB17QTSkYmwaWUw=; b=fHCmUTS0iA0SBX7j37bkqar0rDV5YhIClaPiJqxtQyF0vIWH7teXfqhMEBc5cuyPnd lrz2p8UspiYwbnKzpbsfroKWsdrtrcbayZmrpVaAg0Uz/OjbdD+RRK3HZBtUb4mpabEV xboKY8fNk7UYfYjHfVdQl4G2x7wprtGnHswKT2aADOOflRmCOV+RHnkjuA8GluCWDZ85 ZRTQm8zbuwC/DfklX1HNcXvR63e68p+ItoOM2KhDUmRQCUHQfVKIOk5oxWmKM8BXOSze 7xa5UkqHKtkN/E6RjNDqj48n3ep7ooPixpgBJSZaBDuIVqKE1cyEcPoR8IoJTMVZN8W1 y80w== X-Gm-Message-State: AOAM5316yOpTfVFZxnP/Ann6OytN8USqmcVPayiiz3mVySUkkvQ+uQTD vKUqAPVuoT8vcq6E+JPvp/e5eg== X-Google-Smtp-Source: ABdhPJw1VYNm/iuQ8ukJtHgbIPL5tc+jj79qOV9v8hvkVcmikl3nLf5EGnU9qwjyyAShj0CTY0m/ww== X-Received: by 2002:a2e:b1d3:: with SMTP id e19mr3906687lja.362.1624883930421; Mon, 28 Jun 2021 05:38:50 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id b15sm1022167lfj.28.2021.06.28.05.38.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:38:49 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 1982410280E; Mon, 28 Jun 2021 15:38:49 +0300 (+03) Date: Mon, 28 Jun 2021 15:38:49 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig Subject: Re: [PATCH v12 09/33] mm: Add folio_try_get_rcu() Message-ID: <20210628123849.4gok3kf43wyjp2ix@box.shutemov.name> References: <20210622114118.3388190-1-willy@infradead.org> <20210622114118.3388190-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622114118.3388190-10-willy@infradead.org> Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b="oH+4Cd/L"; dmarc=none; spf=none (imf03.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.172) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: nd14gq4rqe44j3wz19gybkrzzfyh4pay X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B46F9C0201FA X-HE-Tag: 1624883931-754924 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 12:40:54PM +0100, Matthew Wilcox (Oracle) wrote: > This is the equivalent of page_cache_get_speculative(). Also add > folio_ref_try_add_rcu (the equivalent of page_cache_add_speculative) > and folio_get_unless_zero() (the equivalent of get_page_unless_zero()). > > The new kernel-doc attempts to explain from the user's point of view > when to use folio_try_get_rcu() and when to use folio_get_unless_zero(), > because there seems to be some confusion currently between the users of > page_cache_get_speculative() and get_page_unless_zero(). > > Reimplement page_cache_add_speculative() and page_cache_get_speculative() > as wrappers around the folio equivalents, but leave get_page_unless_zero() > alone for now. This commit reduces text size by 3 bytes due to slightly > different register allocation & instruction selections. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov