From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7754CC2B9F4 for ; Mon, 28 Jun 2021 12:46:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0AB9761C43 for ; Mon, 28 Jun 2021 12:46:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AB9761C43 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 504858D0036; Mon, 28 Jun 2021 08:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DB398D0035; Mon, 28 Jun 2021 08:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37D1C8D0036; Mon, 28 Jun 2021 08:46:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0084.hostedemail.com [216.40.44.84]) by kanga.kvack.org (Postfix) with ESMTP id 0713F8D0035 for ; Mon, 28 Jun 2021 08:46:36 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D710E1EA39 for ; Mon, 28 Jun 2021 12:46:36 +0000 (UTC) X-FDA: 78303106392.06.7D9CBDF Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf21.hostedemail.com (Postfix) with ESMTP id 97B00E00024C for ; Mon, 28 Jun 2021 12:46:36 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id a15so24576004lfr.6 for ; Mon, 28 Jun 2021 05:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=bE94dkEiagNN+9+kFZlZw382SA94vUnxjwE0fje0Xk0=; b=Ht6Gea2SfQjaOGwZUSX+vM/eLTPlMEdb/841pVZfh+X68ssJ1KJDHcIP4x+pWOYZPj t507EHUiwc06CyBU/9L/T/wwPHRyOJKOMbq7acJb03LCk6Fu7c98WPFUiyYL9dcjes/O kR7VdZUEuquwEjystBKf8BJr/j1YtBuj4S+DbiOcsrqJiOyonmBQL03PDuKJzgzMjZnx sRjoeMZxy0tu9vK291N7BDHMWi/7Mxlw1wjnOaIUg41nDmWg7TZaPL/7OZf24MSsdWKm OUo1EtZQKY2OcT5a6oEKfexbrIFtzp5kIUpdQOQ04a+MWXtGOya3iCUPJ40pkYBjfhaV IwAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bE94dkEiagNN+9+kFZlZw382SA94vUnxjwE0fje0Xk0=; b=oqUkx9YjKqQqKETSv1TA0mFMjaLX/ZMll9WMzsTP446lH56NRBTyTyjHphHQJEMetu q+s5M9ydOw0uhkSuscrORaXO92zLrcBfzDY/Ven9ZltYgqvpzxOFDY23xVgIjxMLimyV 8JQdZ+VbDQfrtNCA9xxWP2zoiI2hgqcq9Ysqjhl5hOzhFr4HLRCBVQmp/tayQ5EyUZU6 1009L3vxC/y7GqL6LPSi2TdcaijT/MboJbzWHu7RGKpMdknDuhNe2fneGp9DiMUlEpPt OmUxCHxrSvaIqHcciTRfyPQ8oU4aJnJ0FnSb/zSkwozKMPafurlWIo0HaihEgz3llhnD BXMg== X-Gm-Message-State: AOAM531Oh5wWxCrq95buCmOqAc4tnaAENiEgq0MB8a+xklzJb2OwYUID 58vAlymyn5A6L81WGzYc1vezTw== X-Google-Smtp-Source: ABdhPJx3x4IfClwhHCvXuiTmI3sq3nF9lEkNhcJjaCr83013VKYnGJ8cEjohV6J5iX9lASPr1gWtVA== X-Received: by 2002:a05:6512:138a:: with SMTP id p10mr18835229lfa.505.1624884395244; Mon, 28 Jun 2021 05:46:35 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q23sm1219833lfe.170.2021.06.28.05.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Jun 2021 05:46:34 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id E241710280E; Mon, 28 Jun 2021 15:46:33 +0300 (+03) Date: Mon, 28 Jun 2021 15:46:33 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig Subject: Re: [PATCH v12 24/33] mm/swap: Add folio_rotate_reclaimable() Message-ID: <20210628124633.vlckysu3zvvkyy4v@box.shutemov.name> References: <20210622114118.3388190-1-willy@infradead.org> <20210622114118.3388190-25-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210622114118.3388190-25-willy@infradead.org> Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=Ht6Gea2S; dmarc=none; spf=none (imf21.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.54) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: ogb93r43whhh64yaq59x361ia665ge9z X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 97B00E00024C X-HE-Tag: 1624884396-391979 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 22, 2021 at 12:41:09PM +0100, Matthew Wilcox (Oracle) wrote: > Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This > eliminates all five of the calls to compound_head() in this function, > saving 75 bytes at the cost of adding 15 bytes to its one caller, > end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn() > due to using folios there. Net 96 bytes savings. > > Also move its declaration to mm/internal.h as it's only used by filemap.c. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov