From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB6A5C11F69 for ; Thu, 1 Jul 2021 01:56:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AD21861480 for ; Thu, 1 Jul 2021 01:56:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD21861480 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 37ADB8D0281; Wed, 30 Jun 2021 21:56:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 329488D0279; Wed, 30 Jun 2021 21:56:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CAC98D0281; Wed, 30 Jun 2021 21:56:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id ED3A48D0279 for ; Wed, 30 Jun 2021 21:56:47 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C5B9E256E1 for ; Thu, 1 Jul 2021 01:56:47 +0000 (UTC) X-FDA: 78312355254.22.04ED708 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf18.hostedemail.com (Postfix) with ESMTP id 89AB7400208A for ; Thu, 1 Jul 2021 01:56:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AA6E86147E; Thu, 1 Jul 2021 01:56:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1625104606; bh=+PhBcqb+MsvVrRS+Aj75Y1qdvvqJBHiUbaDUyHX3OPA=; h=Date:From:To:Subject:In-Reply-To:From; b=eC5NDlbU085RVBmPJyVSJBAD3yWQOfm6umfP4sJPjTT5/6KVoPLAJ9gPn5+QbXmGj X0Vwe+wr2UIOPMWC6D+MMoj/FHt/BCPjpDk62czvUNVBVPkf82r/WRw2Nw69wtUN9B zi0VmmTN5dGHcygTUoraOJm0wxPhgHwQoake45o4= Date: Wed, 30 Jun 2021 18:56:46 -0700 From: Andrew Morton To: adobriyan@gmail.com, akpm@linux-foundation.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: [patch 182/192] exec: remove checks in __register_bimfmt() Message-ID: <20210701015646.oDCgWS-8y%akpm@linux-foundation.org> In-Reply-To: <20210630184624.9ca1937310b0dd5ce66b30e7@linux-foundation.org> User-Agent: s-nail v14.8.16 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eC5NDlbU; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Stat-Signature: sd3q6rwbyscia5k1mwge1um7nm1kfjm5 X-Rspamd-Queue-Id: 89AB7400208A X-Rspamd-Server: rspam06 X-HE-Tag: 1625104607-222808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Alexey Dobriyan Subject: exec: remove checks in __register_bimfmt() Delete NULL check, all callers pass valid pointer. Delete ->load_binary check -- failure to provide hook in a custom module will be very noticeable at the very first execve call. Link: https://lkml.kernel.org/r/YK1Gy1qXaLAR+tPl@localhost.localdomain Signed-off-by: Alexey Dobriyan Signed-off-by: Andrew Morton --- fs/exec.c | 3 --- 1 file changed, 3 deletions(-) --- a/fs/exec.c~exec-remove-checks-in-__register_bimfmt +++ a/fs/exec.c @@ -84,9 +84,6 @@ static DEFINE_RWLOCK(binfmt_lock); void __register_binfmt(struct linux_binfmt * fmt, int insert) { - BUG_ON(!fmt); - if (WARN_ON(!fmt->load_binary)) - return; write_lock(&binfmt_lock); insert ? list_add(&fmt->lh, &formats) : list_add_tail(&fmt->lh, &formats); _