From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 476D9C11F69 for ; Fri, 2 Jul 2021 15:37:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A223361423 for ; Fri, 2 Jul 2021 15:37:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A223361423 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 216D46B0011; Fri, 2 Jul 2021 11:37:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6D76B0036; Fri, 2 Jul 2021 11:37:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0689B6B005D; Fri, 2 Jul 2021 11:37:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id D83F66B0011 for ; Fri, 2 Jul 2021 11:37:06 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 82D9C8249980 for ; Fri, 2 Jul 2021 15:37:06 +0000 (UTC) X-FDA: 78318051252.26.932420F Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf18.hostedemail.com (Postfix) with ESMTP id 323F4400208B for ; Fri, 2 Jul 2021 15:37:06 +0000 (UTC) Received: by mail-oi1-f169.google.com with SMTP id w127so11697612oig.12 for ; Fri, 02 Jul 2021 08:37:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+VLKFncvgU6I1zgdctbWizUUnNNV82ncEScl2ekh8C0=; b=DYuviw9iG4YJ+xWixQweYfCi/rW5IAzECKr7dB/DnkPEbN/j9ny5fqnZXB7rRB8zlJ fBkmyT/9N2vVPk3vX1m8I9ltaBzUrf46jdERR0KDEmkYkyNsTdbGjtji3zNiazCDi7ue DP3fQT9ysol6mE6GHDAJ1QiEwTjhKZ7s6mpYv5/gM9JcC5M96J7FRyP5+uJ3X/fP06ip ToWqX6AItsB6qYJzRLgX4iiS3XBGG+1/NGltOFp/tbyhvT0I2fCulC6wzXdHsLSN7Mhx U/IeHC11oaobD2DnGKcROyXiyMp0Ywrj5eObK+hS/CZDAnxd17poTyiaGfnTCG/PJDoq GPVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=+VLKFncvgU6I1zgdctbWizUUnNNV82ncEScl2ekh8C0=; b=nxAqIua2v3Y3VCRhpmMcsnOLmU1oRTvMGr5WfGrt26D+nNpkew7nOxApnrQgmQmznJ vgzGAA8RL6LiInLRR6vCHOddXqSPbWY6m5E12naPxJnVVtkbFP9EdhJQMOFXEJkciARV KeHZphsJy1B7LYAGriqgMffoUfSJl9q32UV/cY4kr1MZ5vnH2062z5qYzUD6KfMTgUXY OySd5KFqVz3onIW+M5hCmKG2owb23FaM1Ux7qsx9xRCj92Waqcf0zKvuUL/SCmpBCMsd SLtmzkUZIzS0msas0G8d+OsDJtR66mpdyhvrtImxbTloGr/bk7alS97ZQyC9ddFw4uhG k8rw== X-Gm-Message-State: AOAM531QAbTGnl0MV2XWd1hURQvn/1E5F0uGFH9Kum0AVN/kWE17RGRi AqFEuImLp97/byU3eBJJIhI= X-Google-Smtp-Source: ABdhPJypqSof/EyO4ABSDHoUYJ6ylT3iZ7ACmzehgDQFsWsIh+nviM/IAfBREkvr81dJ9OZXyhuMbA== X-Received: by 2002:a05:6808:68d:: with SMTP id k13mr139435oig.83.1625240225452; Fri, 02 Jul 2021 08:37:05 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id c4sm683427ots.15.2021.07.02.08.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Jul 2021 08:37:04 -0700 (PDT) Date: Fri, 2 Jul 2021 08:37:03 -0700 From: Guenter Roeck To: glittao@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects Message-ID: <20210702153703.GA3074165@roeck-us.net> References: <20210414163434.4376-1-glittao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 323F4400208B X-Stat-Signature: mhopzg7u7krx3wb7j8x61rziifnq1wmz Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=DYuviw9i; dmarc=none; spf=pass (imf18.hostedemail.com: domain of groeck7@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=groeck7@gmail.com X-HE-Tag: 1625240226-580670 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Wed, Apr 14, 2021 at 06:34:34PM +0200, glittao@gmail.com wrote: > From: Oliver Glitta > > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. > > Signed-off-by: Oliver Glitta With arcv2:allnoconfig, this patch results in: Building arcv2:allnoconfig ... failed -------------- Error log: arc-elf-ld: lib/stackdepot.o: in function `filter_irq_stacks': stackdepot.c:(.text+0x43a): undefined reference to `__irqentry_text_start' arc-elf-ld: stackdepot.c:(.text+0x43a): undefined reference to `__irqentry_text_start' arc-elf-ld: stackdepot.c:(.text+0x45a): undefined reference to `__irqentry_text_end' arc-elf-ld: stackdepot.c:(.text+0x45a): undefined reference to `__irqentry_text_end' arc-elf-ld: stackdepot.c:(.text+0x468): undefined reference to `__softirqentry_text_start' arc-elf-ld: stackdepot.c:(.text+0x468): undefined reference to `__softirqentry_text_start' arc-elf-ld: stackdepot.c:(.text+0x470): undefined reference to `__softirqentry_text_end' arc-elf-ld: stackdepot.c:(.text+0x470): undefined reference to `__softirqentry_text_end' Guenter --- # bad: [fb0ca446157a86b75502c1636b0d81e642fe6bf1] Add linux-next specific files for 20210701 # good: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 git bisect start 'HEAD' 'v5.13' # good: [f63c4fda987a19b1194cc45cb72fd5bf968d9d90] Merge remote-tracking branch 'rdma/for-next' git bisect good f63c4fda987a19b1194cc45cb72fd5bf968d9d90 # good: [49c8769be0b910d4134eba07cae5d9c71b861c4a] Merge remote-tracking branch 'drm/drm-next' git bisect good 49c8769be0b910d4134eba07cae5d9c71b861c4a # good: [3b858fe26f206d3c65adfc06c4db473e2dcaacd2] Merge remote-tracking branch 'char-misc/char-misc-next' git bisect good 3b858fe26f206d3c65adfc06c4db473e2dcaacd2 # good: [b7289b49bb2edbe261f3f9a554f02996a4d12c11] Merge remote-tracking branch 'cgroup/for-next' git bisect good b7289b49bb2edbe261f3f9a554f02996a4d12c11 # good: [20bf25c2b863e97a2724092c234e1ce892f83e5c] Merge remote-tracking branch 'pwm/for-next' git bisect good 20bf25c2b863e97a2724092c234e1ce892f83e5c # good: [1446f64f402a42c74c60df7f255df666fe302412] linux-next-pre git bisect good 1446f64f402a42c74c60df7f255df666fe302412 # good: [312d598a2ea9e0927c3ec1decf24d4f3693e06f1] Merge remote-tracking branch 'mhi/mhi-next' git bisect good 312d598a2ea9e0927c3ec1decf24d4f3693e06f1 # good: [d266180aa2811c7b6a8cf3c44e40a8f02a543a23] Merge remote-tracking branch 'cxl/next' git bisect good d266180aa2811c7b6a8cf3c44e40a8f02a543a23 # bad: [8cf245ab25c7db5c10e7f63dcff2ccf09ade5880] sh: convert to setup_initial_init_mm() git bisect bad 8cf245ab25c7db5c10e7f63dcff2ccf09ade5880 # bad: [125069500be687630bcfe6daa80f5408912fc3ef] mm-introduce-memfd_secret-system-call-to-create-secret-memory-areas-fix git bisect bad 125069500be687630bcfe6daa80f5408912fc3ef # good: [c6c08f08ff06799b2c84e2a6a6258537a323d584] hexagon: use common DISCARDS macro git bisect good c6c08f08ff06799b2c84e2a6a6258537a323d584 # bad: [e50e7ac989f6c658fd7b28b14274ae230825b1f9] mm/slub: use stackdepot to save stack trace in objects-fix git bisect bad e50e7ac989f6c658fd7b28b14274ae230825b1f9 # bad: [d1be1dcc08d3ba68331dd47cfdea155f016c79db] mm/slub: use stackdepot to save stack trace in objects git bisect bad d1be1dcc08d3ba68331dd47cfdea155f016c79db # good: [8bf985a45ac528b6bcfbbdec4c3c263240b34264] hexagon: select ARCH_WANT_LD_ORPHAN_WARN git bisect good 8bf985a45ac528b6bcfbbdec4c3c263240b34264 # first bad commit: [d1be1dcc08d3ba68331dd47cfdea155f016c79db] mm/slub: use stackdepot to save stack trace in objects