From: Mel Gorman <mgorman@techsingularity.net>
To: Yang Huan <link@vivo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel@vivo.com, Uladzislau Rezki <urezki@gmail.com>
Subject: Re: [PATCH] mm/vmalloc: try alloc_pages_bulk first to get order 0 pages fast
Date: Fri, 9 Jul 2021 10:38:52 +0100 [thread overview]
Message-ID: <20210709093852.GY3840@techsingularity.net> (raw)
In-Reply-To: <20210709092831.10602-1-link@vivo.com>
On Fri, Jul 09, 2021 at 05:28:31PM +0800, Yang Huan wrote:
> Vmalloc may offen get pages by loop invoke alloc_pags, this is
> cost too much time in count watermark/cpuset or something.
> Let's just try alloc by alloc_pages_bulk, if failed, fullback in
> original path.
>
> With my own test, simulate loop alloc_page and alloc_pages_bulk_array,
> get this:
> size 1M 10M 20M 30
> normal 44 1278 3665 5581
> test 34 889 2167 3300
> optimize 22% 30% 40% 40%
> And in my vmalloc top sort, zram/f2fs may alloc more than 20MB, so,
> It's worth to use alloc_pages_bulk.
>
> Signed-off-by: Yang Huan <link@vivo.com>
Thanks. I suggest you take a look at the current merge window and check
if anything additional needs to be done after the vmalloc bulk allocation
by Uladzislau Rezki.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2021-07-09 9:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 9:28 [PATCH] mm/vmalloc: try alloc_pages_bulk first to get order 0 pages fast Yang Huan
2021-07-09 9:38 ` Mel Gorman [this message]
2021-07-09 9:53 ` 杨欢
2021-07-09 22:29 ` Andrew Morton
2021-07-12 2:51 ` 杨欢
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210709093852.GY3840@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=kernel@vivo.com \
--cc=link@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).