From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D3AC07E9B for ; Sat, 10 Jul 2021 10:03:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AE2E0611ED for ; Sat, 10 Jul 2021 10:03:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE2E0611ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 395F86B0080; Sat, 10 Jul 2021 06:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36C9E6B0082; Sat, 10 Jul 2021 06:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 197FB6B0081; Sat, 10 Jul 2021 06:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id E09B56B0080 for ; Sat, 10 Jul 2021 06:03:25 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2B839809A8BC for ; Sat, 10 Jul 2021 10:03:25 +0000 (UTC) X-FDA: 78346240770.35.F5B218F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf11.hostedemail.com (Postfix) with ESMTP id 9D25CF000F08 for ; Sat, 10 Jul 2021 10:03:23 +0000 (UTC) Received: from dggeme703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GMQSW09Z6zXpcg; Sat, 10 Jul 2021 17:57:47 +0800 (CST) Received: from huawei.com (10.175.124.27) by dggeme703-chm.china.huawei.com (10.1.199.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 10 Jul 2021 18:03:19 +0800 From: Miaohe Lin To: CC: , , , , , , , , , , , , , , Subject: [PATCH 2/5] mm/vmscan: remove misleading setting to sc->priority Date: Sat, 10 Jul 2021 18:03:26 +0800 Message-ID: <20210710100329.49174-3-linmiaohe@huawei.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210710100329.49174-1-linmiaohe@huawei.com> References: <20210710100329.49174-1-linmiaohe@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggeme703-chm.china.huawei.com (10.1.199.99) X-CFilter-Loop: Reflected Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=none) header.from=huawei.com X-Rspamd-Server: rspam05 X-Stat-Signature: wk5jigoeg8rb7uw339e8ruu5oiasjdcc X-Rspamd-Queue-Id: 9D25CF000F08 X-HE-Tag: 1625911403-569619 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The priority field of sc is used to control how many pages we should scan at once while we always traverse the list to shrink the pages in these functions. So these settings are unneeded and misleading. Signed-off-by: Miaohe Lin --- mm/vmscan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 6483fe0e2065..fbe53e60b248 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1702,7 +1702,6 @@ unsigned int reclaim_clean_pages_from_list(struct z= one *zone, { struct scan_control sc =3D { .gfp_mask =3D GFP_KERNEL, - .priority =3D DEF_PRIORITY, .may_unmap =3D 1, }; struct reclaim_stat stat; @@ -2327,7 +2326,6 @@ unsigned long reclaim_pages(struct list_head *page_= list) unsigned int noreclaim_flag; struct scan_control sc =3D { .gfp_mask =3D GFP_KERNEL, - .priority =3D DEF_PRIORITY, .may_writepage =3D 1, .may_unmap =3D 1, .may_swap =3D 1, --=20 2.23.0