From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 826E3C11F69 for ; Tue, 13 Jul 2021 14:40:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5297C61362 for ; Tue, 13 Jul 2021 14:40:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5297C61362 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8328A6B008C; Tue, 13 Jul 2021 10:40:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E2856B0095; Tue, 13 Jul 2021 10:40:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6839C6B0096; Tue, 13 Jul 2021 10:40:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 4BC246B008C for ; Tue, 13 Jul 2021 10:40:44 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 4C78F82F2C0C for ; Tue, 13 Jul 2021 14:40:43 +0000 (UTC) X-FDA: 78357825966.31.1BB639E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf05.hostedemail.com (Postfix) with ESMTP id DA0255009B0F for ; Tue, 13 Jul 2021 14:40:42 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id CDBAB22984; Tue, 13 Jul 2021 14:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1626187241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BwNe64VMZn2yiDWOKM8XaMldMBilnvc5QIq1eVu9sq8=; b=c2DBsYMtGFFfL1b7RKoFsDBngAZKGF9G0rW+XHgxSURqeG4qqg3Dh0ZDkYw9Zxnqq93ukB /3zX2EQyPkQzATKGgwO4nx34QY79hk4ho6WHeWL2D5TF7ziABW8qVbaruWO20JTPpj1bq5 DtvgODlLJOiPWvjq/PZH9JQGcHQwTno= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1626187241; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BwNe64VMZn2yiDWOKM8XaMldMBilnvc5QIq1eVu9sq8=; b=CZ+QKOL2vecPomdJtQee7s6HqiNVFeUFxkbMsaUlr+Qo1RE7r7dSM9IcLpqACunydKPRvc uquv7pTWVm5VZeAg== Received: from quack2.suse.cz (unknown [10.100.224.230]) by relay2.suse.de (Postfix) with ESMTP id C0233A3B83; Tue, 13 Jul 2021 14:40:41 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id ABF141E0BBE; Tue, 13 Jul 2021 16:40:41 +0200 (CEST) Date: Tue, 13 Jul 2021 16:40:41 +0200 From: Jan Kara To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v13 065/137] mm/writeback: Change __wb_writeout_inc() to __wb_writeout_add() Message-ID: <20210713144041.GC24271@quack2.suse.cz> References: <20210712030701.4000097-1-willy@infradead.org> <20210712030701.4000097-66-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712030701.4000097-66-willy@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=c2DBsYMt; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=CZ+QKOL2; spf=pass (imf05.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DA0255009B0F X-Stat-Signature: 8dbpesrww478zijxmc66a7wnjnn3spmd X-HE-Tag: 1626187242-30539 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 12-07-21 04:05:49, Matthew Wilcox (Oracle) wrote: > Allow for accounting N pages at once instead of one page at a time. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/page-writeback.c | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/mm/page-writeback.c b/mm/page-writeback.c > index 63c0dd9f8bf7..1056ff779bfe 100644 > --- a/mm/page-writeback.c > +++ b/mm/page-writeback.c > @@ -562,12 +562,12 @@ static unsigned long wp_next_time(unsigned long cur_time) > return cur_time; > } > > -static void wb_domain_writeout_inc(struct wb_domain *dom, > +static void wb_domain_writeout_add(struct wb_domain *dom, > struct fprop_local_percpu *completions, > - unsigned int max_prop_frac) > + unsigned int max_prop_frac, long nr) > { > __fprop_add_percpu_max(&dom->completions, completions, > - max_prop_frac, 1); > + max_prop_frac, nr); > /* First event after period switching was turned off? */ > if (unlikely(!dom->period_time)) { > /* > @@ -585,18 +585,18 @@ static void wb_domain_writeout_inc(struct wb_domain *dom, > * Increment @wb's writeout completion count and the global writeout > * completion count. Called from test_clear_page_writeback(). > */ > -static inline void __wb_writeout_inc(struct bdi_writeback *wb) > +static inline void __wb_writeout_add(struct bdi_writeback *wb, long nr) > { > struct wb_domain *cgdom; > > - inc_wb_stat(wb, WB_WRITTEN); > - wb_domain_writeout_inc(&global_wb_domain, &wb->completions, > - wb->bdi->max_prop_frac); > + wb_stat_mod(wb, WB_WRITTEN, nr); > + wb_domain_writeout_add(&global_wb_domain, &wb->completions, > + wb->bdi->max_prop_frac, nr); > > cgdom = mem_cgroup_wb_domain(wb); > if (cgdom) > - wb_domain_writeout_inc(cgdom, wb_memcg_completions(wb), > - wb->bdi->max_prop_frac); > + wb_domain_writeout_add(cgdom, wb_memcg_completions(wb), > + wb->bdi->max_prop_frac, nr); > } > > void wb_writeout_inc(struct bdi_writeback *wb) > @@ -604,7 +604,7 @@ void wb_writeout_inc(struct bdi_writeback *wb) > unsigned long flags; > > local_irq_save(flags); > - __wb_writeout_inc(wb); > + __wb_writeout_add(wb, 1); > local_irq_restore(flags); > } > EXPORT_SYMBOL_GPL(wb_writeout_inc); > @@ -2751,7 +2751,7 @@ int test_clear_page_writeback(struct page *page) > struct bdi_writeback *wb = inode_to_wb(inode); > > dec_wb_stat(wb, WB_WRITEBACK); > - __wb_writeout_inc(wb); > + __wb_writeout_add(wb, 1); > } > } > > -- > 2.30.2 > -- Jan Kara SUSE Labs, CR