From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53B50C07E95 for ; Fri, 16 Jul 2021 16:34:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F008F613EE for ; Fri, 16 Jul 2021 16:34:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F008F613EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 11A376B0082; Fri, 16 Jul 2021 12:34:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CA696B0087; Fri, 16 Jul 2021 12:34:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED3E46B0089; Fri, 16 Jul 2021 12:34:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0113.hostedemail.com [216.40.44.113]) by kanga.kvack.org (Postfix) with ESMTP id C4ECA6B0082 for ; Fri, 16 Jul 2021 12:34:22 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 02FDC2B349 for ; Fri, 16 Jul 2021 16:34:21 +0000 (UTC) X-FDA: 78368998722.17.16342DA Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 9B0C1F002CB1 for ; Fri, 16 Jul 2021 16:34:20 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 874DF613CF; Fri, 16 Jul 2021 16:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626453259; bh=4nBTyZyJngRe55CU3IagbmHB+MF75H0iqAAq05mV6C8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AIx1xU9prVw/X9JWCwDj1szGKyIgRTI8wAeW+GPU4GzV10VCDvt0JXGwfv6TVXFIA Gv2G+yjFMC1xO4PAMJGbb1o41q5jrKWCuIj/nlttuLPd5fBJWUa3fyIBLUg1SH9b4D aS4wh5rOadXU8gi7sX395ZVH4gXJLB6uo7fGFOfN2xxts3gBRjBjqdL6JEJ0c8fbFB vJNJf1iThBVO9I7lh0jML8F/LfFyC9VPrrDUcTtKFCKiBZJk1ND0oE78A/IGDYM5xE 8dbiUDoJljPIvLbDBrxKpbAQAUNppwN41KO73g/kQFVZvnExcB8Gr/JiVoUYRCwqPI /GufzInlxy+Vg== Date: Fri, 16 Jul 2021 09:34:18 -0700 From: "Darrick J. Wong" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v14 097/138] iomap: Pass the iomap_page into iomap_set_range_uptodate Message-ID: <20210716163418.GZ22357@magnolia> References: <20210715033704.692967-1-willy@infradead.org> <20210715033704.692967-98-willy@infradead.org> <20210715212105.GH22357@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AIx1xU9p; spf=pass (imf17.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Rspamd-Server: rspam02 X-Stat-Signature: wbh9pfkxekar8d6rxih7rkojtakngq8i X-Rspamd-Queue-Id: 9B0C1F002CB1 X-HE-Tag: 1626453260-620572 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jul 16, 2021 at 04:21:25AM +0100, Matthew Wilcox wrote: > On Thu, Jul 15, 2021 at 02:21:05PM -0700, Darrick J. Wong wrote: > > On Thu, Jul 15, 2021 at 04:36:23AM +0100, Matthew Wilcox (Oracle) wrote: > > > All but one caller already has the iomap_page, and we can avoid getting > > > it again. > > > > > > Signed-off-by: Matthew Wilcox (Oracle) > > > > Took me a while to distinguish iomap_iop_set_range_uptodate and > > iomap_set_range_uptodate, but yes, this looks pretty simple. > > Not my favourite naming, but it's a preexisting condition ;-) > > Honestly I'd like to rename iomap to blkmap or something. > And iomap_page is now hilariously badly named. But that's kind > of tangential to everything else here. I guess we only use 'blkmap' in a few places in the kernel, and nobody's going to confuse us with UFS. Hmm, what kind of new name? struct iomap_buffer_head *ibh; /* NO */ struct iomap_folio_state *ifs; struct iomap_state *is; /* shorter, but what is 'state'? */ struct iomap_blkmap *ibm; /* lolz */ I think iomap_blkmap sounds fine, since we're probably going to end up exporting it (and therefore need a clear namespace) as soon as one of the filesystems that uses page->private to stash per-page info wants to use iomap for buffered io. --D