From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7441DC636C8 for ; Sun, 18 Jul 2021 21:31:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2409361026 for ; Sun, 18 Jul 2021 21:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2409361026 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B85FF8D00F8; Sun, 18 Jul 2021 17:31:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5CF18D00EC; Sun, 18 Jul 2021 17:31:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FE638D00F8; Sun, 18 Jul 2021 17:31:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0163.hostedemail.com [216.40.44.163]) by kanga.kvack.org (Postfix) with ESMTP id 80BC78D00EC for ; Sun, 18 Jul 2021 17:31:20 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3233619B32 for ; Sun, 18 Jul 2021 21:31:19 +0000 (UTC) X-FDA: 78377004678.17.C1668B1 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by imf23.hostedemail.com (Postfix) with ESMTP id E1F6890000BB for ; Sun, 18 Jul 2021 21:31:18 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id y7so22610295ljm.1 for ; Sun, 18 Jul 2021 14:31:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F9ILCk8N3sERVUTaY+/ZVi6bG07HT24teouMKnXfFEQ=; b=ax13dcXsQdSfOz+9HVljsgiGChow9heRlR8KjejNczxJGHDUg6gsv24iZ2QyUExZmj wQh6yUun2RAFTurk6dA0NJMkInZBtaW3QlA7diHzWjCJo+2E9x/zMtsYBpzq8Qo7SLNN 3QqLXkNULJs0Q5LBpjLIp8AmZGk3FhEGYesSLd76i6x6tuJHsj2KlVu5D6OfW/lckUuY 1zXDoFoI240WefoNiWy3RY8vfT12vc5KjxjdiAWWn7Ms30PAZ75iPsrVwfHABzH7CyWW CYtzflOrlbUO8sRAbStI3uJP2bWlBubp097D1XWgZ6WtwdZxvflRVNhAEnHD7tX5BGak f/DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F9ILCk8N3sERVUTaY+/ZVi6bG07HT24teouMKnXfFEQ=; b=DzGZ1+SsHA6G5LXbQomPK1kWfHTsuky0go65QPiQYFMdlzrOCJT0LZHfJ3dFe17wE9 MDyM2hkGyz9R/6ohIMdGQOx71oZLe53ybxjzADZEIsmF+G6HnNDjaaIAjJkbU074NxmI 2uK7As1Szb91m6xrMxFmFqYhnlUj56lhp1kEYTVGMGMECqpwF5rsarAz7i3b0bkxkZXm eTkQ4Ket03YOX0fYsynfrrU50P7KlmFGVsNiaI6OCsvh8k9N7gKcQ37uwMP9ZQsr2+D6 xeIQB6qS0RjMNiAslG74AiOMHqOLCIC1Xf86UKCZUQNPHDXK2g273rZ7V/GLmX1Whnxm mDQQ== X-Gm-Message-State: AOAM531v3y1njdGd9Vbe1i/zVraAH0lwt2gh0B7eyjwrKUiCDgln9zcn 2Qxdpo3T5ZZGfINdDXldcPfhwg== X-Google-Smtp-Source: ABdhPJwtT5qmE/P10UDYjLKt4tr/vkQdwA/jD7zdttq+I56o4yokObToWGuF9FbR11p8WQaMKdSbqQ== X-Received: by 2002:a05:651c:158b:: with SMTP id h11mr19410663ljq.395.1626643877625; Sun, 18 Jul 2021 14:31:17 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r3sm1237633lfc.280.2021.07.18.14.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jul 2021 14:31:16 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id CB77E10260F; Mon, 19 Jul 2021 00:31:20 +0300 (+03) Date: Mon, 19 Jul 2021 00:31:20 +0300 From: "Kirill A. Shutemov" To: Qi Zheng Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH 2/7] mm: introduce pte_install() helper Message-ID: <20210718213120.rtqbgseb6drcwxj4@box.shutemov.name> References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-3-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210718043034.76431-3-zhengqi.arch@bytedance.com> Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=ax13dcXs; spf=none (imf23.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.208.174) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-Rspamd-Server: rspam02 X-Stat-Signature: khosemmfkr538w9hjsemnne5rpw4556i X-Rspamd-Queue-Id: E1F6890000BB X-HE-Tag: 1626643878-805189 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jul 18, 2021 at 12:30:28PM +0800, Qi Zheng wrote: > Currently we have three times the same few lines repeated in the > code. Deduplicate them by newly introduced pte_install() helper. > > Signed-off-by: Qi Zheng I don't like the name of the helper: we have confusion of PTE being PTE-entry or PTE page table. And pte_install() doing pmd_populate() doesn't help the situation. Maybe pmd_install()? Or pte_table_install()? I donno. -- Kirill A. Shutemov