From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 489FDC636CB for ; Mon, 19 Jul 2021 09:17:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E54A161165 for ; Mon, 19 Jul 2021 09:17:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E54A161165 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 78A0A8D00F6; Mon, 19 Jul 2021 05:17:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7617A8D00EC; Mon, 19 Jul 2021 05:17:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 629558D00F6; Mon, 19 Jul 2021 05:17:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 40B0D8D00EC for ; Mon, 19 Jul 2021 05:17:43 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BBE8A243B4 for ; Mon, 19 Jul 2021 09:17:41 +0000 (UTC) X-FDA: 78378784722.09.AFE4047 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf20.hostedemail.com (Postfix) with ESMTP id 3B632D0000A4 for ; Mon, 19 Jul 2021 09:17:41 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 330C468B05; Mon, 19 Jul 2021 11:17:39 +0200 (CEST) Date: Mon, 19 Jul 2021 11:17:38 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v4 05/13] drm/amdkfd: generic type as sys mem on migration to ram Message-ID: <20210719091738.GB30855@lst.de> References: <20210717192135.9030-1-alex.sierra@amd.com> <20210717192135.9030-6-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717192135.9030-6-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=none (imf20.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Stat-Signature: gmed4jmnwuu3sk3d4wsehichmygupczb X-Rspamd-Queue-Id: 3B632D0000A4 X-Rspamd-Server: rspam01 X-HE-Tag: 1626686261-428860 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jul 17, 2021 at 02:21:27PM -0500, Alex Sierra wrote: > + migrate.flags = adev->gmc.xgmi.connected_to_cpu ? > + MIGRATE_VMA_SELECT_SYSTEM : MIGRATE_VMA_SELECT_DEVICE_PRIVATE; Please just use a good old if/else to keep the code readable.